From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70087.outbound.protection.outlook.com [40.107.7.87]) by sourceware.org (Postfix) with ESMTPS id 9B5F53857B8D for ; Thu, 23 Jun 2022 07:58:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9B5F53857B8D ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=H/oguRKiXElSLyhbPWAfsB+iLb7kkdQMk90Wm2ldswOJFhZRshT30350ZG38aQSrymvSjQWIXVzRv4qxULoS5uavAbeCqwfMDJm3q8xZTx9V0tW3gv9z8NwXxHx93I+N0KwYfCK1pZseZHGfGFvUXU9u/iislENag1vreXG8i6bfu19QpR68eUPdHMh6IL5CsMU6ecwpqOgn4PXlhtebBxDtB1lVK3KB/ecqtviHtGA0FRXg1FMBoD9HLC0hIrwQ+PYNoLxgymOoclLRVqyOFrm/EK/TQ3RC6PMcGu1kH6GCuxHvS7vdq8jpu6pmUbeu2zg3ah2DUVxl8ZzG0Y6bhw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bc6CZ6QJjbG2WL706XSEskYQaEOlvWm4VDOXph9FGPw=; b=dgmrW+aOXjYgFKDsAoM5DRqZv8tCzNguIyDEaOnCnMjv3lCS57rfaO20F0UtPNVbhsOX4SROPZuTlV4KZ67crVd9JwkPAgNQKQUGBaHGMa3rRSIJH++IZjP0eVpTl7GWHYZzsG0kX33kszngTmiaIyV7uwfnHUHJuFDizXiYGgG4kLliPM1Opv4o5NkaE9Q9MEBeKzRGPNQtIanQT8R+2MO44IDkjU/O9d0rEs1iyIT6HUWNs8xVjMJF2faht/u+9A/dtxoKxMUGPuWsmbXwkfw1+FFS5MOk7nEypfY7Yok9Pzvwk9Jt/43/LPBumwJZWvDob6tVRzn23bZfepNENg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AS8PR07CA0046.eurprd07.prod.outlook.com (2603:10a6:20b:459::18) by DB8PR08MB5034.eurprd08.prod.outlook.com (2603:10a6:10:e1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Thu, 23 Jun 2022 07:58:56 +0000 Received: from VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:459:cafe::2f) by AS8PR07CA0046.outlook.office365.com (2603:10a6:20b:459::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.16 via Frontend Transport; Thu, 23 Jun 2022 07:58:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT041.mail.protection.outlook.com (10.152.19.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15 via Frontend Transport; Thu, 23 Jun 2022 07:58:55 +0000 Received: ("Tessian outbound 1766a3bff204:v120"); Thu, 23 Jun 2022 07:58:55 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f1277640d18e17a3 X-CR-MTA-TID: 64aa7808 Received: from 234da672b2f2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 177F2707-8902-4A8C-8620-5D3B4B7435F1.1; Thu, 23 Jun 2022 07:58:48 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 234da672b2f2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 23 Jun 2022 07:58:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QG8Y2hnE84sDFYhMYkQJxLvRkmUFJk4tpPk4wdRnIuZsIf9ngppQWWkKSYp1gl2OKOTt4yBIEn6QUpGm1cUJ8PUzbeP4nt7owYiYKDaCiG0j4hjSfBQqB43lBFeHQDfbE0TPGH0hUBxXnVV2/utl4RNKJOXWfym+fZUyN34uj/MppLpDXMjsvA585qYeBqZSq/W/qsCw/x/g6Pqiulwb8iyEgp4sJSrnrv3ERtPvmbKxEgqpDlE4v8oEWrOOz34NKTjbvO3I05rOM+uiC+4m7qXtjGKMhj8bcaSI89MjRjIGPXrsVjo5QF1wmeGESMgenRTAfc0RQfoAOCiSRGqZfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bc6CZ6QJjbG2WL706XSEskYQaEOlvWm4VDOXph9FGPw=; b=FAv+8SuDT50REsKPkmpHfpPvCJgZHzGY9t7PGX+6mXQUuzpgNCE7D1JnS8vniArzW9WawjwHkBcJA1hwldgZ+I3v13ZtQ4j37yq82Uuq4wM8s35RiaebHD54cu5zfYWk32QY4T3E5D8B3gra01QWFZ+7d0SnHPDWPZx0odkU1xZKbNswPacb8XjX4SpOyr/ljvE3uflGS0tPXwwCtZ0yhm2bt7cJXdhLQy4h0NdOsxxfyAkNwUnw44uZO9IJWcfi3sPTJsn9oKsN7exF2TMI+5IwyI5BZKIEKugTr05R+djqQ42qhGEw6STqWvaRNvqakLh5bwqRMVU2YpbE7bI3Lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from PAXPR08MB7172.eurprd08.prod.outlook.com (2603:10a6:102:20a::19) by GV1PR08MB7315.eurprd08.prod.outlook.com (2603:10a6:150:1e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Thu, 23 Jun 2022 07:58:46 +0000 Received: from PAXPR08MB7172.eurprd08.prod.outlook.com ([fe80::d4b6:3f55:466e:4f86]) by PAXPR08MB7172.eurprd08.prod.outlook.com ([fe80::d4b6:3f55:466e:4f86%5]) with mapi id 15.20.5373.016; Thu, 23 Jun 2022 07:58:46 +0000 Date: Thu, 23 Jun 2022 08:58:32 +0100 From: Szabolcs Nagy To: Fangrui Song Cc: binutils@sourceware.org Subject: Re: [PATCH] aarch64: Define elf_backend_extern_protected_data to 0 [PR 18705] Message-ID: References: <20220602042059.2898835-1-maskray@google.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220602042059.2898835-1-maskray@google.com> X-ClientProxiedBy: LO4P123CA0280.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::15) To PAXPR08MB7172.eurprd08.prod.outlook.com (2603:10a6:102:20a::19) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: c196ab7c-eb59-4e0f-a07c-08da54ee3895 X-MS-TrafficTypeDiagnostic: GV1PR08MB7315:EE_|VE1EUR03FT041:EE_|DB8PR08MB5034:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zGT0L3P773UmzPRLk8ZyPIGMHNLpe+dKAmbrRJeFeBPH9OD6EWjEVl3udLbOKgFL472ewTXV6GgnBUr2+RFPof4gvM/qQLOHh4nMSdhlJTCfyOI04WStf8jMuVEBYVxthskBO3/Zh4z8OLmQLg5H8ynqQoNNcPZ+ygpQ7f5m8vh4Kijfa2stxQIBWUYWyYIxuK2YeqXV5K4HsWuxlqWuoqoLoGk7vtZezpsiNeKgBactMFi+9TGeFGS1U+U8dQwCGNNHGXyzgRk7x6H8pfdIIiLU/cAmFw7xX1jKqv6jv7krUHu5donlx1jr1c37Glm7wqxowfqC/0TZXiPrT8SWz7cbTJ3eWXpqraiDIGWIKs5qUYYpnj7sr2Ki/tZ7lIno1grJh2tPPF3yIL0FJT8cD26971WZDLI3+lT4ik6/IJ4GbnYQEGaFBLOvM+5ztKSNbRpqhzO5xG2SPznkjFLV6PmjGTx2cb+r5PHjlXtCz54NuldznLGpWEQ1uA+QmhvRDAKbazl6a23hWN7tkQJGFDL2+MvwLJkdfLST9i/jgWFyIBUr/ayBGCasndiex0j+quBu3SmOGy7bwNtyilYU5iq2n9arcUSxbvEG4vX7r0JgosrRLLDW3z3pqhX5MphacP5vDBZJsvqzN6PHIz9CFoAynLAxbAqMDoGn5GsAqDHBI0cxJacuOwhvt4e6Kync X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR08MB7172.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(346002)(136003)(39860400002)(376002)(396003)(366004)(6486002)(66476007)(8676002)(83380400001)(478600001)(4326008)(66946007)(316002)(186003)(86362001)(66556008)(5660300002)(38100700002)(44832011)(8936002)(36756003)(41300700001)(6506007)(6666004)(6512007)(6916009)(26005)(2616005)(2906002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7315 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3a8e711c-93a6-448d-69c4-08da54ee32a5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n6IR1xirP51Nta2SmOfYqTKWGDzHUhVqX1v+Sc5o5PT/ECNuYIEfTcRiaW8JiWnQjkKwGYbOdflNCT5citqVRJVdgL5X+TUT5d/4amo8CVfQuHVXrfK6+Vzc1Y1YZBnTZ1NybYpIIp00uTy5iyX+xupkO5gOpiAioXqE9gq2JodlQv2B1KLidIpSvlZzCZUWIapJaigEmX7Yuul4nPegEoyr/jNeMQcgQqdCoX3SJS/sea0d+UH++DuNfzF2zgIPIoo/NZ47ZM2qlIsBfIpUzovaPQ/QLPKnSiKwmo9u23f4UmwvZ8JrRamAHuRWtO6RyENBK84/zbfqGjUYpI6yrp4LwLYtlFyxQXejc38sJo6ANK7eS44N5UOntL2EYoHy54XgTqOEFlH5p/aRmFvjE5CMrq9yMuMWjw/VBL12rQlAI0fpjPYVIiQKo+7Uq5al5ecHHvT73t3M5Q3BfCJ2eSDYcr7ZMUiQoNhMTQ/mN9gecL3mx+WSUsntawQunNceZnFv2uMyTcPDRd2ikCDclFFAwn1/KUD/2SGgW/8TO2T1TqMQ0yvm9Q4UK/AORLsNesnHuvbuwDAkPgVB6r/KaJt6AAJ/xE5D+rNfE+5XUNKTyCE7r2IKaTjV9hVnDiKlT4OEHDQnOY/Q8SO1a6ai5PMcEDfeRIQsErwjmWBg50W3SSYNvqgnRakkJjpTiRNCtqgVGOtYjJkn/ylt74xLmVogHlI7wZvI3pLk604mrbb+tNxhYMA7/8XgnYjKpjDTiwyGfRPOQQZnAyzM7C+Gqg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(136003)(396003)(376002)(346002)(39860400002)(36840700001)(40470700004)(46966006)(6506007)(6666004)(6512007)(6486002)(478600001)(81166007)(26005)(44832011)(70586007)(5660300002)(6862004)(41300700001)(8936002)(2906002)(356005)(82310400005)(40480700001)(83380400001)(2616005)(82740400003)(86362001)(36860700001)(47076005)(186003)(336012)(316002)(70206006)(40460700003)(36756003)(8676002)(4326008); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2022 07:58:55.3532 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c196ab7c-eb59-4e0f-a07c-08da54ee3895 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5034 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2022 07:59:02 -0000 The 06/01/2022 21:20, Fangrui Song wrote: > If an executable has copy relocations for extern protected data, that > can only work if the library containing the definition is built with > assumptions (a) the compiler emits GOT-generating relocations (b) the > linker produces R_*_GLOB_DAT instead of R_*_RELATIVE. Otherwise the > library uses its own definition directly and the executable accesses a > stale copy. > > Commit 32f573bcb3aaa1c9defcad79dbb5851fcc02ae2d changed ld to produce > R_AARCH64_GLOB_DAT but that defeated the purpose of protected visibility > as an optimization. Restore the previous behavior (which matches > ld.lld) by defining elf_backend_extern_protected_data to 0. This patch looks good to me. Thanks. > --- > bfd/elfnn-aarch64.c | 2 +- > ld/testsuite/ld-aarch64/protected-data.d | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c > index 4926bab9cf2..cb316a928ef 100644 > --- a/bfd/elfnn-aarch64.c > +++ b/bfd/elfnn-aarch64.c > @@ -10090,7 +10090,7 @@ const struct elf_size_info elfNN_aarch64_size_info = > #define elf_backend_dtrel_excludes_plt 1 > #define elf_backend_got_header_size (GOT_ENTRY_SIZE * 3) > #define elf_backend_default_execstack 0 > -#define elf_backend_extern_protected_data 1 > +#define elf_backend_extern_protected_data 0 > #define elf_backend_hash_symbol elf_aarch64_hash_symbol > > #undef elf_backend_obj_attrs_section > diff --git a/ld/testsuite/ld-aarch64/protected-data.d b/ld/testsuite/ld-aarch64/protected-data.d > index 5dabf04748c..ee9b4cfc6b5 100644 > --- a/ld/testsuite/ld-aarch64/protected-data.d > +++ b/ld/testsuite/ld-aarch64/protected-data.d > @@ -2,4 +2,4 @@ > #ld: -shared > #readelf: -r -W > #... > -.* R_AARCH64_GLOB_DAT .* var.* > +.* R_AARCH64_RELATIVE .* > -- > 2.36.1.255.ge46751e96f-goog >