From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70071.outbound.protection.outlook.com [40.107.7.71]) by sourceware.org (Postfix) with ESMTPS id D793E3857023 for ; Thu, 23 Jun 2022 08:22:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D793E3857023 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=WmSl8pwi9PdV51ThLvEPivTwEDyfCVS5KfyDxbE9B6jraqjo4BErFH5qbQaEgCR2gAjiz5GcTKI4ybSiV6as4F0pivHPu2jYbEYi1Mf1PQOznc2eSY4zVXs7bwc6rUugHcGRyQQu/SBJFb1ZaUiSSNrBxvKmPkfBpHPf9vPuaghanwJXetVV10PnjdlgoBSmj061pLvzjUMI2KnBH5UEk4FrvpI7kNJ1Av8oQh9O/OjjDrJn4ddMQzfG7UQK8vwJa0GvaZfjQjbX9A9EjBnXU6kB40ZCAxCO44lD9YRmto28y1B16TGah9RO7L7TKKWy6F70+tADz7v0uy55s2yGMA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eXIGH1V9zx6Wmu27n9D5dKkb8Ts7d2V0S44sly/Eh+0=; b=ZHCvwKMOlMs+lBHBNIDrKtndhardZwIMLQth7mTo73kk+kuMIMG7b4asClO5nKgizzuyMyKrIXXjIKH7xtRn9GIQp9JgdqQADftN0BR6Jy6JBL1D8mAN8PGYFXgFVeLMty1i6XgFDTMLNMk11J6f+8l87Xrb+IufgkO27DaKztKK98I6cbpeTajWbVtXzRfp0CVi15HO0kF9jyjYjwoITnaUTldbCxNG7gouvZ/Ie7gpXq5BOukUOMr4ennln4JxHsTPbxyuW4njA+QZJpq8C61X/RMYhXkVXvcNiU96j5VRz3zgA566oHfU2Yyl8QaHY6pK+RxiEmJas9HK6FiKBw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AS9PR0301CA0015.eurprd03.prod.outlook.com (2603:10a6:20b:468::23) by AM0PR08MB4113.eurprd08.prod.outlook.com (2603:10a6:208:129::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Thu, 23 Jun 2022 08:22:15 +0000 Received: from AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:468:cafe::66) by AS9PR0301CA0015.outlook.office365.com (2603:10a6:20b:468::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.16 via Frontend Transport; Thu, 23 Jun 2022 08:22:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT047.mail.protection.outlook.com (10.152.16.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15 via Frontend Transport; Thu, 23 Jun 2022 08:22:13 +0000 Received: ("Tessian outbound e40990bc24d7:v120"); Thu, 23 Jun 2022 08:22:13 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7bb0591d85e942c3 X-CR-MTA-TID: 64aa7808 Received: from cea4d07e1405.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7D4AA091-EE31-48E1-9555-5815E2E982FD.1; Thu, 23 Jun 2022 08:22:06 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cea4d07e1405.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 23 Jun 2022 08:22:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kasL8sDO1uYo2swT7OJD1k0ASDhb9EMz0taQCiauBPozAkH2/Pd3tV9diCNqrjsRxkMY9oTEMe3WKVDrJ+Jijdvyb9FGMt+a6a6iPvCNNCqA90B4xQ8LhbUwMcRQhi3Hd04uF8CcDjcyF4iI6CLr3XFBTzWuXfEQfk2+L5yQA6Gtx+F9SLdThOyqvrmc6Zqr/yoS7zrgRUqLpGnTcf0eQQkAWu8TC+dSS6U9PAKtvhihKbfRkiDC4kM8EYyNS8PU69Tr5AfbW+7YK6Ab43r4iw2pd793BFljjF7mj4k9eIaPPjI3Grs6XyqPEdo1gzE2rXFRI1pTL/0ttRlcOfAEYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eXIGH1V9zx6Wmu27n9D5dKkb8Ts7d2V0S44sly/Eh+0=; b=Bv6hbjKS+Y97bnnUXQl8WqxK4ncwa3ahT1GxEcYyyicU1y6bQ7tG4C6b6cfzCI8g++u0CKGio/ksOllURtXybq9Z8A8ta0XrsNFuBzVs4DXCYWXQnwZFPMUfFg7PWIfKC5dlVr7fMUjNgjTyQkrmEpmuyDRbj1R97W3r4u3CeYdp0AfW+1Sgdck7MR5GmoV/FJuHqc055mqKSkQheR/cyH0YuP9vFDqHe3HYvT8lxXekU1NJPbeOaGx+VL1BvtTXw2BTG20X+nB9jkSFxOLPndtETBSfOcMwhgeU4adx8K+tc3Fs/5ZQ+LgUX9VS8YRZheO7IBki2dXT9MwBM5bHcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from PAXPR08MB7172.eurprd08.prod.outlook.com (2603:10a6:102:20a::19) by AM5PR0801MB1793.eurprd08.prod.outlook.com (2603:10a6:203:3b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Thu, 23 Jun 2022 08:22:05 +0000 Received: from PAXPR08MB7172.eurprd08.prod.outlook.com ([fe80::d4b6:3f55:466e:4f86]) by PAXPR08MB7172.eurprd08.prod.outlook.com ([fe80::d4b6:3f55:466e:4f86%5]) with mapi id 15.20.5373.016; Thu, 23 Jun 2022 08:22:05 +0000 Date: Thu, 23 Jun 2022 09:21:46 +0100 From: Szabolcs Nagy To: Fangrui Song Cc: binutils@sourceware.org, Fangrui Song Subject: Re: [PATCH] arm: Define elf_backend_extern_protected_data to 0 Message-ID: References: <20220602042715.2999013-1-maskray@google.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220602042715.2999013-1-maskray@google.com> X-ClientProxiedBy: SA1PR02CA0004.namprd02.prod.outlook.com (2603:10b6:806:2cf::8) To PAXPR08MB7172.eurprd08.prod.outlook.com (2603:10a6:102:20a::19) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 94564c1b-12f6-4a4c-b789-08da54f17a25 X-MS-TrafficTypeDiagnostic: AM5PR0801MB1793:EE_|AM5EUR03FT047:EE_|AM0PR08MB4113:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3ABkfm6I1feJZk+4tp7EzNpSnRdIU30pe3A1DP6lxCNFq0v5401XfZuIOcvMs9DXYS8vD7R5TKHRTdsWYmkdG9rWUi8tAOuCEb7/h1k3Tv3iLzZPZIAsj7Z0bs2HE7UR/ih8DyzE0SNbPeGrLferMNmz8K+CcuQ4ZXyevxcQemvx4E5kzgjOd3UEv7/gXT60j9F+mAp6aBYB43LPGGy2SAGP81nft1oUz2lic4fLBYzCEOahecQCl4Pv0GJeEIjVkB2EITFVevVpZn/uuGki+trSBDZtrN/Cn6PBj0AzTK/Llyk7Jm9RgsV/aVxtzN2nkeI1pQuyzWKLzKMKWeLn4EfK3If7ASb0h+9MTN0vMg+neq/Kdv3EV9MZLVCw9vMqbB587Kqg5qCCNEhfiDE6BL7L+KFP1B9keMfYM3zi4nBppDkuSL9/ouYoMPkTmFd59fHDqACao7hzJ3EZUxbaaF7aiyLrgYWLnRrArYeW5zBLgv+qLUr7Cv5S+0dCogx0vKrqDroBJ0X3+pwF0EKp6A92S8NSLd/2wQdcXBXEk4az6yaTeCqYdkm70hdIrJa4fJBci6b7B9VCEEkhQwzJwXEgIcsK89lgc3oPnWLsqWw94Vr1/mQD80uIyWnf9J5osSWaw4aWb/OVTI8QUEJEQsJu/0lGCTbqwTdne5tLE7v0Sg877iYTle7we9mqk5OR X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR08MB7172.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(136003)(346002)(376002)(39860400002)(396003)(366004)(8676002)(316002)(4326008)(66556008)(66946007)(66476007)(8936002)(5660300002)(83380400001)(6916009)(36756003)(2906002)(6486002)(44832011)(6512007)(478600001)(6666004)(26005)(86362001)(41300700001)(186003)(2616005)(6506007)(38100700002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1793 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a9edc44f-9aec-48d4-852a-08da54f17479 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dGGE96992oVJ0f+vz1luv1hPptNeboKQZ0pGzXeGyPfFGHf1Gdj77DSdpfadR8l6+kEybvrvpgD+Z4x96jpXklsKcXrE7rIuJehk+A9VY5JGW+uwohjub4KqXtWAvZIiw1LyMKzByPpAwu9oFvK1FUMpYYYuCD1Fplz2yvJZpJNmHzRNxks14fs0/GdRwc6Lxxxdrg0CK0eg9PC9FBmc1o6uK2U3vzmuqrwxdx722nIpT137KVX227g5pBUP9AUjVGzul9FBDz7hPRdpXnO99mYYehhfb310bk7X76n8MRW7afACqWZ+8CzQLvsxVOgVLbb1fYU0y3L148vGnXgiykq2S/1qfEbcsdzhhyLtFiOud/AQvmCE2EJ+4gOglSMVXYTXqg+7RbY/8ZyLgbMBMSSRtDy7ka2+9+XHaAI4zF9mL2cD+1RE7amrDBLDdA3JCWdaZNpbgDRftzuQSdEdzs9+SLlBoKZ/aZS4QWHr0wXMyB/oehVspuc1gBmPss+JR2DOWV7K+47du1yPnYjLVb9lGmLCYM2YBVl9NnnseGJGKyNBFcz+HFSm/Abx+g+OCcwu6PWfnYFFOhrmY/Bb1t7ZQ5nHDu2i0uGDVh4QKI0eeku5h+7mssllZ5NdVtreEYJ0JTvIH2R2c7mWWTWWl+25n56Az9NeuJsJ7Q9OrzkF0UMT1PAj40kW/y4xEv86ntI3QMyve3byYMjnoZDbA/xM8WnnzaJEk2nXfSg+ETZO2w0rbSB5BhYOq3GCsN47n1uOKp3uZ6ESFR+APOfyEA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(136003)(346002)(39860400002)(396003)(376002)(40470700004)(46966006)(36840700001)(36756003)(81166007)(40480700001)(336012)(41300700001)(2616005)(107886003)(2906002)(82310400005)(6512007)(8936002)(6506007)(26005)(44832011)(40460700003)(5660300002)(6862004)(6666004)(316002)(47076005)(186003)(83380400001)(356005)(4326008)(82740400003)(70206006)(70586007)(8676002)(86362001)(6486002)(36860700001)(478600001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2022 08:22:13.8865 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 94564c1b-12f6-4a4c-b789-08da54f17a25 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4113 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2022 08:22:29 -0000 The 06/01/2022 21:27, Fangrui Song wrote: > From: Fangrui Song > > If an executable has copy relocations for extern protected data, that > can only work if the library containing the definition is built with > assumptions (a) the compiler emits GOT-generating relocations (b) the > linker produces R_*_GLOB_DAT instead of R_*_RELATIVE. Otherwise the > library uses its own definition directly and the executable accesses a > stale copy. > > Commit b68a20d6675f1360ea4db50a9835c073675b9889 changed ld to produce > R_ARM_GLOB_DAT but that defeated the purpose of protected visibility > as an optimization. Restore the previous behavior (which matches > ld.lld) by defining elf_backend_extern_protected_data to 0. This patch looks good to me. Thanks. > --- > bfd/elf32-arm.c | 2 +- > ld/testsuite/ld-arm/protected-data.d | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c > index 5b8f5e5a0e6..36f09cb3427 100644 > --- a/bfd/elf32-arm.c > +++ b/bfd/elf32-arm.c > @@ -20315,7 +20315,7 @@ elf32_arm_backend_symbol_processing (bfd *abfd, asymbol *sym) > #define elf_backend_dtrel_excludes_plt 1 > > #define elf_backend_got_header_size 12 > -#define elf_backend_extern_protected_data 1 > +#define elf_backend_extern_protected_data 0 > > #undef elf_backend_obj_attrs_vendor > #define elf_backend_obj_attrs_vendor "aeabi" > diff --git a/ld/testsuite/ld-arm/protected-data.d b/ld/testsuite/ld-arm/protected-data.d > index 3f266dea1b4..7dffe9ab958 100644 > --- a/ld/testsuite/ld-arm/protected-data.d > +++ b/ld/testsuite/ld-arm/protected-data.d > @@ -2,4 +2,4 @@ > #ld: -shared > #readelf: -r -W > #... > -.* R_ARM_GLOB_DAT .* var.* > +.* R_ARM_RELATIVE .* > -- > 2.36.1.255.ge46751e96f-goog >