From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id 439183857BB2 for ; Thu, 14 Jul 2022 06:03:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 439183857BB2 Received: by mail-pf1-x42f.google.com with SMTP id c3so31951pfb.13 for ; Wed, 13 Jul 2022 23:03:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=giu8IRyaZoTitOsGFSpr+zo1jolLEaQmAiHzz06zHfQ=; b=RGcXbAXsqZBB0Kg9Nc36genMXeXmit0U3wBeQEMmCWBJdu+3Vn7dIiKww6BEJsBmg+ cD1NdwNFd7Ue2mx48GZg0bI/jysInE9+AvNaL75ROSu3dZQyvDInrwl6GxJyN35tmdTz tXYsnMOQJhQhR+dI7tBwgVQtmcWieEAJsK/bgDz07dvGejdj2tqP4WOZ5925G0GnAmg/ Nq5G4ip/cQyHeTdOcJqe2ncny7MnY++7y8XahtF5HRQvVQivEp6VQA1W/cYYaYfu3H2x SwEU6mikQywY2aRAJ3nB9PiZTrdj7SWZa7vfrVfNXLEF0BI8cuAtUh/lJjEOzjvISxpu 9ulg== X-Gm-Message-State: AJIora/BEbt4E8E6v0Ui8yGoe0Z5CrFGBbQgsqZ8bWnMjghKIH0e2L6v erLJskC8+6O+GOFGTFN1j0Q= X-Google-Smtp-Source: AGRyM1ux0RgexR+DWGshzDNezK8tG057m9FUPP2cytAgb1zqN9AtnDkNw1KJAPyuDmJ3HaukGNvbcA== X-Received: by 2002:a05:6a00:158e:b0:52a:e628:8b3b with SMTP id u14-20020a056a00158e00b0052ae6288b3bmr7123725pfk.80.1657778604168; Wed, 13 Jul 2022 23:03:24 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id c190-20020a621cc7000000b005289fbef7c4sm634359pfc.140.2022.07.13.23.03.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 23:03:23 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id EBC7F1140149; Thu, 14 Jul 2022 15:33:20 +0930 (ACST) Date: Thu, 14 Jul 2022 15:33:20 +0930 From: Alan Modra To: Dmitry Selyutin Cc: binutils@sourceware.org, Luke Leighton , Jan Beulich Subject: Re: PowerPC: implement md_operand to parse register names Message-ID: References: <20220712212223.87226-2-ghostmansd@gmail.com> <20220712212959.94767-1-ghostmansd@gmail.com> <20220712212959.94767-2-ghostmansd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3036.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2022 06:03:27 -0000 I meant to make this change before committing, to let compilers know the code on the false branch of md_parse_name is dead. * config/tc-ppc.c (ppc_parse_name): Return void. * config/tc-ppc.h (md_parse_name): Always true. (ppc_parse_name): Update prototype. diff --git a/gas/config/tc-ppc.c b/gas/config/tc-ppc.c index 05d8ee19be7..452fab1cbfc 100644 --- a/gas/config/tc-ppc.c +++ b/gas/config/tc-ppc.c @@ -862,7 +862,7 @@ static const struct pd_reg cr_cond[] = to use for condition codes, and recognises other registers when -mregnames. */ -int +void ppc_parse_name (const char *name, expressionS *exp, enum expr_mode mode) { const struct pd_reg *reg = NULL; @@ -877,7 +877,7 @@ ppc_parse_name (const char *name, expressionS *exp, enum expr_mode mode) exp->X_op = O_register; exp->X_add_number = reg->value; exp->X_md = reg->flags; - return true; + return; } /* The following replaces code in expr.c operand() after the @@ -909,8 +909,6 @@ ppc_parse_name (const char *name, expressionS *exp, enum expr_mode mode) exp->X_add_symbol = sym; exp->X_add_number = 0; } - - return true; } /* Propagate X_md and check register expressions. This is to support diff --git a/gas/config/tc-ppc.h b/gas/config/tc-ppc.h index 480c952be45..de9522d4bf6 100644 --- a/gas/config/tc-ppc.h +++ b/gas/config/tc-ppc.h @@ -322,8 +322,9 @@ extern void ppc_frob_label (symbolS *); /* call md_pcrel_from_section, not md_pcrel_from */ #define MD_PCREL_FROM_SECTION(FIX, SEC) md_pcrel_from_section(FIX, SEC) -#define md_parse_name(name, exp, mode, c) ppc_parse_name (name, exp, mode) -extern int ppc_parse_name (const char *, struct expressionS *, enum expr_mode); +#define md_parse_name(name, exp, mode, c) \ + (ppc_parse_name (name, exp, mode), true) +extern void ppc_parse_name (const char *, struct expressionS *, enum expr_mode); #define md_optimize_expr(left, op, right) ppc_optimize_expr (left, op, right) extern int ppc_optimize_expr (expressionS *, operatorT, expressionS *); -- Alan Modra Australia Development Lab, IBM