From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: read.c s_include: use notes obstack for path
Date: Sat, 9 Jul 2022 21:57:21 +0930 [thread overview]
Message-ID: <Ysl0KROObTDz3hO7@squeak.grove.modra.org> (raw)
* read.c (s_include): Use notes obstack for path mem.
diff --git a/gas/read.c b/gas/read.c
index 6472501f5cf..71bb30e4e70 100644
--- a/gas/read.c
+++ b/gas/read.c
@@ -5879,8 +5879,7 @@ s_include (int arg ATTRIBUTE_UNUSED)
}
demand_empty_rest_of_line ();
- path = XNEWVEC (char, (unsigned long) i
- + include_dir_maxlen + 5 /* slop */ );
+ path = notes_alloc ((size_t) i + include_dir_maxlen + 5);
for (i = 0; i < include_dir_count; i++)
{
@@ -5894,10 +5893,9 @@ s_include (int arg ATTRIBUTE_UNUSED)
}
}
- free (path);
+ notes_free (path);
path = filename;
gotit:
- /* malloc Storage leak when file is found on path. FIXME-SOMEDAY. */
register_dependency (path);
input_scrub_insert_file (path);
}
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2022-07-09 12:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ysl0KROObTDz3hO7@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).