From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: free read_symbol_name string
Date: Sat, 9 Jul 2022 21:55:48 +0930 [thread overview]
Message-ID: <YslzzHLAYOpDncn/@squeak.grove.modra.org> (raw)
read_symbol_name mallocs the string it returns. Free it when done.
* read.c (read_symbol_name): Free name on error path.
* config/tc-ppc.c (ppc_GNU_visibility): Free name returned from
read_symbol_name.
(ppc_extern, ppc_globl, ppc_weak): Likewise.
diff --git a/gas/config/tc-ppc.c b/gas/config/tc-ppc.c
index 4d789fd16a9..5f2c41621b4 100644
--- a/gas/config/tc-ppc.c
+++ b/gas/config/tc-ppc.c
@@ -4231,6 +4231,7 @@ static void ppc_GNU_visibility (int visibility) {
if ((name = read_symbol_name ()) == NULL)
break;
symbolP = symbol_find_or_make (name);
+ free (name);
coffsym = coffsymbol (symbol_get_bfdsym (symbolP));
coffsym->native->u.syment.n_type &= ~SYM_V_MASK;
@@ -4837,6 +4838,7 @@ ppc_extern (int ignore ATTRIBUTE_UNUSED)
return;
sym = symbol_find_or_make (name);
+ free (name);
if (*input_line_pointer == ',')
{
@@ -4872,6 +4874,7 @@ ppc_globl (int ignore ATTRIBUTE_UNUSED)
return;
sym = symbol_find_or_make (name);
+ free (name);
S_SET_EXTERNAL (sym);
if (*input_line_pointer == ',')
@@ -4908,6 +4911,7 @@ ppc_weak (int ignore ATTRIBUTE_UNUSED)
return;
sym = symbol_find_or_make (name);
+ free (name);
S_SET_WEAK (sym);
if (*input_line_pointer == ',')
diff --git a/gas/read.c b/gas/read.c
index c6ce0345892..35446ff0f8b 100644
--- a/gas/read.c
+++ b/gas/read.c
@@ -1699,6 +1699,7 @@ read_symbol_name (void)
{
as_bad (_("expected symbol name"));
ignore_rest_of_line ();
+ free (start);
return NULL;
}
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2022-07-09 12:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YslzzHLAYOpDncn/@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).