From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id 7DAFF3858028; Wed, 20 Jul 2022 01:49:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7DAFF3858028 Received: by mail-pg1-x52b.google.com with SMTP id r186so15096467pgr.2; Tue, 19 Jul 2022 18:49:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PNu5uM3dg9vp2+RRiV793TJJCh4SVn1L/g6qcA1M0kw=; b=8DrtB/lQ9BiIq/ujGXtHiJOZyal9SYjACNnPNB6J/JCzZ8sE7AervfVi3/hmtZ4DwP WpLh09gq1r/Xaq4597dtEteDXdiqXizVhxLXAWHOwzX3ojgbxluAypmJZ2gvZr2epSVJ 2vjn/0+3sCwi1g0gXKVRWp3hmwq0XMoPKeYesWR49eI4SoLC5rozBEqfSbAp3PQXwGWL G4xD76s2wlvEEp0SeHoKT5UZh7/ugV2Fpkhn8SBb0rSByC8A/eHIl+lOovyaUnREKgAh 1dDLpFBeR0Bhy/fMNhCyw2NJeZP2ytNu7fUajY1cJc/iCQScKlISglQz67wkf22SKNVB Oy9A== X-Gm-Message-State: AJIora+XBSEJZ4gaJUXprqkj9Kkp8SmX5mFJ2E7RHdY7dYSgu07iC2sG MQkqpSaJ4hkLVJB1KQ8tYNc= X-Google-Smtp-Source: AGRyM1uXbS0mg+tOT0J1v1bKO/9pxGAPrfzdSSBpp8EuT1ECxnqLaFWK7Opgs5ftqTgM8yhbM68wFQ== X-Received: by 2002:aa7:8e86:0:b0:528:c755:1d96 with SMTP id a6-20020aa78e86000000b00528c7551d96mr36605679pfr.30.1658281741456; Tue, 19 Jul 2022 18:49:01 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id 82-20020a621955000000b005281d926733sm12114133pfz.199.2022.07.19.18.49.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 18:49:00 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id A0CA8114030D; Wed, 20 Jul 2022 11:18:57 +0930 (ACST) Date: Wed, 20 Jul 2022 11:18:57 +0930 From: Alan Modra To: Andrew Burgess Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH] binutils-gdb/git: highlight whitespace errors in source files Message-ID: References: <20220719142631.1882613-1-aburgess@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220719142631.1882613-1-aburgess@redhat.com> X-Spam-Status: No, score=-3030.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2022 01:49:03 -0000 On Tue, Jul 19, 2022 at 03:26:31PM +0100, Andrew Burgess via Binutils wrote: > For a long time I've had this in my ~/.gitconfig: > > [core] > whitespace = space-before-tab,indent-with-non-tab,trailing-space > > which causes git to show me if I muck up and use spaces instead of > tabs, or leave in trailing whitespace. I find this really useful. Same here. > I recently proposed adding something like this to the .gitattributes > files for the GDB sub-directories (gdb, gdbsupport, and gdbserver)[1], > however, the question was asked - couldn't this be done at the top > level? I'm happy with your patch. -- Alan Modra Australia Development Lab, IBM