From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by sourceware.org (Postfix) with ESMTPS id 525433835839 for ; Fri, 22 Jul 2022 02:28:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 525433835839 Received: by mail-pj1-x1035.google.com with SMTP id gq7so3225885pjb.1 for ; Thu, 21 Jul 2022 19:28:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition; bh=E+ETorBQ1g5k8+hzBRpq7WWnRHnfWBUjWo1/3R/E3aA=; b=vuDyQFGEhdMHgHKdFGEO0iQAe/wPQ/kdms+7V6v5E9vdmdncTbYFhWwSqq5QBpJJ4D yIJpuh1zYAhVEmU9mm/h7EeyeCS0LRHQtO4LMoFEM7p3OszVQomlJyxjyjQa0pJF2mfR cqr6NS/dqxE1ElmaZPN7ZSL4HostpU7K8Lf87tAvvT1dexUHZHJ31BCVsslS7K0cJwRC jh+nZlx/mzJPpNkhiE1sYFvIwxtaqsD71+g3Hk9PUpinO5Ax9leY73S392yQ7qj15URp U1ujrUkMLK3r05OPLOQ491z/DYyVHgVEr+3jYv2d3hzb1SrxfacklCcioZq/3nNYxtN1 QA4A== X-Gm-Message-State: AJIora+yttpgXLX5EKWHVooQGMIudnN6rtG+PGFv1nsqy0trz46eA7SM hJxeBIHt4uo0m3QW2cK0rH4AYTE3xNM= X-Google-Smtp-Source: AGRyM1sXUxwSJFa+ROC23q/nLC3XKsm9r0D9pMB1SX8IjHCad24aYWoN3dBtXkPivp17dejLXFiSNA== X-Received: by 2002:a17:903:2302:b0:16d:3e89:2152 with SMTP id d2-20020a170903230200b0016d3e892152mr1250777plh.46.1658456918983; Thu, 21 Jul 2022 19:28:38 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:8510:31b:4e97:43af]) by smtp.gmail.com with ESMTPSA id s7-20020a170902ea0700b0016a3f9e4865sm2431925plg.148.2022.07.21.19.28.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jul 2022 19:28:38 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 1E77E1140AE5; Fri, 22 Jul 2022 11:58:36 +0930 (ACST) Date: Fri, 22 Jul 2022 11:58:36 +0930 From: Alan Modra To: binutils@sourceware.org Subject: PR15951, binutils testsuite builds status wrapper unconditionally Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3035.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2022 02:28:41 -0000 This bug has been sitting in bugzilla, with a patch (different to this one, I'm copying from gdb) for 3234 days. Which says we don't have enough competent people looking at bugzilla. Please help out if you can. PR 15951 * testsuite/binutils-all/objcopy.exp: Build testglue.o when needs_status_wrapper. diff --git a/binutils/testsuite/binutils-all/objcopy.exp b/binutils/testsuite/binutils-all/objcopy.exp index 9a5dad5384e..5871d431eea 100644 --- a/binutils/testsuite/binutils-all/objcopy.exp +++ b/binutils/testsuite/binutils-all/objcopy.exp @@ -641,7 +641,12 @@ proc copy_setup { } { global test_prog global host_triplet - set res [build_wrapper testglue.o] + if {[target_info exists needs_status_wrapper] && \ + [target_info needs_status_wrapper] != "0"} { + set res [build_wrapper testglue.o] + } else { + set res "" + } set flags { debug } if { [istarget *-*-uclinux*] && ![istarget tic6x-*-*] && ![istarget arm*-*-uclinuxfdpiceabi] } { -- Alan Modra Australia Development Lab, IBM