From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by sourceware.org (Postfix) with ESMTPS id 339D5385829F for ; Sat, 13 Aug 2022 06:50:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 339D5385829F Received: by mail-pj1-x102c.google.com with SMTP id gp7so2770610pjb.4 for ; Fri, 12 Aug 2022 23:50:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc; bh=lKDedWBnE+BBqfH+RWidvEnSPM9r8qEPcAajOiqNpQI=; b=WVxK7/EsknkOaS915grMQzx7X6huyUumlTp0vRzL89edJPAtZFOcTZB1Ik2SS/PDL+ utJsDJZuoIc+cDOuZcFiHv8i0f4THFODxtR1Nhsh1NwxtoaKR3k+RZI0Gvw/QhLW8oml 3G6s6LnyERQ6399jQgJ94yS+7huk6VmofDZ4tLPBx7zpEKqEgTx+hCzqZM5v7ywea2Gz bjyj4kRJijhGZC3aQZucL0ob8/4lXbB8UrcpT+cAQo8d8CY8BfCJpv/PqlvCm825vWDN qvQqadJyi2n2k9OIpQm9UtH4tqbsiX5CmcNlHmqY0UXk7AALFwpE69g5SiGcRmP7KdrX EoIQ== X-Gm-Message-State: ACgBeo1EAinQVTv4heM7F34jTIrAb0kXAos1g9BmRVp/l6C7ce1kFxA6 +lZKTafwJwd7E4Yv1ioIHQNCVEKCljI= X-Google-Smtp-Source: AA6agR56lCkCnpZZnTSt0scLIkREkeOS6Yn1NDYcXOc0uM4rWyiLM3Glk+w86T0JluaTYvPSAeRtYw== X-Received: by 2002:a17:90b:4a82:b0:1f5:5eaa:68a with SMTP id lp2-20020a17090b4a8200b001f55eaa068amr17017252pjb.13.1660373437176; Fri, 12 Aug 2022 23:50:37 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:3fe:1fa:8806:9313]) by smtp.gmail.com with ESMTPSA id h26-20020aa79f5a000000b0052d33bf14d6sm2758980pfr.63.2022.08.12.23.50.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Aug 2022 23:50:36 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 71A591142EC1; Sat, 13 Aug 2022 16:20:34 +0930 (ACST) Date: Sat, 13 Aug 2022 16:20:34 +0930 From: Alan Modra To: binutils@sourceware.org Subject: ubsan: undefined shift in sign_extend Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3035.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Aug 2022 06:50:39 -0000 * libhppa.h (sign_extend): Avoid undefined behaviour. diff --git a/bfd/libhppa.h b/bfd/libhppa.h index 1de2d5c943b..ebaffe66abf 100644 --- a/bfd/libhppa.h +++ b/bfd/libhppa.h @@ -162,7 +162,7 @@ enum hppa_reloc_expr_type_alt static inline unsigned ATTRIBUTE_UNUSED sign_extend (unsigned x, unsigned len) { - unsigned signbit = (1 << (len - 1)); + unsigned signbit = (1u << (len - 1)); unsigned mask = (signbit << 1) - 1; return ((x & mask) ^ signbit) - signbit; } -- Alan Modra Australia Development Lab, IBM