From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id A91BD3858D1E for ; Wed, 17 Aug 2022 08:00:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A91BD3858D1E Received: by mail-pf1-x435.google.com with SMTP id 130so11412491pfv.13 for ; Wed, 17 Aug 2022 01:00:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc; bh=2IucNMQ0lrQWCHfSiZ+6BnFMvotClWdbJ3DCkxw5VWc=; b=Hp5eedfQXaY8wVDpfbJf7TbnSegs2yrU/OQyvrPSrvoVYWJBEGDh5TouEIfM1sgbzB 2+mGAhBXAbThWjn30Svdezur4vR/4LoppExjOy4wqnwx7WpVDXtmNO2ZkbgAXjPz3XrK EtIY6WJOiKYpXfnqmebFeOpxEjxZ8GralIe8UGgNVfAQ3YOzJbHKXwio9dUPKPeJPerR DRtcnnBPyDPP90QG0OwHiCFZxjxYS2nj5VqfI/kuO/QSnJ9tT6bMfbEk5ml4JcZlECFT C13Yd0+wIzAlEYSzjycvpmEJtOSWLqwtgZunAf682fKU0bKSYc+fQfLinUmmdikBwmkk 7KYw== X-Gm-Message-State: ACgBeo3Ex5P0bgrBjNZv9gFRq9sms5EhQ6Nw143ceUBNeXfqYS7UV1P4 pVDEJdql13fikCU8Lv+fId5TZlKy63g= X-Google-Smtp-Source: AA6agR45ElWNtoSZEOv2bHmpXfJ///RwquYGMfqUduOkAx/T/3e9NGUaA5oKYWEBQQlXgk/IWbSvpw== X-Received: by 2002:aa7:960a:0:b0:52d:862b:55a7 with SMTP id q10-20020aa7960a000000b0052d862b55a7mr24402727pfg.19.1660723258125; Wed, 17 Aug 2022 01:00:58 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id u1-20020a170902e80100b001709e3c750dsm746958plg.194.2022.08.17.01.00.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 01:00:57 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id D93BC1142E78; Wed, 17 Aug 2022 17:30:54 +0930 (ACST) Date: Wed, 17 Aug 2022 17:30:54 +0930 From: Alan Modra To: binutils@sourceware.org Subject: bfd_elf_set_group_contents assertion Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3036.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Aug 2022 08:01:01 -0000 objcopy of broken SHT_GROUP sections shouldn't write garbage. * elf.c (bfd_elf_set_group_contents): If number of entries is unexpected, fill out section with zeros. diff --git a/bfd/elf.c b/bfd/elf.c index 2e01d7e9a44..35aa45e3b90 100644 --- a/bfd/elf.c +++ b/bfd/elf.c @@ -3614,7 +3614,12 @@ bfd_elf_set_group_contents (bfd *abfd, asection *sec, void *failedptrarg) } loc -= 4; - BFD_ASSERT (loc == sec->contents); + if (loc != sec->contents) + { + BFD_ASSERT (0); + memset (sec->contents + 4, 0, loc - sec->contents); + loc = sec->contents; + } H_PUT_32 (abfd, sec->flags & SEC_LINK_ONCE ? GRP_COMDAT : 0, loc); } -- Alan Modra Australia Development Lab, IBM