From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: Re: bfd_cleanup for object_p
Date: Sat, 24 Sep 2022 11:35:18 +0930 [thread overview]
Message-ID: <Yy5l3jjlTgBypFV1@squeak.grove.modra.org> (raw)
Bits still missing from commit cb001c0d283d.
* aoutx.h (aout_@var{size}_some_aout_object_p): Correct synopsis.
* i386lynx.c (lynx_core_file_p): Correct return type.
* ptrace-core.c (ptrace_unix_core_file_p): Likewise.
diff --git a/bfd/aoutx.h b/bfd/aoutx.h
index e9b5188e8e7..4aed23426ca 100644
--- a/bfd/aoutx.h
+++ b/bfd/aoutx.h
@@ -451,10 +451,10 @@ FUNCTION
aout_@var{size}_some_aout_object_p
SYNOPSIS
- const bfd_target *aout_@var{size}_some_aout_object_p
+ bfd_cleanup aout_@var{size}_some_aout_object_p
(bfd *abfd,
struct internal_exec *execp,
- const bfd_target *(*callback_to_real_object_p) (bfd *));
+ bfd_cleanup (*callback_to_real_object_p) (bfd *));
DESCRIPTION
Some a.out variant thinks that the file open in @var{abfd}
diff --git a/bfd/i386lynx.c b/bfd/i386lynx.c
index 840be8fd36d..5df3d19ffe0 100644
--- a/bfd/i386lynx.c
+++ b/bfd/i386lynx.c
@@ -87,7 +87,7 @@
char *lynx_core_file_failing_command ();
int lynx_core_file_failing_signal ();
bool lynx_core_file_matches_executable_p ();
-const bfd_target *lynx_core_file_p ();
+bfd_cleanup lynx_core_file_p ();
#define MY_core_file_failing_command lynx_core_file_failing_command
#define MY_core_file_failing_signal lynx_core_file_failing_signal
diff --git a/bfd/ptrace-core.c b/bfd/ptrace-core.c
index c4afffbfb95..cf39ff42a6e 100644
--- a/bfd/ptrace-core.c
+++ b/bfd/ptrace-core.c
@@ -48,7 +48,7 @@ struct trad_core_struct
/* forward declarations */
-const bfd_target *ptrace_unix_core_file_p (bfd *abfd);
+bfd_cleanup ptrace_unix_core_file_p (bfd *abfd);
char * ptrace_unix_core_file_failing_command (bfd *abfd);
int ptrace_unix_core_file_failing_signal (bfd *abfd);
#define ptrace_unix_core_file_matches_executable_p generic_core_file_matches_executable_p
--
Alan Modra
Australia Development Lab, IBM
next reply other threads:[~2022-09-24 2:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-24 2:05 Alan Modra [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-03-02 8:59 Alan Modra
2020-03-02 12:38 ` H.J. Lu
2020-03-02 13:22 ` Alan Modra
2020-03-02 13:46 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy5l3jjlTgBypFV1@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).