From: Alan Modra <amodra@gmail.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: Jan Beulich <jbeulich@suse.com>, binutils@sourceware.org
Subject: Re: [PATCH 1/1] bfd: Stop using -Wstack-usage=262144 when built with Clang
Date: Wed, 14 Sep 2022 14:47:39 +0930 [thread overview]
Message-ID: <YyFj81SHBPkHUVQU@squeak.grove.modra.org> (raw)
In-Reply-To: <cb8bcc56-e784-edd5-9d5e-4eba58bf2046@irq.a4lg.com>
On Wed, Sep 14, 2022 at 12:29:20AM +0900, Tsukasa OI via Binutils wrote:
> On 2022/09/13 22:44, Jan Beulich wrote:
> > On 13.09.2022 14:59, Tsukasa OI wrote:
> >> Some components of GNU Binutils will pass "-Wstack-usage=262144" when
> >> "GCC >= 5.0" is detected. However, Clang does not support "-Wstack-usage",
> >> despite that related configuration part in bfd/warning.m4 handles the latest
> >> Clang (15.0.0 as of this writing) as "GCC >= 5.0".
> >>
> >> The option "-Wstack-usage" was ignored when the first version of Clang is
> >> released but even this "ignoring" behavior is removed before Clang 4.0.0.
> >> So, if we give Clang "-Wstack-usage=262144", it generates a warning, making
> >> the build failure.
> >
> > While not exactly the same, how about passing -Wframe-larger-than= when
> > it's (new enough) Clang, instead of not passing any such option?
>
> That's a good idea. But if I do that, that would make another patchset
> on top of this (not PATCH v2 of this).
That's fair enough. The patch is OK, thanks.
> We need to know a good value of -Wframe-larger-than= for Clang and
> meanwhile, just removing the -Wstack-usage looks acceptable for me. For
> now, that would be nice to have an approval to apply this patch as is.
>
> >
> > Jan
> >
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2022-09-14 5:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 12:59 [PATCH 0/1] " Tsukasa OI
2022-09-13 12:59 ` [PATCH 1/1] " Tsukasa OI
2022-09-13 13:44 ` Jan Beulich
2022-09-13 15:29 ` Tsukasa OI
2022-09-14 5:17 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyFj81SHBPkHUVQU@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
--cc=research_trasio@irq.a4lg.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).