public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@gmail.com>
To: Mark Harmstone <mark@harmstone.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 1/2] ld: Add --pdb option
Date: Wed, 5 Oct 2022 14:50:47 +1030	[thread overview]
Message-ID: <Yz0GH4AlYUBNqZv2@squeak.grove.modra.org> (raw)
In-Reply-To: <20221003014313.28766-1-mark@harmstone.com>

On Mon, Oct 03, 2022 at 02:43:12AM +0100, Mark Harmstone wrote:
> @@ -955,6 +960,13 @@ gld${EMULATION_NAME}_handle_option (int optc)
>        if (strcmp (optarg, "none"))
>  	emit_build_id = xstrdup (optarg);
>        break;
> +    case OPTION_PDB:
> +      if (emit_build_id == NULL)
> +	emit_build_id = xstrdup (DEFAULT_BUILD_ID_STYLE);
> +      pdb = 1;
> +      if (optarg)
> +	pdb_name = xstrdup (optarg);
> +      break;

This will result in "--emit-build-id=none --pdb" enabling build-id
while "--pdb --emit-build-id=none" will disable build-id.  Is that
what you want?

If the intent is to always force build-id on then you should do so in
after_parse instead.  Otherwise both patches look OK to me.

-- 
Alan Modra
Australia Development Lab, IBM

      parent reply	other threads:[~2022-10-05  4:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-03  1:43 Mark Harmstone
2022-10-03  1:43 ` [PATCH 2/2] ld: Add minimal pdb generation Mark Harmstone
2022-10-03  5:12 ` [PATCH 1/2] ld: Add --pdb option Martin Storsjö
2022-10-03 16:57   ` Mark Harmstone
2022-10-03 18:58     ` Martin Storsjö
2022-10-07 12:16       ` Martin Storsjö
2022-10-09 23:46         ` Mark Harmstone
2022-10-10 10:27           ` Martin Storsjö
2022-10-10 16:55             ` Mark Harmstone
2022-10-10 20:58               ` Martin Storsjö
2022-10-05  4:20 ` Alan Modra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yz0GH4AlYUBNqZv2@squeak.grove.modra.org \
    --to=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=mark@harmstone.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).