From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id 82A883858D32 for ; Wed, 5 Oct 2022 04:20:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 82A883858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x433.google.com with SMTP id 204so56533pfx.10 for ; Tue, 04 Oct 2022 21:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=oxMZwcWcALIT/M2QVCfJB4y4z5EvD2jtyyY37B3gQXE=; b=ov2sENCh404DNBI7JyXi4MC0JSb9BpjeWGVt+siggsGxXoH0BeDk/3x1mAzgqHV84K 65QKd4qz1RDzmX0j0UCREY+PnCucEqzi2jfRXcdUbG9GPzcps200C8rpjiWH4C9iLdhI oOntVOHqJvEhBM+9LriW3FHrmGr/Jz9KF5Qjg1BnbAk8tYWO5EyCDLYvoloT3Q5lJDWS /9ezwW+y9lPDmAazrBJt0pj38OJv42hvg1xH+u/TMI5/dcPSLd/0/LlrqJx5LiEzNiTN uUZsRn9q/Pmxd+QvJJeG0lYBkC9l60iTURDSI7C7SiU8ERmp92MIBFxSC2bsyULTAjAo Z+QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=oxMZwcWcALIT/M2QVCfJB4y4z5EvD2jtyyY37B3gQXE=; b=pe+HcgnjrBEKYa27Y64J9EegfQeIXNIsTaAPZ50/qowBv2QBlM4ipR3FL0PbZvDnN3 vxF40UQP9hix7LmkweK7mZNGbaykyT3fHk7gd3Pu50yJBmesWQ+TjphfRhVR7Vvqblrd CFjiUwakNr8wfw5VQFbn+lU2WWl261SPPXrdrG6jNcn7On3g0/qepN011xMoTb+jofdE fR8oATyMIjmdU8icDRj4r3Nt6K/JAflu6dMreGamBxxcNZVYuM54YMT28czBfThGIhfw 2EZfM2egd0/LPUmB8TZSuIXlZGTBsS5Wx5kbf9iPL1ocmNiNgyZUKjnui/7k9uQLllok +FSQ== X-Gm-Message-State: ACrzQf0KW8QMluQMu4bhIA16n6bWoE9CdhRFXCfZHstiybY1pCaNvJTl 3jUMNbMIzG5clYFz4xPfRH+YZTheFJ4= X-Google-Smtp-Source: AMsMyM4c1oyBUYbS3UsjxD0TqPDuLtlKF7mqdCLQNsJxkUQjaPGbuzlQutiRVqXcrlAedGHV0mX3Tg== X-Received: by 2002:a05:6a00:1342:b0:545:4d30:eecb with SMTP id k2-20020a056a00134200b005454d30eecbmr30157203pfu.69.1664943651525; Tue, 04 Oct 2022 21:20:51 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:63b5:ea40:cab:894b]) by smtp.gmail.com with ESMTPSA id n124-20020a622782000000b0053653c6b9f9sm10088609pfn.204.2022.10.04.21.20.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 21:20:50 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id F05F6114312C; Wed, 5 Oct 2022 14:50:47 +1030 (ACDT) Date: Wed, 5 Oct 2022 14:50:47 +1030 From: Alan Modra To: Mark Harmstone Cc: binutils@sourceware.org Subject: Re: [PATCH 1/2] ld: Add --pdb option Message-ID: References: <20221003014313.28766-1-mark@harmstone.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221003014313.28766-1-mark@harmstone.com> X-Spam-Status: No, score=-3029.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Oct 03, 2022 at 02:43:12AM +0100, Mark Harmstone wrote: > @@ -955,6 +960,13 @@ gld${EMULATION_NAME}_handle_option (int optc) > if (strcmp (optarg, "none")) > emit_build_id = xstrdup (optarg); > break; > + case OPTION_PDB: > + if (emit_build_id == NULL) > + emit_build_id = xstrdup (DEFAULT_BUILD_ID_STYLE); > + pdb = 1; > + if (optarg) > + pdb_name = xstrdup (optarg); > + break; This will result in "--emit-build-id=none --pdb" enabling build-id while "--pdb --emit-build-id=none" will disable build-id. Is that what you want? If the intent is to always force build-id on then you should do so in after_parse instead. Otherwise both patches look OK to me. -- Alan Modra Australia Development Lab, IBM