From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id B86F03858294 for ; Wed, 5 Oct 2022 04:23:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B86F03858294 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42a.google.com with SMTP id w191so5431104pfc.5 for ; Tue, 04 Oct 2022 21:23:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date; bh=1UPybI7aqXzIhXv9nLnlhQIWdgJn9AW2nyvKyRNhEms=; b=MDCxwd1jfIvNNc613mPAcW2ylLDYqYbYYGAoHfka54YIXbO2zXs03FvaaFW8WXPbqk U3KNP72QVsvSaHlIf9qX3QcgUSnBErsWi8ttj2w9+Oesm1btpUOFtnWmw5+q/52KTRd0 TVlwwy5uInWC32nETgGD2pc6kjhv1wlKt9GG/B2mHxAVTju6dizWqA7ChUcqcqFuzYpw r6M0zoSU7Tsb6CFLExQOjzHr9N2oG1sP8ckoOilYGI2Ar8I69AgWyh0uVP+NNmtncgAq rxmJmYbpLBueYaoQbzKWR3np9wmumVr+rsh2NaRaJ7LJlGJbYwqSFzvDmbUi75r5UxY6 Bzrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date; bh=1UPybI7aqXzIhXv9nLnlhQIWdgJn9AW2nyvKyRNhEms=; b=3TYRQu58Q90+cdLQiDhkXOeCnjrd772Aki5rnLcto2Vtl23ZmtjGaqVhJPju+/NbQR GAiVEjs2Rys9ehCMU41k8n30PbPQxGhRH7+hHWNq7CkvVcr1bnKgPUO8t9bJA3WUQinL ti8Ri+y0jCdCjmGy9sb8nZOOhIj7t+p0cYrBGbhvA7K0F3mOgDbz8hSUjRDQ/lAdjjg2 NTO5hxd/ZuAB1Qyfjw08Re3yFHVRTBSEfDlXhZ/KgBgITCad8tLolARV2MgUjE0qvb5u h2v5VYBBejOiQVTIZRi5BVRSoFGUF67j12+DlU0t66ysn+lJCMDcnXb2787ijHF0Q5bF 1sRw== X-Gm-Message-State: ACrzQf1Qg0Bf8zvD2C94iSxdT+ad54YClED+qsfCN59qnZ0+7xYUzOCn FojdybAgLuAT6f0ORMYBEWPpH7oWejQ= X-Google-Smtp-Source: AMsMyM6DsrKbVgbzAaj2nXMPcljWvtKAXYDxLUxL8HX0GojSN7y+zVVg1TUL6caH1YP6WovT00TQqA== X-Received: by 2002:a63:194b:0:b0:457:7295:8de0 with SMTP id 11-20020a63194b000000b0045772958de0mr3181139pgz.612.1664943798113; Tue, 04 Oct 2022 21:23:18 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id e126-20020a621e84000000b005360da6b26bsm10063901pfe.159.2022.10.04.21.23.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 21:23:17 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 3049F114311D; Wed, 5 Oct 2022 14:53:15 +1030 (ACDT) Date: Wed, 5 Oct 2022 14:53:15 +1030 From: Alan Modra To: binutils@sourceware.org Subject: PR29647, objdump -S looping Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3036.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Fuzzed input with this in .debug_line [0x0000003b] Special opcode 115: advance Address by 8 to 0x401180 and Line by -2 to -1 PR 29647 * objdump.c (print_line): Don't decrement line number here.. (dump_lines): ..do so here instead, ensuring loop terminates. diff --git a/binutils/objdump.c b/binutils/objdump.c index 6610906f83e..f7b4695c3e8 100644 --- a/binutils/objdump.c +++ b/binutils/objdump.c @@ -2069,7 +2069,6 @@ print_line (struct print_file_list *p, unsigned int linenum) const char *l; size_t len; - --linenum; if (linenum >= p->maxline) return; l = p->linemap [linenum]; @@ -2088,7 +2087,9 @@ dump_lines (struct print_file_list *p, unsigned int start, unsigned int end) { if (p->map == NULL) return; - while (start <= end) + if (start != 0) + --start; + while (start < end) { print_line (p, start); start++; -- Alan Modra Australia Development Lab, IBM