From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: asan: _bfd_stab_section_find_nearest_line segv
Date: Wed, 28 Sep 2022 10:27:49 +0930 [thread overview]
Message-ID: <YzOcDThCaaEk1qIs@squeak.grove.modra.org> (raw)
The segv was on "info->strs[strsize - 1] = 0;" with strsize zero. OK,
if strsize is zero we don't have any filenames in stabs so no useful
info.
* syms.c (_bfd_stab_section_find_nearest_line): Exit if either
stabsize or strsize is zero.
diff --git a/bfd/syms.c b/bfd/syms.c
index ec62f3457ca..e8077f59bf0 100644
--- a/bfd/syms.c
+++ b/bfd/syms.c
@@ -1027,6 +1027,9 @@ _bfd_stab_section_find_nearest_line (bfd *abfd,
? info->strsec->rawsize
: info->strsec->size);
+ if (stabsize == 0 || strsize == 0)
+ goto out;
+
if (!bfd_malloc_and_get_section (abfd, info->stabsec, &info->stabs))
goto out;
if (!bfd_malloc_and_get_section (abfd, info->strsec, &info->strs))
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2022-09-28 0:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzOcDThCaaEk1qIs@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).