From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id F11023850430 for ; Tue, 14 Mar 2023 02:06:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F11023850430 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x633.google.com with SMTP id v21so4929518ple.9 for ; Mon, 13 Mar 2023 19:06:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678759617; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=JYXa7CGIxlOsHVGT8MRiaFju1UXVihCbWd64vFPhfkA=; b=hgqU3NQYsjw83X+GuSS0SvVfPqSxYLGn0sCKhxd0LNKdA0ASr7KyaJVb+1WnzqnsL1 WY3pM7XxOwvaIR3ZXPyx37LvmrqJIyhnb6PHWGcvooRXw8GCclVpfMkerjci4ZK8GiK7 BiOgtlxicALPBYWNEGlx2kinxJXZbUaBvo+YW1XuqovzChPAoKWbMozF+C7C6JQtOvno pv3S9+w8xlEgtbSsfunGft+5UTOwBrh0d3tv8+CiC8GBWm0OtFKOOLHtma4RQPQIJZSN B+dkl07tXg/QT+gznWba2d8kl20f5zU42sxZYKujyAvo60X8MxlFEUWVBN9hnalasNqD zHeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678759617; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JYXa7CGIxlOsHVGT8MRiaFju1UXVihCbWd64vFPhfkA=; b=kSbGzBONqWbbYBDadrkcm7f7+DnIppGKa3L1unc2tBseWXNt4HtWaCyTHSu0i3eRIL l8VkwAH+Jm8SEALy+grVeoeg8EUpccCeM2vwwa2ShOsgH2SvDVWzCrFjsQQ8qzRce4YH HZVIBi4LYXt4pIEZvXFwyRm5/3SqBhGDP2L8FjmhFG6U1DP0yTMi7lG/pUaSb7xoRXLn LTOLwSMJ20IM68UAncHsImr+4L5CS07sDnwhSLVVGCsA3LDfA16AATFlqyX6Ao+hl8D7 D3G8/O66KfhOOsvJcWPbuiFFUn+piMKelMqjNUgkGbYh1ky4Fd29jb+6q98NAGHhSJ3L hvpg== X-Gm-Message-State: AO0yUKVZoHBifdp+e6zV+Smbei9xAz4jskxowR5M5fNDl2q/Onl/TSM4 6l6Yd4ljggnCAXmCBDzTjD735lYS09c= X-Google-Smtp-Source: AK7set9eB7z7ZA7oJingyhi11LRyQ8m3nVVrJaPqDM2FYnyvEanQsE558ti9phCeqwr/J5xldznIgw== X-Received: by 2002:a17:902:e851:b0:19a:839f:435 with SMTP id t17-20020a170902e85100b0019a839f0435mr14047607plg.3.1678759586829; Mon, 13 Mar 2023 19:06:26 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id u7-20020a17090341c700b0019460ac7c6asm451040ple.283.2023.03.13.19.06.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 19:06:26 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 81F7E1142C71; Tue, 14 Mar 2023 12:36:24 +1030 (ACDT) Date: Tue, 14 Mar 2023 12:36:24 +1030 From: Alan Modra To: binutils@sourceware.org Subject: objdump segfault after symbol table error Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3035.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This memcpy segfaults if symcount is -1 (=> syms is NULL). memcpy (sorted_syms, symcount ? syms : dynsyms, sorted_symcount * sizeof (asymbol *)); * objdump.c (slurp_symtab): Don't leave symcount as -1 after an error. (slurp_dynamic_symtab): Likewise for dynsymcount. diff --git a/binutils/objdump.c b/binutils/objdump.c index 0e8e1980b80..5dac13ba868 100644 --- a/binutils/objdump.c +++ b/binutils/objdump.c @@ -1015,6 +1015,7 @@ slurp_symtab (bfd *abfd) my_bfd_nonfatal (bfd_get_filename (abfd)); free (sy); sy = NULL; + symcount = 0; } return sy; } @@ -1048,6 +1049,7 @@ slurp_dynamic_symtab (bfd *abfd) my_bfd_nonfatal (bfd_get_filename (abfd)); free (sy); sy = NULL; + dynsymcount = 0; } return sy; } -- Alan Modra Australia Development Lab, IBM