From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: Re: Sanity check read_section_stabs_debugging_info
Date: Thu, 16 Mar 2023 11:25:53 +1030 [thread overview]
Message-ID: <ZBJpGdU0OfWCD9/5@squeak.grove.modra.org> (raw)
* rddbg.c (read_section_stabs_debugging_info): Don't segfault on
zero size string section.
diff --git a/binutils/rddbg.c b/binutils/rddbg.c
index f2ed6bcb3dd..1a888778312 100644
--- a/binutils/rddbg.c
+++ b/binutils/rddbg.c
@@ -147,7 +147,8 @@ read_section_stabs_debugging_info (bfd *abfd, asymbol **syms, long symcount,
}
/* Zero terminate the strings table, just in case. */
strsize = bfd_section_size (strsec);
- strings [strsize - 1] = 0;
+ if (strsize != 0)
+ strings [strsize - 1] = 0;
if (shandle == NULL)
{
shandle = start_stab (dhandle, abfd, true, syms, symcount);
--
Alan Modra
Australia Development Lab, IBM
next reply other threads:[~2023-03-16 0:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 0:55 Alan Modra [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-14 2:05 Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBJpGdU0OfWCD9/5@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).