From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id 7A52A3858D39 for ; Mon, 27 Mar 2023 11:25:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7A52A3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1029.google.com with SMTP id qe8-20020a17090b4f8800b0023f07253a2cso8419514pjb.3 for ; Mon, 27 Mar 2023 04:25:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679916343; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=i28zAColzz8rOf+PSuFSQ0AU2GKIBS3w4y4LZm/aCkU=; b=SK3+ygQ57HwfPHxwUYeHDJvnQwAZGyt9JAa15jjDqOYmv4i1EuOrpZLX4RlbZpCIAT ylW3gRwv5NEiv6ZJlPuN8QMFYEJnS1NzsUr8UngpK/p396ekTQvVoNBvlcCSJ813Q8D9 WjGPx6EPci3X8CuQTnqkrrZHpUnJwSzLPRxsKi5RL9NhvGnojNHCgMg6rL143145tits C8+U+ysHgOvn7xUUYByjRmjH+7PyUg6WTYphBvSw+IfYggWChFKRFZuq1PnsYx57ckid r4DTOFKmjEBULCvFGqsdIzRqR+3OisNCENafJ8yPMuyNGWq4TOdYhko3juCceU5eSC3J ptLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679916343; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i28zAColzz8rOf+PSuFSQ0AU2GKIBS3w4y4LZm/aCkU=; b=A8rWfsKj2gdYOtleFgkp6ADqXP/lm6ycOaieBAhC4N2A2oub/IytXioX6d4IaMjyIC WNU7myHIDXEo5lMD9H6VTXReKzWNz5nStHJNg4/jo+2flWnYk5I7lrd9MokgRv0B4CaA ixnpKYFMBJHOSW078UBnsusP59G5LQZUILyeL95bu9JzEC9WiZh5vlAhx8IUKJRc80+O r9EdP5s2qBHOSY/nMLeCyyq5WDFy2kufISu/BX1PWIngfaqUS/p7ij4zlFgT8F5BSfeq 5k+O8fsa4pUhnIuEZ5FttjfdOP1DMJmBJ/JhOMiATs4nr2YJsZPrPSVGMbbWkrdtwW6I zRkw== X-Gm-Message-State: AO0yUKW391j/NBXFn23AHmf0h8TubeOGybzthqC9z/L+2XkH7NTkK6ZB jO3C5V8dyAYBmRa7dO7X259HJ+UcVn8= X-Google-Smtp-Source: AK7set9Ve9VAMQCfciS6jTkiO4MrT8X02qOP1bN/T7X2T48+sa4Q5emYZXSgqsTLkjq+wEjIV6XVUA== X-Received: by 2002:a05:6a20:4999:b0:da:6602:790 with SMTP id fs25-20020a056a20499900b000da66020790mr9902174pzb.52.1679916343372; Mon, 27 Mar 2023 04:25:43 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:1b0:13cb:4f4d:735]) by smtp.gmail.com with ESMTPSA id q17-20020a62ae11000000b0062607d604b2sm18868000pff.53.2023.03.27.04.25.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 04:25:43 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id EA5C9114276F; Mon, 27 Mar 2023 21:55:40 +1030 (ACDT) Date: Mon, 27 Mar 2023 21:55:40 +1030 From: Alan Modra To: binutils@sourceware.org Subject: Duplicate DW_AT_call_file leak Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3034.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >From 10626d8e35a00e26dec4abb276052ed197545cc6 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Sun, 26 Mar 2023 18:49:13 +1030 Subject: When given two or more DW_AT_call_file for a given function we currently leak the concat memory. * dwarf2.c (scan_unit_for_symbols): Don't leak on duplicate DW_AT_call_file. diff --git a/bfd/dwarf2.c b/bfd/dwarf2.c index 15862dc2037..d99508a96c7 100644 --- a/bfd/dwarf2.c +++ b/bfd/dwarf2.c @@ -4083,8 +4083,11 @@ scan_unit_for_symbols (struct comp_unit *unit) { case DW_AT_call_file: if (is_int_form (&attr)) - func->caller_file = concat_filename (unit->line_table, - attr.u.val); + { + free (func->caller_file); + func->caller_file = concat_filename (unit->line_table, + attr.u.val); + } break; case DW_AT_call_line: -- Alan Modra Australia Development Lab, IBM