From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id D749A388202C for ; Tue, 28 Mar 2023 23:35:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D749A388202C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62f.google.com with SMTP id iw3so13250481plb.6 for ; Tue, 28 Mar 2023 16:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680046553; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=0dKBxf1G1OgeODh8jYJQs1UXNJzdd/dL7UwO83nN9mg=; b=NZDM2vhhFGTUjVtnVjUxrMeB9XDgP9rCk3gEXiq9pWkPx2FfOwex2/nIMR4WVpwvCg wuX7mLUV5I5yQYxetOIhSKp5BXgFylx9hU13cM09vCsmQv80ULywyqcUvd56nsJeDSWM KjusX0AOMhO0CPeWpkrHaIPuf+TJBDXAw1ab0DZYKsK7yrCpCvLdCCo448jeg4JKQGXM m0vwyx0k5Tc/hrd5ydR+OqxnbAlp8c11OgkIkOIUVct+oLQrNwFs7tlvEBHLtLWiDIoo gTYOGzIP3ntXruc6oieOsV2Z+tAVFkEE84kET5CfjzHpfVbrX0rHZCMCjIU8S41VBACP G2tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680046553; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0dKBxf1G1OgeODh8jYJQs1UXNJzdd/dL7UwO83nN9mg=; b=fDbpbACBjfmspNLSVTRvD0ukEYWiUjzqqRR2Kp8O/5oteQtBInjrtB2CZgL7OGpoRf VthmjDrTxakRouU3N0xCN4RHXMB7ISq5Lssv1Id5fSXSr4xZH29wSUVIlwydr7af1dVl ND/7+tH4k3Rz/z4q51rkg7RnzFJj/chJJP8luJQX+xtA/+a1iUd2UVY6GSD8FiR7e0FS lmNESWZg9XBJUtJ4EYpv+H1l3VRvpAPXJr3UIgY6xNDDKCK9csNk/gOo2Wnf1jLmH1el rMT/gAA4cBvDAL5c/aIKjceS8fGWD3bRYDdl0xacBdCATZh9scTJVqIS7pgl61gTIoRQ E3Eg== X-Gm-Message-State: AAQBX9c++78WVSMG41z1cL4tO7ncLwZMAmpr9qdtV75ya67Nu3JHvKaj K9Iy+foJiDaY1NHkgx0Q0gZQCsHxaBo= X-Google-Smtp-Source: AKy350Zi2oV7vBP+HqPEfWMFUFyVO/afR0KmfD8twGoEejoy3tsjfw50LCBXbe2rw3hl3wyzbUfBcw== X-Received: by 2002:a17:902:e54d:b0:1a1:a90f:6766 with SMTP id n13-20020a170902e54d00b001a1a90f6766mr21193545plf.52.1680046552773; Tue, 28 Mar 2023 16:35:52 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id c20-20020a170902b69400b001a1faed8707sm11197736pls.63.2023.03.28.16.35.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Mar 2023 16:35:52 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 3A32C1142D99; Wed, 29 Mar 2023 09:50:48 +1030 (ACDT) Date: Wed, 29 Mar 2023 09:50:48 +1030 From: Alan Modra To: binutils@sourceware.org Subject: Re: Fix an aout memory leak Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3035.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: We have way too much duplicated code in bfd. Apply dd3a3d0af9f6 and 920581c57e08 to pdp11.c. * pdp11.c (bfd_free_cached_info): Free line_buf. Return true if tdata.aout_data is NULL. diff --git a/bfd/pdp11.c b/bfd/pdp11.c index 862cf49fda3..9edbba92c82 100644 --- a/bfd/pdp11.c +++ b/bfd/pdp11.c @@ -2539,12 +2539,13 @@ NAME (aout, bfd_free_cached_info) (bfd *abfd) { asection *o; - if (bfd_get_format (abfd) != bfd_object) + if (bfd_get_format (abfd) != bfd_object + || abfd->tdata.aout_data == NULL) return true; #define BFCI_FREE(x) do { free (x); x = NULL; } while (0) + BFCI_FREE (adata (abfd).line_buf); BFCI_FREE (obj_aout_symbols (abfd)); - #ifdef USE_MMAP obj_aout_external_syms (abfd) = 0; bfd_free_window (&obj_aout_sym_window (abfd)); -- Alan Modra Australia Development Lab, IBM