From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 70FCD3858CDA for ; Thu, 30 Mar 2023 04:49:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 70FCD3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62a.google.com with SMTP id le6so16970567plb.12 for ; Wed, 29 Mar 2023 21:49:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680151740; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=V+zNhXg+npy3CtsEHfjnV0SFZr90Y/sIrpVSLH664WA=; b=C4qTdM50qiz+yfgHd4Zgwr/orJyirp/9Bff3fqGiq4c1QRgqDIp9zdv07gXVn2Ginj SFuH3LpUckO0+w6rE8CItd0Pi7Nn30HyhoG2pV8jPWw0Ut07ANHq/fFTwbPyU7X931aH cw+974y5GRkNk4cG5rzu5UqwqniuXtgNXtXUWZFUDCWA9fPsq2uPbZoNl/IX+88DgEMX ozP/qS2FgP8kb5eAYJu4Wuj6nL5JIFQvW5ht0ycye79oW8m1MN+cMBz9JDKIoaoYBdqL eqaVcsGRaNhGnkC58mIMIeYiItF4YAsRGw4XjofZ+AhzZ3xImjQEvKgWWODXueXLOjdH Q7LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680151740; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V+zNhXg+npy3CtsEHfjnV0SFZr90Y/sIrpVSLH664WA=; b=veAb5S6H97hE8hg0dQ7CFrwuozWTbR+vogI2z92PVJRAe0bHrLLx/Z22wgeEELDpBg fi1FtKDBYtfUq6JobM3cay1Xgt2j8JbX4gSDmN/SYcS7eO1bOmUr19fo6cRNcro1wG1R KAE2JHPJr016VAVyX71FqVDzVJdroknTEiqMpt8YDWVovrawvo+/M8V3s6wmCeyLWdgb xtyGwPQMb5ja8C61dpYZClH1rqUGEPF2/UHiSlJ6iOmewi2IXnnCoReHrAGIWLcy9IgT BvRwL0isxB+TjBnnvP5OqXV3zdXsOe0/r0zZG0D4Xc8agyARQTrA+lDV658/NM+f2Rxo JmDg== X-Gm-Message-State: AAQBX9fJPfgYkc++432bOsJW3KC8MZK8prYn1yB/akhuuSZjQ/7L27A6 rI4MFfWqYWmZC9hyNDYQxdUbDrAXPhA= X-Google-Smtp-Source: AKy350YuoH9l8+bOQdNnY9JzwoWTXQMVIJuSfgineUq6xLP4JzSHofT2T7YdIBXuDgDi9EgbjCZ4Rg== X-Received: by 2002:a17:902:db0d:b0:1a1:e410:a1ff with SMTP id m13-20020a170902db0d00b001a1e410a1ffmr26889860plx.24.1680151740009; Wed, 29 Mar 2023 21:49:00 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id iz4-20020a170902ef8400b0019f9fd5c24asm23753988plb.207.2023.03.29.21.48.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Mar 2023 21:48:59 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 0A2CA1141C31; Thu, 30 Mar 2023 15:18:57 +1030 (ACDT) Date: Thu, 30 Mar 2023 15:18:57 +1030 From: Alan Modra To: binutils@sourceware.org Subject: Tidy memory on addr2line failures Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3035.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * addr2line.c (process_file): Close bfd on error paths. diff --git a/binutils/addr2line.c b/binutils/addr2line.c index afe116a235c..b07302ddc99 100644 --- a/binutils/addr2line.c +++ b/binutils/addr2line.c @@ -451,6 +451,7 @@ process_file (const char *file_name, const char *section_name, if (bfd_check_format (abfd, bfd_archive)) { non_fatal (_("%s: cannot get addresses from archive"), file_name); + bfd_close (abfd); return 1; } @@ -459,6 +460,7 @@ process_file (const char *file_name, const char *section_name, bfd_nonfatal (bfd_get_filename (abfd)); if (bfd_get_error () == bfd_error_file_ambiguously_recognized) list_matching_formats (matching); + bfd_close (abfd); return 1; } @@ -468,6 +470,7 @@ process_file (const char *file_name, const char *section_name, if (section == NULL) { non_fatal (_("%s: cannot find section %s"), file_name, section_name); + bfd_close (abfd); return 1; } } -- Alan Modra Australia Development Lab, IBM