From: Alan Modra <amodra@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Binutils <binutils@sourceware.org>, Nick Clifton <nickc@redhat.com>
Subject: Re: [PATCH] bfd+ld: when / whether to generate .c files
Date: Sat, 1 Apr 2023 17:55:40 +1030 [thread overview]
Message-ID: <ZCfcdIzVWbMsyIdy@squeak.grove.modra.org> (raw)
In-Reply-To: <efb685d2-b2cb-9baf-0352-d0aa7961c300@suse.com>
On Fri, Mar 31, 2023 at 04:19:21PM +0200, Jan Beulich wrote:
> Having been irritated by seeing bfd/elf{32,64}-aarch64.c to be re-
> generated in x86-only builds, I came across 769a27ade588 ("Re: bfd
> BLD-POTFILES.in dependencies"). I think this went slightly too far, as
Fair enough.
> outside of maintainer mode dependencies will cause the subset of files
> to be (re-)generated which are actually needed for the build.
> Generating them all is only needed when wanting to update certain files
> under bfd/po/, i.e. in maintainer mode.
>
> In the course of looking around in an attempt to try to understand how
> things are meant to work, I further noticed that ld has got things
> slightly wrong too: BLD-POTFILES.in depending on $(BLD_POTFILES) isn't
> quite right (the output doesn't change when any of the enumerated files
> changes; it's the mere presence which matters); like in bfd it looks
> like we would better extend BUILT_SOURCES accordingly.
Yes, that looks good.
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2023-04-01 7:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 14:19 Jan Beulich
2023-04-01 7:25 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCfcdIzVWbMsyIdy@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).