From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id 7CA3A385842C for ; Mon, 24 Apr 2023 10:33:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7CA3A385842C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-63d2ba63dddso3483151b3a.2 for ; Mon, 24 Apr 2023 03:33:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682332424; x=1684924424; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Rm2cneaa+jfMOXSQABWfPC+m6ih27hgl4a2JNWYCUTc=; b=gk97ia/PUnUkszslKGpWSaCF1AS1fgdZkm+welm2IEIRlQvwiA/wRtHZc6yUG5YAYM 9yYxuKHGvKIxTm/6pWac4GaehrIZM45ku0sGiyd3J+hcXF0za2UsDGjx4lFHpXcWESNG XqfpZZ196Y1ZGlGj5YOS42jqaOV6RVYyH0AileXrm04NW2wGZ7e03RMcwdYZzNBUI/Zu AeYiElMuGpYRrXQjw5EYatRSVEe9oRpTeEETlEgA1CZTNE420B8UAVdRBXMcuBzwLJxP x4FvNBSl26XUOAkNmH6WxIjscmyJ84BpaUnQvPgRq9s/LeypeMMxRL1+e6vZYrj3g0cv YIyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682332424; x=1684924424; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Rm2cneaa+jfMOXSQABWfPC+m6ih27hgl4a2JNWYCUTc=; b=Z/EX5ANOHcz8DtwgY/DAOWb1rYDfJgfBhAr/QLyGmAkj9rGNKAW4lJ5SsuTx7uI5dD wohogVkTL5vPYEo9wryFZgxyp4ijrnlls/3r1cyK43cvNMVuseU2ii2cQpBT/vQss8No CJTJGFPJeO2+YooSBJmrgGdEJVXHVV56ZHgAVx4Do1RTCZiODAcAvbHrwG3fDWrIdJho S48ju3nesy0PoYbB7QbehkkKSC5IyLMJyrsVOc5vIldlnKTCJWeWrcYYrtMm4SKDgrsb uadK30Q/nwvUTglDhppWCZcso/dRtXHnqMa5hOeM4gT9zEuoPjYa9LhyVr1YERE/fV25 Th3g== X-Gm-Message-State: AAQBX9cBvDEQpNiZrzWBlSojubnifjNv2868ZgvXh/AYcEjwSv7/8srI v6oZ50VOM9cfzjG/Bo4pCAw= X-Google-Smtp-Source: AKy350axF1BQCVA6LD6AMwLCHo0G1PQYAyGlzx9THawookWhKnE1EbvL9heqtd3Uns8ELZ12Kx2RWQ== X-Received: by 2002:a05:6a00:999:b0:62a:4503:53ba with SMTP id u25-20020a056a00099900b0062a450353bamr19046686pfg.26.1682332424397; Mon, 24 Apr 2023 03:33:44 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id b9-20020aa79509000000b00627df889420sm7371094pfp.173.2023.04.24.03.33.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Apr 2023 03:33:43 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 8CEF51140749; Mon, 24 Apr 2023 20:03:41 +0930 (ACST) Date: Mon, 24 Apr 2023 20:03:41 +0930 From: Alan Modra To: Jan Beulich Cc: binutils@sourceware.org, "H.J. Lu" Subject: Re: =?utf-8?B?4pigIEJ1aWxkYm90IChTb3VyY2V3?= =?utf-8?B?YXJlKTo=?= binutils-gdb - failed compile (failure) (master) Message-ID: References: <20230424003151.E975B3858C83@sourceware.org> <50b2bc1b-71f6-25a6-27d3-7d018b98389b@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <50b2bc1b-71f6-25a6-27d3-7d018b98389b@suse.com> X-Spam-Status: No, score=-3029.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Apr 24, 2023 at 08:04:35AM +0200, Jan Beulich via Binutils wrote: > On 24.04.2023 02:31, builder--- via Binutils wrote: > > - 4: make ( failure ) > > Logs: > > - stdio: https://builder.sourceware.org/buildbot/#builders/77/builds/1931/steps/4/logs/stdio > > - warnings (8): https://builder.sourceware.org/buildbot/#builders/77/builds/1931/steps/4/logs/warnings__8_ > > ../../binutils-gdb/opcodes/i386-dis.c: In function ‘print_insn’: > ../../binutils-gdb/opcodes/i386-dis.c:9865:22: error: storing the address of local variable ‘priv’ in ‘*info.private_data’ [-Werror=dangling-pointer=] > 9865 | info->private_data = &priv; > | ~~~~~~~~~~~~~~~~~~~^~~~~~~ > ../../binutils-gdb/opcodes/i386-dis.c:9739:22: note: ‘priv’ declared here > 9739 | struct dis_private priv; > | ^~~~ > ../../binutils-gdb/opcodes/i386-dis.c:9739:22: note: ‘info’ declared here > cc1: all warnings being treated as errors > make[3]: *** [Makefile:1071: i386-dis.lo] Error 1 > > Which, given that this hasn't changed in a while, makes me think that a > new compiler was recently installed, which now diagnoses this supposed gcc-13, I expect. > issue (and, btw, mis-diagnoses where "info" is declared). We can't do > away with the assignment; it's unclear to me whether overwriting the > field with NULL before returning would make a difference. It does. See my other email. > Dynamically > allocating "priv" would be a theoretical option, but I don't view this as > a good one in practice. > > Thoughts, anyone? > > Jan -- Alan Modra Australia Development Lab, IBM