From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id 2A95D385800A for ; Wed, 26 Apr 2023 02:35:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A95D385800A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-63b78b344d5so5230182b3a.1 for ; Tue, 25 Apr 2023 19:35:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682476514; x=1685068514; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=tjFaDeH9+Cj/CKj1NL+cAuWW2qIMVIYA7rfQ6G8GDdo=; b=f5mj6aL4k61Ho+7dYCl20/URDBcFME4LGbOboXZ99z3x/pov19OPljcMMzCmUppwJh JKR9vBLQ9uR7XQCWPSdoaqZVu2NaoeGSbKtftNRoqkdi1QJIbkbMFMILtRK0sDVKkei9 YAoMeAxHrXv4WYq5Eg/i9QzrMKd42xVr+oc8p9odc3gXfrIcWXSX5bnhCeRmMqysafWI ocHet2H8LgWL51NSbinPyrvTE347B7GG6VA/oI/2iqwwMprMyfaHS/yPbdWyuforWaJM lTXBL0dOWjW8PtDH5InvgOH060wX23iSkX4rPwHhcOZqGLVH6UbcxFJl21nBiEFqpxG7 8VMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682476514; x=1685068514; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tjFaDeH9+Cj/CKj1NL+cAuWW2qIMVIYA7rfQ6G8GDdo=; b=UTaKOM7AP9jR8i5R5dyzw4THQsA1lbRVSYUP7vmu+Gzi8/pUoaMWa5+OlQRoLjlGnE X6O/gstygvUZ3C4iQngmxcTDzquCWcEDv84r4V8TbCDI5zGfOfYpV7pHT9HfFfQhOF5W gBG1O+57p7Z+LA1sY2KWwv8wEePdTY2yqm/nFEfnVrFC5sv7ecKTKT9gI7rH8B0ptZuy dheHbRfFTH+bS2KeeXIAY+ecgk3Q/yo//ztTP6FkhtU3wghgc5ihRr7yUb/ALG87gKbZ vritFZ1VqrnC3pPTucinxB5t45RU5si2YTsXxLyfzLsDlb4xenD0tguivBmw1Z3E4us1 GUjQ== X-Gm-Message-State: AAQBX9fbMtB7Ivelrol0XckeG8i9tE9rGUxD3ntD3Up28h/lOVbwB2RQ pBgDFeVrJ6vTUiN+VlcI7vaRquLLZUk= X-Google-Smtp-Source: AKy350bkGtNGvhGM7amIKc4A68kJhGjGTCf5bAlddQX9tK3XyIg+ldjo/pmqrMCCkvEm/gQ4NEODOA== X-Received: by 2002:a05:6a20:1b07:b0:f1:377a:b762 with SMTP id ch7-20020a056a201b0700b000f1377ab762mr18476207pzb.33.1682476513740; Tue, 25 Apr 2023 19:35:13 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id o17-20020a656151000000b0050927cb606asm8527921pgv.13.2023.04.25.19.35.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Apr 2023 19:35:13 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 13EA31142EF9; Wed, 26 Apr 2023 12:05:10 +0930 (ACST) Date: Wed, 26 Apr 2023 12:05:10 +0930 From: Alan Modra To: binutils@sourceware.org Subject: binutils runtest $CC Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3035.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I noticed in the binutile Makefile that runtest is being invoked with CC, CC_FOR_BUILD and other compiler related flags in the environment. That doesn't work. Those variables ought to be passed on the runtest command line. After fixing that I had some fails due to binutils testprog.c now being compiled with the default "-g -O2" picked up in CFLAGS_FOR_TARGET. Hack around that by passing -O0. Also, with the binutils testsuite now taking notice of CC_FOR_TARGET, I found a couple of debuginfod.exp fails with one of my compilers that happened to be built without --debug-id being enabled by default. * Makefile.am (check-DEJAGNU): Pass $CC and other variable on the runtest command line rather than futilely in the environment. Add -O0 to CFLAGS_FOR_TARGET. * Makefile.in: Regenerate. * testsuite/binutils-all/debuginfod.exp: Compile testprog.c with -Wl,--build-id. diff --git a/binutils/Makefile.am b/binutils/Makefile.am index 26de6b2955a..8e51310cf55 100644 --- a/binutils/Makefile.am +++ b/binutils/Makefile.am @@ -210,10 +210,12 @@ check-DEJAGNU: site.exp EXPECT=$(EXPECT); export EXPECT; \ runtest=$(RUNTEST); \ if $(SHELL) -c "$$runtest --version" > /dev/null 2>&1; then \ - CC="$(CC)" CC_FOR_BUILD="$(CC_FOR_BUILD)" \ - CC_FOR_TARGET="$(CC_FOR_TARGET)" CFLAGS_FOR_TARGET="$(CFLAGS)" \ - $$runtest --tool $(DEJATOOL) --srcdir $${srcdir}/testsuite \ - $(RUNTESTFLAGS); \ + $$runtest --tool $(DEJATOOL) --srcdir $${srcdir}/testsuite \ + CC="$(CC)" CFLAGS="$(CFLAGS)" \ + CC_FOR_BUILD="$(CC_FOR_BUILD)" \ + CC_FOR_TARGET="$(CC_FOR_TARGET)" \ + CFLAGS_FOR_TARGET="$(CFLAGS_FOR_TARGET) -O0" \ + $(RUNTESTFLAGS); \ else echo "WARNING: could not find \`runtest'" 1>&2; :;\ fi diff --git a/binutils/Makefile.in b/binutils/Makefile.in index 27315addc0f..a58c8aea259 100644 --- a/binutils/Makefile.in +++ b/binutils/Makefile.in @@ -1832,10 +1832,12 @@ check-DEJAGNU: site.exp EXPECT=$(EXPECT); export EXPECT; \ runtest=$(RUNTEST); \ if $(SHELL) -c "$$runtest --version" > /dev/null 2>&1; then \ - CC="$(CC)" CC_FOR_BUILD="$(CC_FOR_BUILD)" \ - CC_FOR_TARGET="$(CC_FOR_TARGET)" CFLAGS_FOR_TARGET="$(CFLAGS)" \ - $$runtest --tool $(DEJATOOL) --srcdir $${srcdir}/testsuite \ - $(RUNTESTFLAGS); \ + $$runtest --tool $(DEJATOOL) --srcdir $${srcdir}/testsuite \ + CC="$(CC)" CFLAGS="$(CFLAGS)" \ + CC_FOR_BUILD="$(CC_FOR_BUILD)" \ + CC_FOR_TARGET="$(CC_FOR_TARGET)" \ + CFLAGS_FOR_TARGET="$(CFLAGS_FOR_TARGET) -O0" \ + $(RUNTESTFLAGS); \ else echo "WARNING: could not find \`runtest'" 1>&2; :;\ fi diff --git a/binutils/testsuite/binutils-all/debuginfod.exp b/binutils/testsuite/binutils-all/debuginfod.exp index 7212d16e85f..f86d8deb2fb 100644 --- a/binutils/testsuite/binutils-all/debuginfod.exp +++ b/binutils/testsuite/binutils-all/debuginfod.exp @@ -44,7 +44,7 @@ if { [which $OBJDUMP] == 0} { } # Compile testprog.c, move the debuginfo to a separate file and add .gnu_debuglink. -if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog executable debug] != ""} { +if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog executable "debug additional_flags=-Wl,--build-id"] != ""} { unsupported "$test (compilation failed)" return } -- Alan Modra Australia Development Lab, IBM