From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by sourceware.org (Postfix) with ESMTPS id F36533858D28 for ; Wed, 3 May 2023 06:34:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F36533858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-24df4ecdb87so2408567a91.0 for ; Tue, 02 May 2023 23:34:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683095691; x=1685687691; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=xQaHGyB1czzsstb7WS5Tf3mIYQMIlb/nQyKml4dftMg=; b=mKlIcpJCCi2kCBScWxQIuXGOpcWlYL4D3eqaGcQmhahS9PY8V0ZLMtGYpuad+LleIQ jeNkJFs0KDN5f2joBA+k5Fgn1Noa7gIxxIe9SVYrmpgQVsKgiBapDiPb4tgSVVAtfOi6 YWsTO8feMLgfpajjZZAGNtcHKCFEYUDf608okEmwtltDi7enNDFXIVrqhWuR6qTe+nUg 0oQbapy7sccX5ypHIaGsqaTETI0mPe0CnSxP4ncglo4YJV8CphlQzfzB6A/P0cuZR/Tc qKk+yUgxM2qZTkOHO8MJk9Wki0m858+GPhhYtzrcNQRY9BnW+C37IJechRxASju/tjB3 2/rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683095691; x=1685687691; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xQaHGyB1czzsstb7WS5Tf3mIYQMIlb/nQyKml4dftMg=; b=PH9S28Sf2kXa067TdLhfOUjH6Vk/V47r7juKR8bAVBfLVz3HvlAGxTUUt9EId1xMYg PBd5b6le6ZMVnJ0+ColMZxrjcjeBFZsvST5R/4D20Y5/OboUA8gB6hpg4DoGZ0u1kOcy 6k0Pm94Z5pTrF9oi2pjtf9K9aVLO4JGraF+bnFmbZDvOFOwobXLgODcl3cUOL+a8oSe+ griqo8uP+PeklBqawhEGAcI/xzDeKll4DWIaZ/N13SE/zjGauKFOMD42GLd55IrpNCsY hQHzsJxgSPA+rWsbH+dIAY3eITEoLdBSy03N6FSAgnrL+CrnTSCGbedFK8L1YwMYvzLK mTxQ== X-Gm-Message-State: AC+VfDz54LUQUMFcwRJlQgdelc3oqTofKoReXezLgyeLFR7bJ9uo6xF8 HFx+/tu/FZPeuykIhJVLp+wEtU6+1Cs= X-Google-Smtp-Source: ACHHUZ61nyig57aQstjKpx2V6D/MsT5ICegDeKRfPhsxi9KOgErjuVclKBnQrC82EbTcd3jOrRYbGQ== X-Received: by 2002:a17:90a:d517:b0:24d:f1a5:e279 with SMTP id t23-20020a17090ad51700b0024df1a5e279mr10663250pju.12.1683095691232; Tue, 02 May 2023 23:34:51 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:e289:4864:2d83:727f]) by smtp.gmail.com with ESMTPSA id j8-20020a17090276c800b001a686578b3dsm20726363plt.307.2023.05.02.23.34.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 23:34:50 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 386331142822; Wed, 3 May 2023 16:04:48 +0930 (ACST) Date: Wed, 3 May 2023 16:04:48 +0930 From: Alan Modra To: binutils@sourceware.org Subject: Remove unused args from bfd_make_debug_symbol Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3034.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The ptr and size args are unused. Make the function look the same as bfd_make_empty_symbol. diff --git a/bfd/bfd-in2.h b/bfd/bfd-in2.h index a5a9f1c3be0..7be18db20a8 100644 --- a/bfd/bfd-in2.h +++ b/bfd/bfd-in2.h @@ -1280,8 +1280,8 @@ void bfd_print_symbol_vandf (bfd *abfd, void *file, asymbol *symbol); asymbol *_bfd_generic_make_empty_symbol (bfd *); -#define bfd_make_debug_symbol(abfd,ptr,size) \ - BFD_SEND (abfd, _bfd_make_debug_symbol, (abfd, ptr, size)) +#define bfd_make_debug_symbol(abfd) \ + BFD_SEND (abfd, _bfd_make_debug_symbol, (abfd)) int bfd_decode_symclass (asymbol *symbol); @@ -7655,7 +7655,7 @@ typedef struct bfd_target while using BFD for everything else. Currently used by the assembler when creating COFF files. */ asymbol * - (*_bfd_make_debug_symbol) (bfd *, void *, unsigned long size); + (*_bfd_make_debug_symbol) (bfd *); #define bfd_read_minisymbols(b, d, m, s) \ BFD_SEND (b, _read_minisymbols, (b, d, m, s)) long (*_read_minisymbols) (bfd *, bool, void **, unsigned int *); diff --git a/bfd/coffgen.c b/bfd/coffgen.c index 05f2640abe2..ac936def566 100644 --- a/bfd/coffgen.c +++ b/bfd/coffgen.c @@ -1991,9 +1991,7 @@ coff_make_empty_symbol (bfd *abfd) /* Make a debugging symbol. */ asymbol * -coff_bfd_make_debug_symbol (bfd *abfd, - void * ptr ATTRIBUTE_UNUSED, - unsigned long sz ATTRIBUTE_UNUSED) +coff_bfd_make_debug_symbol (bfd *abfd) { size_t amt = sizeof (coff_symbol_type); coff_symbol_type *new_symbol = (coff_symbol_type *) bfd_alloc (abfd, amt); diff --git a/bfd/libbfd-in.h b/bfd/libbfd-in.h index b3f5190e370..07ef59a24e1 100644 --- a/bfd/libbfd-in.h +++ b/bfd/libbfd-in.h @@ -450,7 +450,7 @@ extern bool _bfd_nosymbols_find_line extern bool _bfd_nosymbols_find_inliner_info (bfd *, const char **, const char **, unsigned int *) ATTRIBUTE_HIDDEN; extern asymbol *_bfd_nosymbols_bfd_make_debug_symbol - (bfd *, void *, unsigned long) ATTRIBUTE_HIDDEN; + (bfd *) ATTRIBUTE_HIDDEN; extern long _bfd_nosymbols_read_minisymbols (bfd *, bool, void **, unsigned int *) ATTRIBUTE_HIDDEN; extern asymbol *_bfd_nosymbols_minisymbol_to_symbol diff --git a/bfd/libbfd.h b/bfd/libbfd.h index f56f2b81305..05508c986ad 100644 --- a/bfd/libbfd.h +++ b/bfd/libbfd.h @@ -456,7 +456,7 @@ extern bool _bfd_nosymbols_find_line extern bool _bfd_nosymbols_find_inliner_info (bfd *, const char **, const char **, unsigned int *) ATTRIBUTE_HIDDEN; extern asymbol *_bfd_nosymbols_bfd_make_debug_symbol - (bfd *, void *, unsigned long) ATTRIBUTE_HIDDEN; + (bfd *) ATTRIBUTE_HIDDEN; extern long _bfd_nosymbols_read_minisymbols (bfd *, bool, void **, unsigned int *) ATTRIBUTE_HIDDEN; extern asymbol *_bfd_nosymbols_minisymbol_to_symbol diff --git a/bfd/libcoff-in.h b/bfd/libcoff-in.h index a0d286d37f4..d0839c76e96 100644 --- a/bfd/libcoff-in.h +++ b/bfd/libcoff-in.h @@ -360,7 +360,7 @@ extern void coff_get_symbol_info extern bool _bfd_coff_is_local_label_name (bfd *, const char *); extern asymbol *coff_bfd_make_debug_symbol - (bfd *, void *, unsigned long); + (bfd *); extern bool coff_find_nearest_line (bfd *, asymbol **, asection *, bfd_vma, const char **, const char **, unsigned int *, unsigned int *); diff --git a/bfd/libcoff.h b/bfd/libcoff.h index 12bd75856c3..235d5c3c843 100644 --- a/bfd/libcoff.h +++ b/bfd/libcoff.h @@ -364,7 +364,7 @@ extern void coff_get_symbol_info extern bool _bfd_coff_is_local_label_name (bfd *, const char *); extern asymbol *coff_bfd_make_debug_symbol - (bfd *, void *, unsigned long); + (bfd *); extern bool coff_find_nearest_line (bfd *, asymbol **, asection *, bfd_vma, const char **, const char **, unsigned int *, unsigned int *); diff --git a/bfd/syms.c b/bfd/syms.c index 57ac52f8faa..6979096fbc6 100644 --- a/bfd/syms.c +++ b/bfd/syms.c @@ -569,11 +569,10 @@ FUNCTION DESCRIPTION Create a new <> structure for the BFD @var{abfd}, - to be used as a debugging symbol. Further details of its use have - yet to be worked out. + to be used as a debugging symbol. -.#define bfd_make_debug_symbol(abfd,ptr,size) \ -. BFD_SEND (abfd, _bfd_make_debug_symbol, (abfd, ptr, size)) +.#define bfd_make_debug_symbol(abfd) \ +. BFD_SEND (abfd, _bfd_make_debug_symbol, (abfd)) . */ @@ -1577,9 +1576,7 @@ _bfd_nosymbols_find_inliner_info } asymbol * -_bfd_nosymbols_bfd_make_debug_symbol (bfd *abfd, - void *ptr ATTRIBUTE_UNUSED, - unsigned long sz ATTRIBUTE_UNUSED) +_bfd_nosymbols_bfd_make_debug_symbol (bfd *abfd) { return (asymbol *) _bfd_ptr_bfd_null_error (abfd); } diff --git a/bfd/targets.c b/bfd/targets.c index 021c808f62d..3dbcd088966 100644 --- a/bfd/targets.c +++ b/bfd/targets.c @@ -420,7 +420,7 @@ BFD_JUMP_TABLE macros. . while using BFD for everything else. Currently used by the assembler . when creating COFF files. *} . asymbol * -. (*_bfd_make_debug_symbol) (bfd *, void *, unsigned long size); +. (*_bfd_make_debug_symbol) (bfd *); .#define bfd_read_minisymbols(b, d, m, s) \ . BFD_SEND (b, _read_minisymbols, (b, d, m, s)) . long (*_read_minisymbols) (bfd *, bool, void **, unsigned int *); diff --git a/gas/config/obj-coff.c b/gas/config/obj-coff.c index 465a990ec88..6216b1f63ee 100644 --- a/gas/config/obj-coff.c +++ b/gas/config/obj-coff.c @@ -238,7 +238,7 @@ fetch_coff_debug_section (void) { const asymbol *s; - s = bfd_make_debug_symbol (stdoutput, NULL, 0); + s = bfd_make_debug_symbol (stdoutput); gas_assert (s != 0); debug_section = s->section; } -- Alan Modra Australia Development Lab, IBM