From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id 55AFB3858D28 for ; Thu, 4 May 2023 04:11:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 55AFB3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-51f597c975fso5420897a12.0 for ; Wed, 03 May 2023 21:11:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683173489; x=1685765489; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=68XGozx9z8+k/jrg0UGpZOyKH7Nye2pNAJUiYoxxU00=; b=eITVwWfzjbwDwZG9qPkeyFTS3nv1aEC99gvcHnJFsP/t03gZIIy8TnFfmh5GAt+LM8 dzu0G/+rei89NAHll+jT1IRdMCllWMcUhau2o543zFZKCNNuwOh1K61xLDF/DASrT4HR dzzVHm4Xdb/k3uL/4ivSY1Wv28uJHI4LEC3N2Hrv1Y0DS0JE4jf7Ql2yiZ2y7E721lqc IgzmJUn3mll77Ws7wYCRCyMhV2VlNSVlqT498RQBF86d1cD36VXLMZYkC1meKE4R06LL J8qTOVLz1zjWjldbs9uh8brcCT/IH0smph8XMEk7vPkMOchHJh7P+8M9arM9spRzEFJg bPHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683173489; x=1685765489; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=68XGozx9z8+k/jrg0UGpZOyKH7Nye2pNAJUiYoxxU00=; b=VFxm0BgItZovPdlRZmGtF2id/zds3b2M+u+Gxe7w/l8piHlfkUP4JXzzJ2tu/3Qgi2 qnXxOui0vGPtxYGJi0KJA2F54I/ZcaQ+xw0vpPqgKyMVt5d1RNQ+v/ULw44Bcpqdqx9L PMS2FgLr43zTa6OZwOks0EMqsUrBrXa2CJl0Gq+kqPyqEIrEbS5W/GblLOFZCJdL0094 JmTC0zmuep53LqIWk4YXgcDj+v4vxY9lcXLTgPzZ8r5NyLNemX1w0SzQLtUCCiw2hHci jE5Vx2QP3xAEnAcmfWaBL7II4umfU8E6Kf0q+h+SXQi5K0Q2UYvYWjI7juz9ysK9gNSb EY/w== X-Gm-Message-State: AC+VfDzLMbSs1qjoWi4Kph/lKCNRUGcX52jmX7l3PCXTzBKM/JUZLf4A AgBA0Ql1FbwqHMeDRpNKGnY3Esdx3F4= X-Google-Smtp-Source: ACHHUZ5wp2McCkk6T7OBHsxJ/o2jtwZ8OXCnxxEf03N348801FtkXH0DEaaQKFjwd8FRvVnQErsIpw== X-Received: by 2002:a17:90a:eb09:b0:24d:ea7f:9ea2 with SMTP id j9-20020a17090aeb0900b0024dea7f9ea2mr909289pjz.15.1683173489327; Wed, 03 May 2023 21:11:29 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:c67f:1cf4:85cc:528d]) by smtp.gmail.com with ESMTPSA id r9-20020a17090a690900b0024e06a71ef5sm2102231pjj.56.2023.05.03.21.11.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 May 2023 21:11:28 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 568E01142CF5; Thu, 4 May 2023 13:41:25 +0930 (ACST) Date: Thu, 4 May 2023 13:41:25 +0930 From: Alan Modra To: Oleg Tolmatcev Cc: binutils@sourceware.org Subject: Re: [PATCH] optimize handle_COMDAT Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3026.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Apr 29, 2023 at 02:39:00PM +0200, Oleg Tolmatcev via Binutils wrote: > Thanks for the review. Here is a new version. The patch you posted to the list is truncated, and the patch you sent me privately was somehow corrupted, with tabs being replaced with 4 spaces and the single space lines in the patch being replaced with an empty line. Please fix your email client and/or editor. I applied it by hand, and found FAIL: Build pe-x86-64-1 FAIL: Build pe-x86-64-2 FAIL: Build pe-x86-64-3 FAIL: Build pe-x86-64-6 when running the testsuite on an x86_64-linux build. This is not acceptable. I also see you have ripped out more than just a little sanity checking and other code you didn't understand. Do you expect Nick or I to fix your patches for you? -- Alan Modra Australia Development Lab, IBM