From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id AA9553858C41 for ; Tue, 16 May 2023 23:23:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA9553858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-6436e075166so55323b3a.0 for ; Tue, 16 May 2023 16:23:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684279428; x=1686871428; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wfZNr9+mHTrbVaIlb7Sr9/+n4gYmk8lbPz8h5chMD2w=; b=bEQ+yXTDmKORqAf73Mo+cfZ1Qti1EICof4fdmDv572aIW3Na0QqzdxOr38FZa1jcTt qtyoxfyQRkKL5OC/5oAJSn+Waqji3cJgIdgpYwB6a4X8ZPSNZN/8LKsoH06QTphtnf7Q byCnXUyOjrbCy4nDxeqEKFF1rkPoWUGfojt7UDbqzgKDumOWNSZ4LdLYh35VCFJMTk1U FA/iZm7e1CaMkJ0REirQ9FnPvuaMfwneGHp5YCaHji8oEeTiWZ/BxFFIUT01D02yt7mi fh7/SwzhArSlxRxXmNXakfCwx9GGH29Qs/+wVXldhVDKe6eWdZa5KaE0M+qAoAmoDO9H 1AeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684279428; x=1686871428; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wfZNr9+mHTrbVaIlb7Sr9/+n4gYmk8lbPz8h5chMD2w=; b=fODfc2QULzcA9RtXvJmwgc02OsQWVrHyvs5sPWiB6jmjS/qrxwvK73vS6kA62FiiyV +sCzKzNYUPM5soKvfKb4T6YJVCEGQbbyjy1SEW255J17Bb2PN4VgHTLblj17vJyTrslH aTcHR+WHqKiG0Ntz5zZv/ihZPvE+A0wZSxHve8ApD+GjQNJkbDMtqaQ7x9tg0t6dCugI ZCyBXQMTSMJLOH49aX4BSFpyichizrmuGpgsipp7zfWvxLJ1+zTcr38aUbkTHwT2fNZF q5L4Ajp/df8nEfjUkCzOA/6J/cbTogVTV+Lc6RZ6WHZl8zCqQJ3B5RqKSp3Nk1pBdI7Z xNgg== X-Gm-Message-State: AC+VfDzOtVhWBfws+sJZqed7Te/GG3aaN1CIDGMm8Q3XwiwzP2d/SNJa 2it2cAXnlk9bqVE1kjmne3E= X-Google-Smtp-Source: ACHHUZ6iOwjubW/3AJdiQzN9xUykSfxmtDD7u3/suCvxD94tXebYhfP0j++HDpTcJBbiNvn+cZ308g== X-Received: by 2002:a05:6a00:1251:b0:64b:50:2410 with SMTP id u17-20020a056a00125100b0064b00502410mr17315747pfi.19.1684279427561; Tue, 16 May 2023 16:23:47 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id c4-20020aa78804000000b006439ad979cbsm12372136pfo.152.2023.05.16.16.23.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 16:23:46 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 2B0A011409AA; Wed, 17 May 2023 08:53:42 +0930 (ACST) Date: Wed, 17 May 2023 08:53:42 +0930 From: Alan Modra To: YunQiang Su Cc: binutils@sourceware.org, syq@debian.org, macro@orcam.me.uk, xry111@xry111.site, richard.sandiford@arm.com, jiaxun.yang@flygoat.com Subject: Re: [PATCH v2 0/5] Some MIPS changes and testsuite fixes Message-ID: References: <20230516025426.2334478-1-yunqiang.su@cipunited.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230516025426.2334478-1-yunqiang.su@cipunited.com> X-Spam-Status: No, score=-3028.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, May 16, 2023 at 10:54:21AM +0800, YunQiang Su wrote: > Run testsuite with targets: > mipsisa32-linux-gnu mipsisa32r2-linux-gnu mips-linux-gnu > mipsisa32el-linux-gnu mipsisa32r2el-linux-gnu mipsel-linux-gnu > mipsisa32r6-linux-gnu mipsisa32r6el-linux-gnu > mips-img-linux-gnu mipsel-img-linux-gnu > mips-img-elf mipsel-img-elf > mips-mti-elf mipsel-mti-elf > mips64-linux-gnu mips64el-linux-gnu > mipsisa64-linux-gnu mipsisa64el-linux-gnu > mipsisa64r2-linux-gnu mipsisa64r2el-linux-gnu > mipsisa64r6-linux-gnu mipsisa64r6el-linux-gnu > mips64el-linux-gnuabi64 mips64-linux-gnuabi64 > mipsisa64-linux-gnuabi64 mipsisa64el-linux-gnuabi64 > mipsisa64r2el-linux-gnuabi64 mipsisa64r2-linux-gnuabi64 > mipsisa64r6el-linux-gnuabi64 mipsisa64r6-linux-gnuabi64 I applied your patchset and ran my usual regression tests over some 165 different binutils targets. mipsisa32r2el-elf, mips-sgi-irix6, and mipstx39-elf show some new failures. This doesn't mean I disapprove the patch, in fact I like it! Please don't think you must post another version of the patchset to fix these problems. It might be better to solve them with an incremental patch, giving the mips maintainers a chance to review this patchset first. Most of the mipsisa32r2el-elf fails are like this: failed with: FAIL: MIPS RM7000 workarounds test 2 (micromips) Similarly, mipstx39-elf fails with Fatal error: selected target format 'elf32-nbigmips' unknown This one (one of the two mips-sgi-irix6 fails I saw) also appear with mipsisa32r2el-elf and mips-sgi-irix6: mips-sgi-irix6 +FAIL: MIPS ELF o32 PIC comdat GOT16/LO16 relocation pairing regexp_diff match failure regexp "^0000000c 0000070a R_MIPS_PC16 00000020 \.L1\^B1$" line "0000000c 00000d0a R_MIPS_PC16 00000020 .L1^B1" regexp_diff match failure regexp "^00000020 0000080a R_MIPS_PC16 00000018 \.L0\^B1$" line "00000020 00000e0a R_MIPS_PC16 00000018 .L0^B1" FAIL: MIPS ELF o32 PIC comdat GOT16/LO16 relocation pairing So that one is caused by different symbol table ordering. -- Alan Modra Australia Development Lab, IBM