From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 757BB3858C52 for ; Sat, 20 May 2023 11:46:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 757BB3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1ae74ab3089so16394905ad.0 for ; Sat, 20 May 2023 04:46:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684583177; x=1687175177; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=m2MLaPPbG66WQmBkCAj6OU+HhoAWqsyAc08Oj241ZNw=; b=Nb3z/glqAVmS9JzP1/6nWopEondjxBV/9k59HhVvLNzCb5XThzr+kFtUBk4aprlH2t h5suyjJ8vzfpMS9j+qdrU7nisf5EbDGS4MK14tjRXtlBecyPHjcFCNUxxuuev6Wkdbwm GMtn8R7z4A0YvJ6JrY/L5h2XKg4hzVonBqI3skabnuAzp/ntrbPpd+utphla7XQR6zwp O1CSp61ZG7ZUnQ7wIpN2K/im3ZUh3a/30gTrPpzGOV/ysmCboDTTz/HqWTB3ooF/F8E0 Z+9SQcf3nJFGwWgOhc7FsOpP98Iua1w3Vh4a7s3jyK3idUT+DBOm1qUrvO/J66a17LVk gajA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684583177; x=1687175177; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m2MLaPPbG66WQmBkCAj6OU+HhoAWqsyAc08Oj241ZNw=; b=LueA+XhzZFpcW8nc3jMfy4J3zF2mccI/G9LTUK5Loiw78p90p0Si2yCy+T3jnE06Qc C8re+gf3sNVeantMJaqKk3xvNuCEDQeAJMtn5TnPgwvBr3DhEO4htulqK6hQaEwj3afl HVSOEJXudQuTUgNen4YSmDf57oOKkUtBUckEafslYWA2qrKc/D9ugmlM26MpW9eFbMVN ov2LldSajY3dSFh38KoKPv7Gq96ez9yITpK9OZd5CExIkun8u3EUcNMeiM6eT6O8H5xN CDAYthNUuBqUAgQvxA7RO1Mc3+3ZUDpyUZaHRNkiHEMvHlHQmqUwfZgDDu/ahqOxwAt7 FJTA== X-Gm-Message-State: AC+VfDwPUNHIEHoPwZFF05plV0IZyiftKqTgl/E2PLgJ4UIojTDm7cI7 VQQt3QA1a/ksCC9Ye7opExXfhySuhhc= X-Google-Smtp-Source: ACHHUZ4xLZYh8Z8FukBcZynIv1CctUnHrk9dn36PeAWAhExKypAVHxslaJcco1nfPUxEDMhwm4z9PA== X-Received: by 2002:a17:903:22c4:b0:1ae:6003:2dd9 with SMTP id y4-20020a17090322c400b001ae60032dd9mr7366926plg.43.1684583176947; Sat, 20 May 2023 04:46:16 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id o18-20020a170902d4d200b001aaf5dcd762sm1298859plg.214.2023.05.20.04.46.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 May 2023 04:46:16 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 1DBE81142BF7; Sat, 20 May 2023 21:16:14 +0930 (ACST) Date: Sat, 20 May 2023 21:16:14 +0930 From: Alan Modra To: binutils@sourceware.org Subject: Re: Bug 23686, two segment faults in nm Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3034.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The fix for pr23686 had a hole in the reloc address sanity check, the calculation could overflow. Note that stabsize is known to be a non-zero multiple of 12 so stabsize - 4 can't underflow. PR 23686 * syms.c (_bfd_stab_section_find_nearest_line): Correct r->address sanity check. diff --git a/bfd/syms.c b/bfd/syms.c index 6979096fbc6..d756995d767 100644 --- a/bfd/syms.c +++ b/bfd/syms.c @@ -1106,7 +1106,7 @@ _bfd_stab_section_find_nearest_line (bfd *abfd, || r->howto->pc_relative || r->howto->bitpos != 0 || r->howto->dst_mask != 0xffffffff - || octets + 4 > stabsize) + || octets > stabsize - 4) { _bfd_error_handler (_("unsupported .stab relocation")); -- Alan Modra Australia Development Lab, IBM