From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id A1F1E3858D20 for ; Mon, 22 May 2023 08:03:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A1F1E3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-64d24136663so2836002b3a.0 for ; Mon, 22 May 2023 01:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684742582; x=1687334582; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=96BcMtOCzbkkxkjjgdjEPA5IEEcWJKm9vRZqvdYigIA=; b=pBWkzv3pSF23xXX3BTnv0BT9R6fNnqTmBnAo53o1/YgdM6T2lnuhLxS4b44P4W1F7Z 5SWltUun1DM+NHd6+HEKLqdLvYQKHWp0NHSn4cgD1QcJ1x5ymd92IUakIoBTeGqJ/XVA C+ObkXM+1USSLAC8McGDqK97zcw2row2Rz4zcDeOOrNSOy6XGcseWdYhk4IAQi70g9iF ynU44B+K4SARQMgo9s2y5iY9TULJRqetRYjGcbtUHhUvqRJ3+1WdzDMMlPS1UachvJcF 5nc2mFGMY5zv10STDhyiwWDDGrkW27ltESBy0eEiPmgWVaZxW1Uqr6//HDyrJ3kGszVV zLVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684742582; x=1687334582; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=96BcMtOCzbkkxkjjgdjEPA5IEEcWJKm9vRZqvdYigIA=; b=eXbigGSMFgfQR7akuhBKszP4/odVj37wYZPgyZZ+tvzk5cn/0V+vtIvUPM5wxlh7ya 5rrIUegRlVNfRcb9mhcUNT1fjsWEJDfFuVKa3SBLPnJJeZoxFseqFlbz1s/GrsL984Qr HWzzvmHePtxtAXZly6bI3iyh3PDD9XAFg1Fuo2I5obifGPiwvnZQ685cjzdmiNAEYAHf yMF5aESW1oD7m5HTe1/TQbV1OsniUugI8makWcA9gphlVMxhedYDH6WdvTeGvt9OB6hq Tm3PEwWFj/l/PE10c1JqERZv72DUyTQSHfHW/16qurfwR6WWtvkGHOnWXoWpZqd6NpUN mPvA== X-Gm-Message-State: AC+VfDwaTycbaE0o8Nh0NRjd2lBKrVEeR+8TldTeqsZmA91Vs3KDwJ9I K98G3CSZTFCgP+2OvAigUCF8ySagmzo= X-Google-Smtp-Source: ACHHUZ58JKznkn5iAlWp+ysQgOPbP4+RecJsTVflqzHYCpTZpSYAH9HMSCq2W5vWZqNvmLTUDCTn1A== X-Received: by 2002:a05:6a00:1816:b0:64c:ef3a:407f with SMTP id y22-20020a056a00181600b0064cef3a407fmr15331660pfa.29.1684742582600; Mon, 22 May 2023 01:03:02 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:35f1:60df:373:6a36]) by smtp.gmail.com with ESMTPSA id e24-20020a62aa18000000b0063b17b58822sm3633743pff.74.2023.05.22.01.03.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 May 2023 01:03:01 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 050751142C20; Mon, 22 May 2023 17:32:58 +0930 (ACST) Date: Mon, 22 May 2023 17:32:58 +0930 From: Alan Modra To: Jan Beulich Cc: Binutils , Fangrui Song , Nick Clifton , Cary Coutant Subject: Re: ELF's DT_ENCODING Message-ID: References: <8c5df1b6-8575-ad1b-668c-a34c8f7b60b8@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c5df1b6-8575-ad1b-668c-a34c8f7b60b8@suse.com> X-Spam-Status: No, score=-3034.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, May 22, 2023 at 08:57:00AM +0200, Jan Beulich wrote: > I think that part of the change wants reverting Yes, I think it was probably bumped without consulting the spec. ;-) ie. it was changed just for readelf. I'm going to commit the following after running my normal regression tests. include/ * elf/common.h (DT_ENCODING): Set back to 32. binutils/ * readelf.c (struct filedata): Don't size dynamic_info array using DT_ENCODING. diff --git a/binutils/readelf.c b/binutils/readelf.c index b872876a8b6..d8ad58b15dc 100644 --- a/binutils/readelf.c +++ b/binutils/readelf.c @@ -304,7 +304,7 @@ typedef struct filedata uint64_t * mipsxlat; uint64_t gnusymidx; char * program_interpreter; - uint64_t dynamic_info[DT_ENCODING]; + uint64_t dynamic_info[DT_RELRENT + 1]; uint64_t dynamic_info_DT_GNU_HASH; uint64_t dynamic_info_DT_MIPS_XHASH; elf_section_list * symtab_shndx_list; diff --git a/include/elf/common.h b/include/elf/common.h index 6f64f05890c..ffa6b60bd2b 100644 --- a/include/elf/common.h +++ b/include/elf/common.h @@ -1135,13 +1135,16 @@ #define DT_FINI_ARRAYSZ 28 #define DT_RUNPATH 29 #define DT_FLAGS 30 + +/* Values in the range [DT_ENCODING, DT_LOOS) use d_un.d_ptr if the + value is even, d_un.d_val if odd. */ +#define DT_ENCODING 32 #define DT_PREINIT_ARRAY 32 #define DT_PREINIT_ARRAYSZ 33 #define DT_SYMTAB_SHNDX 34 #define DT_RELRSZ 35 #define DT_RELR 36 #define DT_RELRENT 37 -#define DT_ENCODING 38 /* Note, the Oct 4, 1999 draft of the ELF ABI changed the values for DT_LOOS and DT_HIOS. Some implementations however, use -- Alan Modra Australia Development Lab, IBM