From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id BA298385828D for ; Wed, 21 Jun 2023 06:20:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BA298385828D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1b52132181aso28497775ad.2 for ; Tue, 20 Jun 2023 23:20:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687328440; x=1689920440; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=A8qYh3J/jch8viHrfLmq9Z1a4SzF/8jE0d+nwYEKjSI=; b=UCFy6cWwTCPqiNcfsdL39tezWLv4RrfTbtmOrv13H91nTS5WKuNjntzHtlYAYV0F9V ziITwN30lC1XIzwuKMmImPF/zAhjKSX8Cfuz8pJI5Pq1/vkTDnpRxOfXBi3HfH5gm0CB A3WFLP59k0FpklLI7B3pTy64uJnrLEeHHRNqY0/DFNqys8bvc4IoUuOTte70Wdvu5+fC svS3VHGoM1C2z4HaCKnUVQX1jnSGhaCrLQ3sfPv929ec38GCNaHb+TI4uwjL9LMLCKYY u5W0MTZGTf1jBEAAxvqI5eS4vLQlvY9oCrOZw3JtJd07eYEbWseQmw5+G+fZPskfsvaQ 38OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687328440; x=1689920440; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A8qYh3J/jch8viHrfLmq9Z1a4SzF/8jE0d+nwYEKjSI=; b=hHDyHUd8Z8Os6C45oTNkDdALu2AQAjH7f7nP3osCLzeAKaksWglU7jaXLav/gmn+r6 MjtmT3CB6RyQTzQfr0XAKE3pkcehHfZH7I8pbGCUTBJHKB2mLMY018z5rWsGZ5hqB0ZF eJmm9w/kyY/3ncogsKR6fJ8pyfe4KSLkMa/DZUh0MQgm+A+rXmW/KloX4qh76j3w7ctf dNCebNfefQ/TPEQ9UzFNVydcjR20m/xe91vf6C6yxT5QkxW7LoZOFjz9yeUtOb944t4m Bgd1Wpfjp82G27JQdnzUVsQb0cixjJ6P7VQGB4XUCRqO1GWnoL1U4XaN8Pc55BY9YxTe 35iw== X-Gm-Message-State: AC+VfDxDFXO1Rcv9QaoD1gP277ztPQ6/xP/bWZEX3CJZsbO8eNZYQKn/ /HKh9HFwCS9BYka5bQDDSIUJS5HGVzI= X-Google-Smtp-Source: ACHHUZ42ZXmny8jhGOuyuh9ZljSKA8W1pDV5Y4lT77+ZjftC+c7wdu0OBn24fDXSUMaOecDh9dFCDw== X-Received: by 2002:a17:90a:35c:b0:25f:982:2d6c with SMTP id 28-20020a17090a035c00b0025f09822d6cmr4892809pjf.24.1687328440140; Tue, 20 Jun 2023 23:20:40 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id l186-20020a6391c3000000b0052c9d1533b6sm2355825pge.56.2023.06.20.23.20.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jun 2023 23:20:39 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 9E9FA11434F8; Wed, 21 Jun 2023 15:50:36 +0930 (ACST) Date: Wed, 21 Jun 2023 15:50:36 +0930 From: Alan Modra To: binutils@sourceware.org Subject: macho-o.c don't leak strtab Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3034.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * mach-o.c (bfd_mach_o_write_symtab_content): Free strtab on success path. diff --git a/bfd/mach-o.c b/bfd/mach-o.c index 55407fa347d..4d414fd95db 100644 --- a/bfd/mach-o.c +++ b/bfd/mach-o.c @@ -2073,6 +2073,8 @@ bfd_mach_o_write_symtab_content (bfd *abfd, bfd_mach_o_symtab_command *sym) if (!_bfd_stringtab_emit (abfd, strtab)) goto err; + _bfd_stringtab_free (strtab); + /* Pad string table. */ padlen = bfd_mach_o_pad4 (abfd, sym->strsize); if (padlen < 0) -- Alan Modra Australia Development Lab, IBM