From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id 8AF7F3858C20 for ; Wed, 12 Jul 2023 01:36:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8AF7F3858C20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-6686ef86110so3585258b3a.2 for ; Tue, 11 Jul 2023 18:36:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689125777; x=1691717777; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xSDKE1GKFtlqMyVKWEr9K3WRaihaKhuVa0kRt+ebpqs=; b=iF6BKyjYWYP6KaupE7sJ4Ms/QoHV7kz4eJtYHhKVPS3E6CENk+pTThiKSrOlh+kQPJ N1OocP4kvLC1F/zVYAU4QM2EEkSvT+GFchD/WrZfJvZvxWrt/JwerQSH9TtRUCMwahkk chbteRQrlXhR4JVawzxpc98a/gSIWNf+1AnLrqR0A6W/uko/tSiOOJUzyd7lGE/f6iZO sXpnsYhoRnDHGcWnp5tND+w6ITCMrPljX5TxJ1+LX8bDoySAWY7JwYtieAg+NZR+cwD9 3PWVLM+k/20tHK2IWWNmjSsi6Qg+xhkeEZT6YwyJjaz8xuQFLTk3sxkWkjD0pkrRRkpY TmXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689125777; x=1691717777; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xSDKE1GKFtlqMyVKWEr9K3WRaihaKhuVa0kRt+ebpqs=; b=Ajonm+glUv52OFb2Ix0ZJ3rQfDA9T2qdKqqI54HANYC4BUpDYTvOo9NFW5j0sh0M6m trkZMQ24MGA96M1Rcq7g7TMGRwSPKHIholAyTLQLsKgclM3habVIseiSW59jzpd5P4Qr L2rXf2GLeuC+qMR9ffeUYlJ+OpY2rksIuEryoLXZQbjIenSVk4zeZcOfXSkGfsF73DD9 3txw0mduPQ6AMkNYf5NmS/XeKNQAj0IkMcozCpPuRBKeBN0NFju5Us6iRCBa8/IPN/ki hnkQPmHY6lyUX3lrlgIbczXOCVrqyk+zi40Q4wW0aJYkEjmzawba+Kaz5mQQNSgzXsJ7 OwMw== X-Gm-Message-State: ABy/qLagopvPj0HTCFGGwp3WCNAraiz5DuqXmZoDJsgQQDYHGiPUF029 Q/VwQOe0JI7yW537+GWNWzQ= X-Google-Smtp-Source: APBJJlGckRo2PGbc0DaXCZMrFsGixyCCYRoIZu8vFfOUvtJA2tagNc1UpvAi2Ke0PyRAVXxckrxgGg== X-Received: by 2002:a05:6a20:6a0f:b0:12e:5fd0:f4af with SMTP id p15-20020a056a206a0f00b0012e5fd0f4afmr16252664pzk.28.1689125777369; Tue, 11 Jul 2023 18:36:17 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id h13-20020a170902680d00b001ac2be26340sm2617509plk.222.2023.07.11.18.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 18:36:16 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 49F7D1142BE9; Wed, 12 Jul 2023 11:06:14 +0930 (ACST) Date: Wed, 12 Jul 2023 11:06:14 +0930 From: Alan Modra To: Andreas Krebbel Cc: binutils@sourceware.org Subject: Re: [PATCH] Align linkerscript symbols according to ABI Message-ID: References: <312682e3-fc76-cac1-6d19-fb54c9ce0cf6@redhat.com> <20230704121832.222400-1-krebbel@linux.ibm.com> <8ccde819-69de-0ff6-c7b7-b349f205cbb0@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3033.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_STOCKGEN,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Align dot before symbols defined outside of output sections. Before _end is already aligned. I'm inclined to think that with this patch the alignment in def_symbol ought to disappear, but for now I'm leaving it in. * scripttempl/elf.sc (def_symbol): Tidy excess space. (_edata): Align before emitting symbol when SYMBOL_ABI_ALIGNMENT. diff --git a/ld/scripttempl/elf.sc b/ld/scripttempl/elf.sc index 9e95e6b4162..bfd8b5ed4b3 100644 --- a/ld/scripttempl/elf.sc +++ b/ld/scripttempl/elf.sc @@ -171,7 +171,7 @@ fi def_symbol() { if [ -z "${SYMBOL_ABI_ALIGNMENT}" ]; then - echo "${USER_LABEL_PREFIX}$1 = . " + echo "${USER_LABEL_PREFIX}$1 = ." else echo "${USER_LABEL_PREFIX}$1 = ALIGN(${SYMBOL_ABI_ALIGNMENT})" fi @@ -688,6 +688,7 @@ cat <