From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 723AF3853D29 for ; Wed, 19 Jul 2023 01:42:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 723AF3853D29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1b8bd586086so51206535ad.2 for ; Tue, 18 Jul 2023 18:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689730933; x=1692322933; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=FaWqSajwpix7DJlgY9wSMY/1bCkOIxnS6PlAr/kQ84I=; b=fejRC5lWhw3+HgC3nU+hkcqxjXAJYnOrthozNFc7dnbI/o8LzGSpXRVF4KPEpkaJCc s8el9QjFgtANLbibX6KvtDpKsY1lL6G+1f+8GEk96V6vTKZfYk1bitTGqFgiyl30jNUD MqN9EXUNoasJiizY8wuV8g6uyiCj4uPOX5xdLRAfWJe57AyYZpx5GmnZzdIrC8ZIobGN nU9jed57dXpVjNq6/9OzBGh/8MnVR6CNTfw/CTO6vvagKlWnwbrpQ5IKEgPXRN8BTcuo waon+hBtUaFFwO4nimpEzj8lqgJnSZtGRyREBdijtcLaBomjyrlvoAtxfA6DPuGEBzN1 WJ0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689730933; x=1692322933; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FaWqSajwpix7DJlgY9wSMY/1bCkOIxnS6PlAr/kQ84I=; b=MDag66JN0Jw2Uso7JkIdz/d7SBR4yEYiZzTgUKmyLO/V73gqjqOZ+3llmue69P+9AP ewMNIftEI/a3+VSb2xdJXkJXCHjvQ1Z++SrVIQQoGNG9a0IirvjTBM9lr1zVLU4rTrMs gBL4VO6amvTpQm0IGIvkpSDJm3q6yTZqM9IUDgZtI9YO0f/1QjPqvED50JJBttfP0/JZ 0oyOp2mTI2nYSwjNPmIs0At3ocgIm5JJQscXg5fqOH1y0euFoccqGcEVy11/P2EBgU56 I8WIUDHFhZ50av3a6HajwWc9HweoXMZGQ/9mfed9yckkcKf7tivCKhMNC3MRyivP7g+F fGLw== X-Gm-Message-State: ABy/qLa8wvw1WmCpY78tvmUs4u8A9mhhRbyIxmV0eOkqxc1aw/bcSdEX yyqwX0PXp2G4BoE4hfC0cln4nVemM1I= X-Google-Smtp-Source: APBJJlHfFYFa9M6HloBG8didI1Hv3E5uZuxb7rX7Bu1ZfKOVBSpJ4eeRkqIe7Y8UYx+vso4oOMxc1g== X-Received: by 2002:a17:90a:77cb:b0:262:b3b8:7c3d with SMTP id e11-20020a17090a77cb00b00262b3b87c3dmr859628pjs.16.1689730933349; Tue, 18 Jul 2023 18:42:13 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id s13-20020a17090a440d00b00263154aab24sm160805pjg.57.2023.07.18.18.42.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 18:42:12 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 9F5F81142A4E; Wed, 19 Jul 2023 11:12:10 +0930 (ACST) Date: Wed, 19 Jul 2023 11:12:10 +0930 From: Alan Modra To: binutils@sourceware.org Subject: [GOLD, PowerPC64] Debug info relocation overflow Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3034.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: It is possible to build huge binaries on powerpc64, where 32-bit addresses in debug info are insufficient to descibe locations in the binary. Help out the user, and only warn about debug overflows. * powerpc.cc (Target_powerpc::Relocate::relocate): Warn on relocation overflows in debug info. diff --git a/gold/powerpc.cc b/gold/powerpc.cc index 96fef7b8dde..d62bdea7ecb 100644 --- a/gold/powerpc.cc +++ b/gold/powerpc.cc @@ -12420,10 +12420,19 @@ Target_powerpc::Relocate::relocate( && gsym->is_undefined() && is_branch_reloc(r_type)))) { - gold_error_at_location(relinfo, relnum, rela.get_r_offset(), - _("relocation overflow")); - if (has_stub_value) - gold_info(_("try relinking with a smaller --stub-group-size")); + if (os->flags() & elfcpp::SHF_ALLOC) + { + gold_error_at_location(relinfo, relnum, rela.get_r_offset(), + _("relocation overflow")); + if (has_stub_value) + gold_info(_("try relinking with a smaller --stub-group-size")); + } + else + { + gold_warning_at_location(relinfo, relnum, rela.get_r_offset(), + _("relocation overflow")); + gold_info(_("debug info may be unreliable, compile with -gdwarf64")); + } } return true; -- Alan Modra Australia Development Lab, IBM