From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id 122FF3855587 for ; Fri, 21 Jul 2023 22:55:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 122FF3855587 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-66869feb7d1so1560335b3a.3 for ; Fri, 21 Jul 2023 15:55:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689980139; x=1690584939; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pd7qGjPYntbUzobwOyHACUlIuI3jVz0BpuaCDQCxBMs=; b=pnud6Id+HZ55yIrDgdDCzD4BEw5S6Pok71bqM9ddES8Vx6i0BKMNq2v1nPhp+cPOsO rEMZ74+2tnAN2Wyz8i1OfuAtUafAT221rpvq8YyAm1LGeYwt+fIg1F3FPzATn2hKgexO 75JEdmbNBEc6W6QMmKZQ0B7SWaHzlyhEDoQu7uxBiRx6kAhHp2knZBKynT1QeU174EuK uqHLwQJCW443SbR5KZg+yZrZy/pZ1x2Fzlszy8np1ANOqXv5HhUFd2xnTMYLDJRkMv3f 8ht39Qopk7eEyZri4kzlJL2p6cVL1DSYNkdjcpjNz/HHu8sddSr8Psbixzj47eH3KpJ6 y2MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689980139; x=1690584939; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pd7qGjPYntbUzobwOyHACUlIuI3jVz0BpuaCDQCxBMs=; b=ET5C8AzmdC6C1vFeJZRkdA07lo64+cHJyRUt4bUMiJGGwdUKRWFYV0w8FPesE1eODT r55rfex0uRkf93pIF0nLgpIp1V+r7fhyaqLeLmKBhQqObM1reOrykw5x9oE+8/EUdkIq G3MofT+q9xBLTGZqZLB8Ua0XQuviixbk9CCnl5JHfwobSZDzigSHwHp611siz+xTjIkL TUp3dNV6EOlMFqIZErfVuLxhg0P2E3K07kJTABT5z+ZQvGSoSk1jr6l5xFbnyYumj6UY NY2FYb2ZLs7dBysybDqVLWk8G6DUEc8yH2ilrGM+vcd2R4SZzmSZc2nhaHzeyOKaB/e1 Kbrw== X-Gm-Message-State: ABy/qLYKWVEMyF4oSsK4XICOsH0U4KIC+rmucBr2bxAiuAqi8PmSr0FI fDpYUeFboebCTMQmrJDje4lXXocq/8Y= X-Google-Smtp-Source: APBJJlEWUnALmXxkvjV3yo0ymj8kuu7DzVmi6dABhRyOOA7FxzT/dpC/mh3rlFuQmsLuRivaKCC5ow== X-Received: by 2002:a05:6a20:1008:b0:137:866b:723f with SMTP id gs8-20020a056a20100800b00137866b723fmr2282210pzc.15.1689980139100; Fri, 21 Jul 2023 15:55:39 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id u22-20020a170902a61600b001b2069072ccsm4036545plq.18.2023.07.21.15.55.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 15:55:38 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id A4CFC1142A97; Sat, 22 Jul 2023 08:25:35 +0930 (ACST) Date: Sat, 22 Jul 2023 08:25:35 +0930 From: Alan Modra To: Tan Yuan Cc: binutils@sourceware.org, jbeulich@suse.com Subject: Re: [PATCH 0/1] gas: add new command line option --no-group-check Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3034.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Jul 21, 2023 at 11:14:20PM +0800, Tan Yuan wrote: > Hi, list > > This patch introduces a new option that allows suppressing the warning > when attaching a group to a section that already belongs to a group. Is this alternative patch sufficient for the kernel usage? * config/obj-elf.c (obj_elf_attach_to_group): Don't warn if group name matches current group for section. diff --git a/gas/config/obj-elf.c b/gas/config/obj-elf.c index 753a929fb14..dc05b35ee99 100644 --- a/gas/config/obj-elf.c +++ b/gas/config/obj-elf.c @@ -1088,8 +1088,9 @@ obj_elf_attach_to_group (int dummy ATTRIBUTE_UNUSED) if (elf_group_name (now_seg)) { - as_warn (_("section %s already has a group (%s)"), - bfd_section_name (now_seg), elf_group_name (now_seg)); + if (strcmp (elf_group_name (now_seg), gname) != 0) + as_warn (_("section %s already has a group (%s)"), + bfd_section_name (now_seg), elf_group_name (now_seg)); return; } -- Alan Modra Australia Development Lab, IBM