From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 3B66A3858D28 for ; Tue, 1 Aug 2023 01:11:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3B66A3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1b8ad8383faso44007675ad.0 for ; Mon, 31 Jul 2023 18:11:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690852311; x=1691457111; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1A5IQSXfTKSA5UXwXf1COK5pm1EvyEEHur/KuSyp7RY=; b=eqTx/qy9Uk2niGwoxNRvXd+LHs72QfW1gKzKV6d5UTwAiBn0oo3ZvtQ2wUtDUiLI9V XF2ACiRm++MNFfzgmgilRgkzHRf6Wbdo8e4A4Jcz3x89ImfgKYENcsH0s6QTteowH9ux 2MdXS5lVO1pUUP3PpHEa4FDKuq3UiiNucjmTYQMUg1uWxQ91ZBynJ2XaxJmU1YUdiZWM kJc2yf+imvghGkfbUaQuyQ6QsUUJi5AJ8Hl3IWx9kpGdJs0tSrx7cjtjOwv9CP+MhB8x V9iGo1GGHKYhiIWlqvo3DgtSDUMbrtORi1S2zadgUMVGNB8eZUk9cYo86YZzzSPyqgkS 8KBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690852311; x=1691457111; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1A5IQSXfTKSA5UXwXf1COK5pm1EvyEEHur/KuSyp7RY=; b=aOqhVdrp4B4zJ9NoNjtJGasP7kQ1LrQCjfM9+nqpjHCh1Atp17l4hK97+5o8k6oVIv KszJuhkxnTIlnr1IrnLiZm382pSEzjPiS7ODVeT44HlrgwciuEUZaTdwkvvyU5YWDocq fTfd+aVsPxOJh3awZmT6xRs567JlUSipg1xSO1oU6trVYuhVGJ8udzXYpIo4L3pGyJKx P7CiC6BY5B2n88mRWE/THDutkkhSK3Fl0+e348/C9SV+CwhRCraEsGUGeEC7AymGOoDJ DuQg+pSRSDPMV7krsJIx7YE/l6icAnK1Kv39RkxpvnhwDtP/hMlWnZ+YnYtUVhaXMCkc YBLg== X-Gm-Message-State: ABy/qLZgP5U5nfBTzsyi6qeLtDfFv6BLjFmKxU6/rcv3EsJAQb1GNLAk SzgbUjlrgscpgxOxkplzHA0= X-Google-Smtp-Source: APBJJlG913on8y+mdEbfD1Y+r+3QlhK9oBQ3lrbDIgM+6diYkm0AYGp3uzGABfTUhKCtbPdmY0e8TQ== X-Received: by 2002:a17:902:ecd2:b0:1b9:e97f:3846 with SMTP id a18-20020a170902ecd200b001b9e97f3846mr14499138plh.15.1690852311070; Mon, 31 Jul 2023 18:11:51 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:882:7df9:9cf2:59e4]) by smtp.gmail.com with ESMTPSA id a18-20020a170902b59200b001b54d064a4bsm9122853pls.259.2023.07.31.18.11.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 18:11:49 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 8ED941141DE4; Tue, 1 Aug 2023 10:41:47 +0930 (ACST) Date: Tue, 1 Aug 2023 10:41:47 +0930 From: Alan Modra To: Oleg Tolmatcev Cc: Nick Clifton , "binutils@sourceware.org" Subject: Re: [PATCH V3] optimize handle_COMDAT Message-ID: References: <648f4180.a70a0220.a7021.407c@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3026.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jul 03, 2023 at 12:09:22AM +0200, Oleg Tolmatcev via Binutils wrote: > Am Fr., 30. Juni 2023 um 14:08 Uhr schrieb Nick Clifton : > > Thank you. Unfortunately there are still a couple of problems > > with the patch, Firstly, and most importantly, the patch triggers > > a new failure in the linker testsuite: > > > > Running ld/testsuite/ld-linkonce/linkonce.exp ... > > [...] > > FAIL: pr26103 > > > > I have run "make check" in WSL and it passed. I then rebased the patch > on top of master and ran "make check" in WSL again and it passed. I > can not reproduce the failure. I develop on Windows, but I even ran it > on my Linux machine with Manjaro Linux and it passed. I applied your latest patch, and it results in failures as Nick said. aarch64-pe +FAIL: pr26103 arm-pe +FAIL: pr26103 arm-wince-pe +FAIL: pr26103 i686-pe +FAIL: pr26103 mcore-pe +FAIL: pr26103 sh-pe +FAIL: pr26103 x86_64-w64-mingw32 +FAIL: pr26103 This is with mainline binutils built on x86_64-linux using ~/src/binutils-gdb/configure \ --disable-nls \ --disable-gdb --disable-gdbserver --disable-gdbsupport --disable-gprofng \ --disable-libbacktrace --disable-libdecnumber --disable-readline --disable-sim \ --enable-obsolete --target=$target make && make check I think something is wrong with your testing. In ld/ld.log for x86_64-w64-mingw32 I see ./ld-new -o tmpdir/pr26103 -L/home/alan/src/binutils-gdb/ld/testsuite/ld-linkonce tmpdir/ref1.o --start-group tmpdir/sym.a tmpdir/ref2.o --end-group Executing on host: sh -c {./ld-new -o tmpdir/pr26103 -L/home/alan/src/binutils-gdb/ld/testsuite/ld-linkonce tmpdir/ref1.o --start-group tmpdir/sym.a tmpdir/ref2.o --end-group 2>&1} /dev/null ld.tmp (timeout = 300) spawn [open ...] ./ld-new: tmpdir/sym.a(sym2.o):fake:(.gnu.linkonce.d.foo[onex]+0x0): multiple definition of `foo'; tmpdir/sym.a(sym1.o):fake:(.gnu.linkonce.d.foo[one]+0x0): first defined here ./ld-new: tmpdir/sym.a(sym3.o):fake:(.gnu.linkonce.d.foo[oney]+0x0): multiple definition of `foo'; tmpdir/sym.a(sym1.o):fake:(.gnu.linkonce.d.foo[one]+0x0): first defined here ./ld-new: tmpdir/sym.a(sym2.o):fake:(.gnu.linkonce.d.foo[onex]+0x0): multiple definition of `foo'; tmpdir/sym.a(sym1.o):fake:(.gnu.linkonce.d.foo[one]+0x0): first defined here ./ld-new: tmpdir/sym.a(sym3.o):fake:(.gnu.linkonce.d.foo[oney]+0x0): multiple definition of `foo'; tmpdir/sym.a(sym1.o):fake:(.gnu.linkonce.d.foo[one]+0x0): first defined here FAIL: pr26103 -- Alan Modra Australia Development Lab, IBM