From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: binutils/dwarf.c abbrev list leak
Date: Wed, 30 Aug 2023 11:24:34 +0930 [thread overview]
Message-ID: <ZO6hWsxoNf+p5Lvn@squeak.grove.modra.org> (raw)
* dwarf.c (process_debug_info): Call free_abrev_list on
return paths.
diff --git a/binutils/dwarf.c b/binutils/dwarf.c
index 80bbc547bb1..9e22a74209e 100644
--- a/binutils/dwarf.c
+++ b/binutils/dwarf.c
@@ -3997,7 +3997,11 @@ process_debug_info (struct dwarf_section * section,
}
}
if (dwarf_start_die != 0 && level < saved_level)
- return true;
+ {
+ if (list != NULL)
+ free_abbrev_list (list);
+ return true;
+ }
continue;
}
@@ -4038,6 +4042,8 @@ process_debug_info (struct dwarf_section * section,
}
warn (_("DIE at offset %#lx refers to abbreviation number %lu which does not exist\n"),
die_offset, abbrev_number);
+ if (list != NULL)
+ free_abbrev_list (list);
return false;
}
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2023-08-30 1:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO6hWsxoNf+p5Lvn@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).