public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@gmail.com>
To: Paul Iannetta <piannetta@kalrayinc.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] kvx: fix 32-bit build and validation
Date: Wed, 23 Aug 2023 21:44:12 +0930	[thread overview]
Message-ID: <ZOX4FFGJ5QZ5D/U5@squeak.grove.modra.org> (raw)
In-Reply-To: <20230823074425.yikpvg2mcgmhipbu@ws2202.lin.mbt.kalray.eu>

On Wed, Aug 23, 2023 at 09:44:25AM +0200, Paul Iannetta wrote:
> On Wed, Aug 23, 2023 at 09:57:26AM +0930, Alan Modra wrote:
> > ..I don't see kvx_elf64_linux_vec defined anywhere.  Delete it?
> 
> Indeed, it somehow got missing from bfd/targets.c, it is mostly
> similar to kvx_elf64_vec, and only exists to match what is done in the
> linker with the emulation elf64kvx_linux.

Unless you really need it, don't add it.  If you have two target
vectors that match kvx objects then people will run into "file format
is ambiguous" errors when attempting to use any of objdump, objcopy,
nm etc. on a kvx object.  You won't see that if you've built binutils
with one of the kvx targets as the default, but will if you've built
say --target=x86_64-linux-gnu --enable-targets=all.

-- 
Alan Modra
Australia Development Lab, IBM

  reply	other threads:[~2023-08-23 12:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-22 16:01 Paul Iannetta
2023-08-23  0:27 ` Alan Modra
2023-08-23  7:44   ` Paul Iannetta
2023-08-23 12:14     ` Alan Modra [this message]
2023-08-23 14:39       ` [PATCH 0/4] kvx: various fixes Paul Iannetta
2023-08-23 14:39         ` [PATCH 1/4] kvx: remove kvx_elf64_linux_vec Paul Iannetta
2023-08-23 14:39         ` [PATCH 2/4] kvx: fix handling of STB_GNU_UNIQUE symbols Paul Iannetta
2023-08-23 14:39         ` [PATCH 3/4] kvx: use {u,}int32_t and {u,}int64_t Paul Iannetta
2023-08-23 14:39         ` [PATCH 4/4] kvx: bfd/config.bfd & ld/configure.tgt Paul Iannetta
2023-08-24  3:12         ` [PATCH 0/4] kvx: various fixes Alan Modra
2023-08-24  6:26           ` Paul Iannetta
2023-08-24  8:49           ` [PATCH] kvx: fix kvx_reassemble_bundle index 8 out of bounds Paul Iannetta
2023-08-24  9:08             ` Alan Modra
2023-08-24  9:26               ` Paul Iannetta
2023-09-07 12:46                 ` Alan Modra
2023-09-07 15:27                   ` Paul Iannetta
2023-08-23 14:40       ` [PATCH] kvx: fix 32-bit build and validation Paul Iannetta
2023-08-23  3:16 ` Alan Modra
2023-08-23 13:39   ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZOX4FFGJ5QZ5D/U5@squeak.grove.modra.org \
    --to=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=piannetta@kalrayinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).