Re: [PATCH] libctf: ctf_member_next needs to return (ssize_t)-1 on error

[Alan Modra <amodra@gmail.com>]

On Thu, Aug 24, 2023 at 01:32:49PM +0200, Torbjörn SVENSSON via Binutils wrote:
> diff --git a/libctf/ctf-types.c b/libctf/ctf-types.c
> index c20ff825d9a..058b647ba9a 100644
> --- a/libctf/ctf-types.c
> +++ b/libctf/ctf-types.c
> @@ -233,7 +233,8 @@ ctf_member_next (ctf_dict_t *fp, ctf_id_t type, ctf_next_t **it,
>   end_iter:
>    ctf_next_destroy (i);
>    *it = NULL;
> -  return ctf_set_errno (ofp, ECTF_NEXT_END);
> +  ctf_set_errno (ofp, ECTF_NEXT_END);
> +  return -1;
>  }
>  
>  /* Iterate over the members of an ENUM.  We pass the string name and associated

This isn't the correct fix.  There are many uses of ctf_set_errno,
even in the function you are patching.  Some other fix is needed to
cope with unsigned long being smaller than ssize_t for the Microsoft
64-bit ABIs.

-- 
Alan Modra
Australia Development Lab, IBM