From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: Re: comdat_hash memory leaks
Date: Mon, 28 Aug 2023 23:11:25 +0930 [thread overview]
Message-ID: <ZOykBX2hzubDhHCI@squeak.grove.modra.org> (raw)
I missed another field that needs freeing. Also, oss-fuzz found a
case with a C_FILE sym using multiple auxents for a long file name
which overflowed the single auxent buffer. I'm going to fix that
problem in swap_aux_in too, but we may as well avoid it here too,
saving unnecessary work.
* coffcode.h (comdat_delf): Free comdat_name.
(fill_comdat_hash): Only look at symbols with one auxent.
diff --git a/bfd/coffcode.h b/bfd/coffcode.h
index 03c1788a1c9..908dc93c64a 100644
--- a/bfd/coffcode.h
+++ b/bfd/coffcode.h
@@ -872,6 +872,7 @@ static void
comdat_delf (void *ent)
{
struct comdat_hash_entry *e = ent;
+ free (e->comdat_name);
free (e->symname);
free (e);
}
@@ -964,7 +965,7 @@ fill_comdat_hash (bfd *abfd)
if (*slot == NULL)
{
- if (isym.n_numaux == 0)
+ if (isym.n_numaux != 1)
aux.x_scn.x_comdat = 0;
else
{
--
Alan Modra
Australia Development Lab, IBM
next reply other threads:[~2023-08-28 13:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 13:41 Alan Modra [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-08-27 4:48 Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOykBX2hzubDhHCI@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).