From: Frederic Cambus <fred@statdns.com>
To: Nick Clifton <nickc@redhat.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] Add support to readelf for the PT_OPENBSD_NOBTCFI segment type.
Date: Thu, 28 Sep 2023 13:05:14 +0200 [thread overview]
Message-ID: <ZRVd6sE3RUoqZqhD@hydra> (raw)
In-Reply-To: <0b0c6527-b1b8-590d-9759-3f0d8efd2eb1@redhat.com>
Hi Nick,
On Wed, Sep 27, 2023 at 02:38:25PM +0100, Nick Clifton wrote:
> Hi Frederic,
>
> Approved - please apply - but with one very small change:
>
> > #define PT_OPENBSD_WXNEEDED (PT_LOOS + 0x5a3dbe7) /* Program does W^X violations. */
> > +#define PT_OPENBSD_NOBTCFI (PT_LOOS + 0x5a3dbe8) /* no branch target CFI. */
> > #define PT_OPENBSD_BOOTDATA (PT_LOOS + 0x5a41be6) /* Section for boot arguments. */
>
> Please could you use a capital letter at the start of the comment. ie:
>
> > +#define PT_OPENBSD_NOBTCFI (PT_LOOS + 0x5a3dbe8) /* No branch target CFI. */
Thanks for the review. I don't have commit access, could you please
commit it for me?
next prev parent reply other threads:[~2023-09-28 11:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 14:31 Frederic Cambus
2023-09-27 13:38 ` Nick Clifton
2023-09-28 11:05 ` Frederic Cambus [this message]
2023-09-28 12:39 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRVd6sE3RUoqZqhD@hydra \
--to=fred@statdns.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).