From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 511B33857C4F for ; Fri, 13 Oct 2023 11:35:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 511B33857C4F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id D1B11335C34; Fri, 13 Oct 2023 11:35:56 +0000 (UTC) Date: Fri, 13 Oct 2023 17:20:55 +0545 From: Mike Frysinger To: Stafford Horne Cc: GNU Binutils , Linux OpenRISC Subject: Re: [PATCH] sim: or1k: Eliminate dangerous RWX load segments Message-ID: References: <20230819074518.2253226-1-shorne@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f7ZpQ4lFWPmQGquu" Content-Disposition: inline In-Reply-To: <20230819074518.2253226-1-shorne@gmail.com> X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --f7ZpQ4lFWPmQGquu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 19 Aug 2023 08:45, Stafford Horne wrote: > This fixes test failures caused by the new linker warning which report: >=20 > ./ld/ld-new: warning: load.S.x has a LOAD segment with RWX permissions >=20 > Fix this by splitting the linker MEMORY into ram and rom to avoid > generating RWX sections. This required tests to be adjusted to fix > issues with the move. Namely: >=20 > - fpu tests: were incorrectly using l.ori with ha(anchor) which now > that we pushed the anchor up in memory it exposes the bug. Update > to used the correct l.movhi instruction instead. > - adrp test: the test reports ram offset addresses, now that we have > moved memory layout around a bit I adjusted the test output. Some > padding is added before pi to show that the actual address of pi and > the adrp page offset are not the same. >=20 > Bug: https://sourceware.org/PR29957 nit: put [PR sim/29957] at the end of the git commit summary (first line) otherwise, lgtm, thanks -mike --f7ZpQ4lFWPmQGquu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEfjLn+uywF2RXRpXdyTaAqES06MkFAmUpK5UACgkQyTaAqES0 6MlNqQv+M23ATXBj28DBw85ITUTTIFNQm6/NnqmwkC5o4j6AqZ2hON68hl3kLbXk QdepcN4Cqgmavz+VBl5sumzORxJgd8PCsXfKVQEMTNitkmZFtTROSyjbgfauVfPo FhM2l17GSOoQQwRP20v+3LY1sBMozPvNBQ++1SndsVVsjZ26XYL92VU46Ud1n5SL KXrAPZaTe9ziDGtWk7YmCSQz+rEmKEjlHbznuA+4PO3LLAhx2NXtip0flVti+dej dplWfiSx1X/omkH8OxqkxKGMKID1paWbfzCvJWpS+OIqeUJoxNhI7Wdo/PpxJFEI NXTP3OfaFmcBxa1rVhU/MCVMoKo0VnYWAuOnhXQAC4wo8ke8Dk3/3DELNYbzQIzr rrcLpkNvDVxKBrGO9Q3FxslODA/x3/IVjQ7VSvYdGu/ia6vw/b7IsOZZ6sO6KcwQ NgzN/L9S1ou9woh0vyXfHvx/07WTXTEd3HVqqFpAy8S2C3L7eRL2Il4Te6qBLl1E aw8dfDoM =tM6b -----END PGP SIGNATURE----- --f7ZpQ4lFWPmQGquu--