From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 242613858D28 for ; Sat, 14 Oct 2023 06:30:38 +0000 (GMT) ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 242613858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697265039; cv=none; b=Ym90iqp2f2VW/IM0yeW6lLGJ0AHGgVkQ0Yk5A9ZebAj1zEeY1cW7dMZbCG1XQh2quDMSgzflxpRL6xkWrXA3FmK8ON0zz7KvbbDsz7OVAVgzaXNdrHvaXBsVq/QDFP1V1AXFtBCD89h9hSMw6e/zMBQL5CiFvkBgqCTPMjRxi5I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697265039; c=relaxed/simple; bh=YzEZW58ar168CoSUkhpYVjeY9YP/WsGSZCkbsSOGsh4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=XQAg02jz7Tk10btki3B3GdPjn779RufHMF4j2upARt/45g09U8hvbEwzImeShM5MJwyjKDP6zN+Mxs45S9aXRswY+VYe076kF/P+ilOvKfsI3V0Mv42EQWqW6fp8WhvhZsXZLZaWq1H1HbRwLnwF9yMkpDduKgGGeJ+ZLwMgQ6I= ARC-Authentication-Results: i=1; server2.sourceware.org DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 242613858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4060b623e64so17729825e9.0 for ; Fri, 13 Oct 2023 23:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697265037; x=1697869837; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GZhS6EfNjAu2Xk6+DSF0lcgeLcv7BCYYmC9iVjAo5xw=; b=ewZ+FO/WfnNYZuUEgedSzyHC8eSXKhSgB/5IKqrxp9GYez7lTj+TL/6cnI3z5l/+bP MaXhTJNolITgQhMBChB7xazDEeVW5xPAEeLGKFRxudf9UlNdKAQiYMJ8wIt4OCe2JtrK eT70Eq9XFZ8kpEO/YsWxPYoQKJ9D/1gthtq8JhYZGuotXhsUMd/J3ED/okQO2gSv0vAT C2WJh8bGmcv+tTfua6F6+QrO9vFY46bdTVjOH8K8oRNRFGPVAYZmRb2gSD3p60jzIySK duDVY4lHLZm75da29UUH384cx8mLBeeEH6JpM1HUxi8HPMgUwU4ecMWhoy/FC3beRnLL exhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697265037; x=1697869837; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GZhS6EfNjAu2Xk6+DSF0lcgeLcv7BCYYmC9iVjAo5xw=; b=FWnNXdt++RDkKTCxxu7Jr5ub6BtfEjYgzhkDkuUZwBc5jfAbD7Zr2GE0Vk1zmxZ2+5 eGb8qF/okf9KdiArfHJ2dBUK4T1Pdlfmu1ouuRWSQBxp2nNHmfjQ/VG3lhDffSjvim5N iMtmAbG7e1VWHrUfy9JsBAKSv+/ioPQGpoAkC/lUdteFy/GbhqdRVaYhDlMB84HnDSq7 m0rgN5FkIQeKJbVQBFzGP5GKTVbtU7KcnkFvFHf2wKNgmVl6BUk1Gw3bDACD9dKK9nn5 NnHjPklBxDLL4BhvEg7ggeJkeK3KJU6v8W1zv/GKM9vjiXAPCg/A8Ai+tFRU4Qta6sWP /6Gw== X-Gm-Message-State: AOJu0Yy7ekwxo5V7vvNj/dTtwkG1UX9Qta/KfRW7XEcfe9Xr0Dm5ke5w g0JL2JHjcZX0FeaSnjmkOO61uJfig6o= X-Google-Smtp-Source: AGHT+IHgJAMcmnFtHnMA9H6+U073rnN92J9qg0NMtx3Uc1X+CV7BeZTfMM++8Qzg0mvGKiDu9RF4wA== X-Received: by 2002:a05:600c:3b06:b0:3fe:da37:d59 with SMTP id m6-20020a05600c3b0600b003feda370d59mr1491431wms.4.1697265036405; Fri, 13 Oct 2023 23:30:36 -0700 (PDT) Received: from localhost (cpc1-brnt4-2-0-cust862.4-2.cable.virginm.net. [86.9.131.95]) by smtp.gmail.com with ESMTPSA id f12-20020a05600c4e8c00b0040772934b12sm1130748wmq.7.2023.10.13.23.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 23:30:35 -0700 (PDT) Date: Sat, 14 Oct 2023 07:30:34 +0100 From: Stafford Horne To: Mike Frysinger Cc: GNU Binutils , Linux OpenRISC Subject: Re: [PATCH] sim: or1k: Eliminate dangerous RWX load segments Message-ID: References: <20230819074518.2253226-1-shorne@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Oct 13, 2023 at 05:20:55PM +0545, Mike Frysinger wrote: > On 19 Aug 2023 08:45, Stafford Horne wrote: > > This fixes test failures caused by the new linker warning which report: > > > > ./ld/ld-new: warning: load.S.x has a LOAD segment with RWX permissions > > > > Fix this by splitting the linker MEMORY into ram and rom to avoid > > generating RWX sections. This required tests to be adjusted to fix > > issues with the move. Namely: > > > > - fpu tests: were incorrectly using l.ori with ha(anchor) which now > > that we pushed the anchor up in memory it exposes the bug. Update > > to used the correct l.movhi instruction instead. > > - adrp test: the test reports ram offset addresses, now that we have > > moved memory layout around a bit I adjusted the test output. Some > > padding is added before pi to show that the actual address of pi and > > the adrp page offset are not the same. > > > > Bug: https://sourceware.org/PR29957 > > nit: put [PR sim/29957] at the end of the git commit summary (first line) > > otherwise, lgtm, thanks > -mike Thanks Mike, I actually pushed this long back without the above update after I read Nick's comment. I for some reason missed that he said he was forwarding to the sim maintainers. Sorry for that. -Stafford