From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id C10293858C2B for ; Sat, 14 Oct 2023 08:26:26 +0000 (GMT) ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C10293858C2B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697271988; cv=none; b=YuLi4v7ulScBbga9vFvGIKr9un67vdWNxajUCRipc/P4AVpRmdMGWAeUpYze9++t/xXLNv/FPANmeC5zZsa8AZh4LvuQJ1IuAu3Q5yBVVvezfdWyMMP46s1jMp0vuCrTrpkJan2QXsxBrjL0Vv9kn2TJ4BCA+jPkqKC4mpYZIf8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697271988; c=relaxed/simple; bh=XXniIAH0XMUwKgt1hLPiVcC69VUnyFUk1jI4yvNKNzg=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=fn5Nj7Fe1zUD9wK5s3RlBohNCAhD8gPVbxJ4ZtFyitpLozsxqD9Vlz1lA5nGagcxDNeqKGGnnVj5pUdvVx7Nn4bC7QescjYw/Cojq7qi6OyFZ/9WYM7dtcXIXCoBVLzFTajxtjJwemIx/hHRh32oL71ca1dFwqDfqvEPJNOip3Q= ARC-Authentication-Results: i=1; server2.sourceware.org DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C10293858C2B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id C146B335C5D; Sat, 14 Oct 2023 08:26:25 +0000 (UTC) Date: Sat, 14 Oct 2023 14:11:24 +0545 From: Mike Frysinger To: Stafford Horne Cc: GNU Binutils , Linux OpenRISC Subject: Re: [PATCH] sim: or1k: Eliminate dangerous RWX load segments Message-ID: References: <20230819074518.2253226-1-shorne@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="A7YUB2DCJULXoJ3i" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --A7YUB2DCJULXoJ3i Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 14 Oct 2023 07:30, Stafford Horne wrote: > On Fri, Oct 13, 2023 at 05:20:55PM +0545, Mike Frysinger wrote: > > On 19 Aug 2023 08:45, Stafford Horne wrote: > > > This fixes test failures caused by the new linker warning which repor= t: > > >=20 > > > ./ld/ld-new: warning: load.S.x has a LOAD segment with RWX permissi= ons > > >=20 > > > Fix this by splitting the linker MEMORY into ram and rom to avoid > > > generating RWX sections. This required tests to be adjusted to fix > > > issues with the move. Namely: > > >=20 > > > - fpu tests: were incorrectly using l.ori with ha(anchor) which now > > > that we pushed the anchor up in memory it exposes the bug. Update > > > to used the correct l.movhi instruction instead. > > > - adrp test: the test reports ram offset addresses, now that we have > > > moved memory layout around a bit I adjusted the test output. Some > > > padding is added before pi to show that the actual address of pi = and > > > the adrp page offset are not the same. > > >=20 > > > Bug: https://sourceware.org/PR29957 > >=20 > > nit: put [PR sim/29957] at the end of the git commit summary (first lin= e) > >=20 > > otherwise, lgtm, thanks > > -mike >=20 > Thanks Mike, >=20 > I actually pushed this long back without the above update after I read Ni= ck's > comment. I for some reason missed that he said he was forwarding to the = sim > maintainers. >=20 > Sorry for that. np. had some hardware failures on my main desktop so only just catching up. -mike --A7YUB2DCJULXoJ3i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEfjLn+uywF2RXRpXdyTaAqES06MkFAmUqUK8ACgkQyTaAqES0 6MmLCQv9E+1y98XEQW2KCJm5hVmPgl5oAjaJCGC1YOLyUcdv2MzQ4LYCe4/irxNu 4zLNmFfcGIfRM4kQJH2jmLnXOiOxCWumEetaBkT5pMdV3IUH7KsShTwyhgsQjqpd yy73QbPRXuVuH0D3payh9DujF6Q/H6qm6hPK+EUx0t/9c7XCgRstxvhE9d1K6bzH 7G2jJU8mjh79RaTPv1Aj/qsdfUzf6WLO0Zz7v0FP38sYgHhQ9ecE6gzRO/f777Qi 0TYH2Zb9NWjqf3nF7UeDYlsp1bgSENRv3J39E63fpZf9DsIhNHm//vQNrXaFp8qz pPxcKjqBcAKLvtmoFqOTj9F27oBxZNtkN80yzMP5qCYIBW5F6QD7TN91BrQau9Hx uG/X+pg5YEKmcgcGdItoZQ+AZjcPT3801vRpeqVHbl3oiMJaFPrPXRC8eUqIfuLi nEFEi+5m4eUUqILtqowr1ZhvvKRbS7fOkTSQOUL88MVonaWO7FgyZH3+Hl5FdcS4 MV3jq+LM =02jy -----END PGP SIGNATURE----- --A7YUB2DCJULXoJ3i--