From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2059.outbound.protection.outlook.com [40.107.7.59]) by sourceware.org (Postfix) with ESMTPS id 187E13858425 for ; Tue, 7 Nov 2023 13:09:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 187E13858425 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 187E13858425 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.7.59 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1699362570; cv=pass; b=nlgROXr7HKeJMQs3G2AGG4xbU3LiaGJ0If67nBr+xJw0jOUDZ3yafog36hwTkKltda3oxPU4ti1oCWYmrgGhqm8EpBIzwIKq3YG8KDP9648+qPRMX+QyUtNB5hame/BsnQ9hOXJlqTexyOzo7EkMdultSq+wvJTSN52i8dEbrEo= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1699362570; c=relaxed/simple; bh=gPQj0Gv8vUpgIklG3NKOaTjboiVSCGKDkgNuf75I4aA=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:Message-ID: MIME-Version; b=eIiryGcPRoH7osEQX//cNHEZxuyaM9nVO18sjpm2Hr6W34HKcIH0uQX0fSVLsD2MBiWFuBiY6vhtPHoeN8SX/i7EoLEBPJyahZlNGCXGDB0CHHQa9y8U83thV8yW7JRUr7v660U3Z0jNjPIzBZxpqWQMtUikEcECzhtEoicFvrg= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=cEX+2L6BJwfGI1RKj+gtcb2H3e+jiqKZI0AE0nN/eCDYxTTcjpm2V/zgAOv/ieZOTEhcSe4yIEi7ngMyqgdVEbNmTWRNHCmqXy3JD/HYBe0cmUez7GU2RYN+B3CCMwRQFjAhs6+dkopRoJE9bCagJ4DAmMC8qJyi2wUb6WdWdsWv62c/e38NDQC+CGTa4Cqh6eLiPlcDeXLRP/doQm7ooTwqLGAwMFUHB3KjqxzID1DKuYpo02YW1YuJ+hYmrAjYbXyjgOtyLz900RDDjqFvzeBUllAS4alHSkoK6Lfh2gMggFFfVqtll4MGW1SObBG7MjQeyruOiDH56ZFfJ2d8xQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VYicTNVXe1r8dTtftMELpULjF6zSSGgi7V7dY1jz1B0=; b=doap1gz3RUAlCUXF6fglAOVl/NRJ1aHQbhqGyL2onmTZ9toRmLk/uZpPjUhX/bq9DNzz70wNZx/75WE+AbTDwTW3W2wDHsYa0LuOtUPCpLDzqkb6Lq8cAbnJGvpQers+idVo1Q5LdylSZPpSOnpupEnafTERlcxedGYJRBuHNUSEaqXGc1KIIlkp3gmqrn5wxSdo8HhoVYv7wLjDpuLZQB3iIZFafSLnik1990muHkdyS3uPxYNWVN9F5hESS52zWkmCt2HAisZu+omiCNlUeCDUJryr1akX+DM8R5sHIRfkXSMaAaLaDZlBgXIEPJunz5cOMOBFaJGdP7p8FepH4Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VYicTNVXe1r8dTtftMELpULjF6zSSGgi7V7dY1jz1B0=; b=od9+sP678UwNy0Jm5dFsx6AXIa9JA4AxDdiRkiebJHncpz8jI4cYHTLKtv22C4LAIpHFiNNudkZlivKNSNoox+ErSamlKnzhjHCNVifGu1hO+cD0UwiuwmB1cfjp0ZgnObHittFZ2FWCLZuf4Zif//6ALPp6KcGyGUmenPMl/Mk= Received: from DU2P251CA0006.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::7) by AS4PR08MB7580.eurprd08.prod.outlook.com (2603:10a6:20b:4ff::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.28; Tue, 7 Nov 2023 13:09:24 +0000 Received: from DU6PEPF00009525.eurprd02.prod.outlook.com (2603:10a6:10:230:cafe::aa) by DU2P251CA0006.outlook.office365.com (2603:10a6:10:230::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.28 via Frontend Transport; Tue, 7 Nov 2023 13:09:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU6PEPF00009525.mail.protection.outlook.com (10.167.8.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.16 via Frontend Transport; Tue, 7 Nov 2023 13:09:24 +0000 Received: ("Tessian outbound 5d213238733f:v228"); Tue, 07 Nov 2023 13:09:24 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 182f042388fe577c X-CR-MTA-TID: 64aa7808 Received: from 647bbbc7284a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F841B536-E541-47DC-A880-F6E7A5F6C6D4.1; Tue, 07 Nov 2023 13:09:17 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 647bbbc7284a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Nov 2023 13:09:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BODkJWvj/htSwgIJchOzEeonYQcTxjOCwzUECd3Mxs8ymgeM9AkNWMw5pgxG2xfHrrzkztQV4i/nt2VpPVz3uPdl4ss0P9ZnzRwCsGdxxvr6XsflbZ6wodlckaltI7tIGowMQN8Vo3KLLBjhxDAx+9wc8j8A2humqyxKLK8410QaI79doBAQSlHXqFQ9xwO45L1kO7QbJTGywtAHlulwrL1rC2K1P4hwzjPZ+ctNlysdCXa6KFk6rVqnrxaLKA5em83x5l3DwPODNb0/k+04lwS2YP3JrdsTHhyyg9L+WlQieTOm0+QZu7Zk3cMjMlDGWACKVMGp2quAHTnC24bvlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VYicTNVXe1r8dTtftMELpULjF6zSSGgi7V7dY1jz1B0=; b=O3HfoVBny7KEuH8UanyWrPjeJwCX3gM7Q+9VNUMh4gQzXUHgZLArYGCypwZ36cjA3/cvfhkF8imBvxS9C7c4iH/sh/eiMJQPVyJJ/E130nxbz6bNCOL8uyhnJmwUDqY+FXfT6qs64ONIWdmc7auEH/hi8W78tJHuomNxPFBtln8w2c7IUQLWX5OMHNniDGMNqmp4235t/3rbRU6E2kdzbJBXM3ijXlvQCLF2BSfKuj/PfGwZQkGpMyN1+YdIqTFi62Hc3C9LOOp+lBf/nkH9HSQbHcKopWhiaCsJRTEAmi37s1FqepKd6v57Tc7EdzGxYjSGr3ORK9QKMXgTuw8GYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VYicTNVXe1r8dTtftMELpULjF6zSSGgi7V7dY1jz1B0=; b=od9+sP678UwNy0Jm5dFsx6AXIa9JA4AxDdiRkiebJHncpz8jI4cYHTLKtv22C4LAIpHFiNNudkZlivKNSNoox+ErSamlKnzhjHCNVifGu1hO+cD0UwiuwmB1cfjp0ZgnObHittFZ2FWCLZuf4Zif//6ALPp6KcGyGUmenPMl/Mk= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by GV1PR08MB10401.eurprd08.prod.outlook.com (2603:10a6:150:170::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.28; Tue, 7 Nov 2023 13:09:15 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::a991:ac53:e218:e554]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::a991:ac53:e218:e554%3]) with mapi id 15.20.6954.029; Tue, 7 Nov 2023 13:09:14 +0000 Date: Tue, 7 Nov 2023 13:08:59 +0000 From: Szabolcs Nagy To: Nick Clifton , binutils@sourceware.org Subject: Re: [PATCH 0/5] aarch64 BTI stub fixes Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P123CA0035.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::23) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|GV1PR08MB10401:EE_|DU6PEPF00009525:EE_|AS4PR08MB7580:EE_ X-MS-Office365-Filtering-Correlation-Id: 66eeb229-c7df-42f6-7c61-08dbdf92c38c X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: AJAff3nKc2Tzzl+3DBbWTf4QpxUtDy4sP6Dmgql9AUTbia4F3of8sEt7r9ID/W/SwQA19i+Jcte5Otk+5DodyCx8iLamG1lHNyzWwbzIvBd1dv9nPVBICLAdwaOSe94tqqm/fWEhPfsXIr1N3upi6AW2Ro8/aRTI2T/bV3jZ/UuwmUJlstxWxfbGy5qYHx02tdkQO3YrAd4ysn+Qn5c5YordSHH1KvUE49OL/9/DzDuzlr7/c2kpxrfywCfprMoFZvRD1/ENcIDsy3OeeT01oqtpT4getdQXMcaHNBFV6JCbdTKcaSrbDR55imZ3+Iq41cdg7it9pxULezAyfZTDwq0oxbtdzi7nk+Te4TjJiqVttF85/pnGblKD/6SubnZmsbhDSzKxC0wkpFOmm6mijZI3gdfGdzOYR3PXVl93SDPj1Ye+moEMF4uyETxQxdw9uRqj0H5zzRiuE6goLoQBa24DHW07qGNuEeKpS6ODoRmloLai8R5w0/KjSBSVlOOcD6bXyn96byzAxFIdmCYNrrajhTudn/fba2J1pyWmQ3Nz4lVVV0n3T+4HqsXddoW8 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(39860400002)(346002)(366004)(376002)(230922051799003)(64100799003)(1800799009)(451199024)(186009)(41300700001)(36756003)(8676002)(8936002)(2906002)(5660300002)(38100700002)(6486002)(66556008)(6512007)(66476007)(86362001)(44832011)(316002)(66946007)(83380400001)(26005)(2616005)(6666004)(6506007)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB10401 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU6PEPF00009525.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f74c83b6-79ce-48b5-ede8-08dbdf92bd7d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +0A6mcZefhN4lg975q/hU5JZxjzwgvWJAJM0MRTyRuwtrmJ4odXeXWpHI9O+iBmb/E+hHTowYyEntVDtOjjh8GI7cIxjtE3SP7Er/ijhLXzaM2vlQyeW1iD94nfWb6RaM1dJHHVPEl/zdd+rxr3QrNu7aR0u/6qmnmUvl8voO/YrwzThfDQsfeN9I/hniC+68WGXEZFXZYrLX+T5ArsjUWPuo+ho+uN6xAxHvYrovNQtfcE6JSZomW+CaMTNoVEOmhFpBaMioXZvF4caGe8Po60ue0nIPxWx2MW2q5sz8Yzkm/IUU9IacIFPEFaUyh8X1FjYTISRaooB0TBaaclo3NcH/tlHrLGslT22jCihsOWOepd+YkxAWjs+gj5cak+BI0wIf9QY2kLEuJCR6Pgg/chHKk7YfwHYpessEmFYn+ZuXCRxX780rWoiVvipPKyfa+DtAscG8Jwa477CI7D73AqnUQCprKNZUfcRQRqpY8qnbJ8eiV3titNGb4hj9vPY8zSwX9tWlaLmu47CAgRQK4c9UOkz32n6yY4uKpsXs736EJuYDqQj7qGpxU/tQK5e93Wxf+biZkKBtwedK7ua2pKeT0YD279LxqfAcsN+00KqyWYo+yowYNTFon5lKXTg7ijzBhJCEVYu1cLSdeMI9Nwm7wYdDHyizSIav4oaGCa/8WPZFzWEB3p5RQpldHPC8bMrxF0OnZoO+gRnYLvBnF4hseCJnq9+ul9SCoHD30jmibDWbdwljbbpraGQqHJ7 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(376002)(346002)(39860400002)(396003)(136003)(230922051799003)(186009)(1800799009)(451199024)(82310400011)(64100799003)(46966006)(36840700001)(40470700004)(82740400003)(2616005)(336012)(40460700003)(26005)(70206006)(83380400001)(6506007)(478600001)(6666004)(70586007)(6486002)(6512007)(2906002)(8676002)(41300700001)(40480700001)(8936002)(36756003)(36860700001)(5660300002)(86362001)(44832011)(47076005)(81166007)(316002)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2023 13:09:24.1884 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 66eeb229-c7df-42f6-7c61-08dbdf92c38c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU6PEPF00009525.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7580 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 11/07/2023 11:38, Nick Clifton wrote: > Hi Szabolcs, > > > Large binaries with BTI can be linked incorrectly with > > binutils 2.41 because PR30930. > > > > there are other less critical related issues fixed in > > this patchset as well. > > > > Szabolcs Nagy (5): > > bfd: aarch64: Fix BTI stub optimization PR30957 > > bfd: aarch64: Fix broken BTI stub PR30930 > > bfd: aarch64: Fix leaks in case of BTI stub reuse > > bfd: aarch64: Avoid BTI stub for a PLT that has BTI > > ld: aarch64: Add BTI stub insertion test PR30930 > > This patch series looks good to me, so please apply if you have not already done so. > > > FYI - I did find one regression in the linker testsuite with the patch applied: > > FAIL: Check linker stubs with indirect calls handle BTI (exe). > > However there are mitigating circumstances: > > * The failure was for an unusual toolchain configuration: > > --target=aarch64_be-linux-gnu_ilp32 > > * The three other tests in this part of the testsuite also fail, both > with and without your patch applied: > > FAIL: Check linker stubs with indirect calls handle BTI (shared lib). > FAIL: Check linker stubs with indirect calls handle BTI (exe). > FAIL: Check linker stubs with indirect calls handle BTI when target has BTI. > > Note: there appear to be *two* tests called "check linker stubs with indirect calls handle BTI (exe)." > > I leave it up to you to decide if it is worth fixing these tests. thanks for looking at this. i will have to check what's going on. > PS. My gut feeling at the moment is that we do not need a 2.41.1 release > for this patch, since AArch64 systems with BTI enabled are not yet the norm, > and those that do exist are being used to test for problems like this rather > than general use. Since your patch will be in the 2.42 release, due January > next year, I think that that will be a reasonable timescale for getting the > fix out there. Do you agree ? makes sense, unless it affects hardened kernel builds. i will have to check if that's an issue. thanks.