From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id AA7903858C78 for ; Wed, 13 Dec 2023 00:01:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA7903858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AA7903858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::433 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702425707; cv=none; b=Zwo7bnvVWynvmnhO+9UwpyBY/3F36kAnlCq72yCGhj2rqGfLHyrKPEBRH6Uq8tEdSI6vVlEa/t2jKnOYM6bd4dHl552FjF7E9Z7m4nBVFiPtPfuTt/sNhoe9Y2vw29zMxidk1M2w3dYPcRjf81HYcnSR1ZOI3caUpCwkDaJmRLI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702425707; c=relaxed/simple; bh=rHyEaekirjJHAy713uGtcFadDyRzfG4RBZWObYZv2kE=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=A/ijzRmDUD7r2rT/XbEccRbF7Aqwzwhl53XjlkF68Stk6+ovrOXtm2jcBiKM5eqb7FJSVjqzuVPcZQ4YCWyT94I4UJ+tJWwpw0b06GqlaoBWc7tfMM3FXoqTvgF+e0uq5fcXk1YniirICpVgND92bIrqR7Ncu9NB4lilR0tp7a4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6cea2a38b48so5598892b3a.3 for ; Tue, 12 Dec 2023 16:01:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702425704; x=1703030504; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NYeVjizH1otDXqIPa2YQIyba3vJiTJ9mUswicj6ii0c=; b=Yy0yMqkRU8wyQH8fABN83bY5RqDmrGSE0/lHJzPU06/PrHpK8K4dAVS0lETlo/uRG2 0BAn4XYCkePe4hEpoF+ek1v2v38jL2v1iG+9HYvh9n5M4iCPc+zKbRfovEBebBRqbsRz UyH+P9IlaV0cDyqp/JlvScLeI+pz+aNnm04lBIluFI+uznwPOBjzCedCHaCBfkayHvTf G4vvlhROWXwwYxOXw6kCw12K1s+P7DEtZtZbu2TiHHmaSZ/X1wmYH+jT03wIB+yQcx6t 1tHiT0h8gDsxCdO6mZ7qznFLO05DoYJMzTbapsc3xcuN5jxwgGQpajpC51izN/vfGXRQ 9baA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702425704; x=1703030504; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NYeVjizH1otDXqIPa2YQIyba3vJiTJ9mUswicj6ii0c=; b=ZC9GYuqegyHADH/EV2aSIDLniRRz2ed6F8jkexGTg6JWUiWcut6iNHSkvTb8/4E0yg suOhUxvI6HPZ/QffMFJjNUj49cOin2gH8dp+Kmt7qUoc+yMwZeCG/y9VEhwReD/oXwYQ RENTWX7YE8IL7FYW5d6fVtHP3v6GAHb7gwC38ZKITEsuNrgtwJekzv4LBcUWjhDYhPM2 KUq1Tvhi7UoqnllLfOMsxw0jL8uTBEQ6BGoF9HanC1VXkWOwyHu4wjrHfMBUc4QLm4KJ FGAAEYgdefqExgr8P+X0fn7WF0N3sE8riWMjKFbETwI6+k1C00tso33PZ5NsCTFrl1wg 0FTA== X-Gm-Message-State: AOJu0Yz0TTPjpfJ9ugLW7QJ13uALtWhdcEguF5aXUNs2fpLhO453xQ0n W2xQfvZjkNow0yfwilUqvewkhPIZ+MU= X-Google-Smtp-Source: AGHT+IENHu5qRnVhZoVG+pmukdMHd48tEBzlq07oIISKpHBS49rNnPjJeubB1YgkaqavLRFETgXOwQ== X-Received: by 2002:a05:6a00:23cd:b0:6ce:2731:e865 with SMTP id g13-20020a056a0023cd00b006ce2731e865mr6572342pfc.44.1702425704505; Tue, 12 Dec 2023 16:01:44 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id x11-20020aa793ab000000b006ce497add69sm8722596pff.103.2023.12.12.16.01.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 16:01:44 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 52CF81141245; Wed, 13 Dec 2023 10:31:41 +1030 (ACDT) Date: Wed, 13 Dec 2023 10:31:41 +1030 From: Alan Modra To: John David Anglin Cc: Binutils Subject: Re: [PATCH] Fix segmentation fault in bfd/elf32-hppa.c Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3034.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Dec 12, 2023 at 05:21:28PM +0000, John David Anglin wrote: > diff --git a/bfd/elf32-hppa.c b/bfd/elf32-hppa.c > index 44129c80138..131f6806aa7 100644 > --- a/bfd/elf32-hppa.c > +++ b/bfd/elf32-hppa.c > @@ -4216,7 +4216,7 @@ elf32_hppa_finish_dynamic_symbol (bfd *output_bfd, > file, we just want to emit a RELATIVE reloc. The entry > in the global offset table will already have been > initialized in the relocate_section function. */ > - if (!is_dyn) > + if (!is_dyn && eh->root.type != bfd_link_hash_undefined) > { > rela.r_info = ELF32_R_INFO (0, R_PARISC_DIR32); > rela.r_addend = (eh->root.u.def.value Since the code uses u.def here, it is better IMO to test explicitly for either bfd_link_hash_defined or bfd_link_hash_defweak. I'm left wondering whether there isn't some case where we get here with an undefweak (or common, or new, or..) symbol. -- Alan Modra Australia Development Lab, IBM