From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id E62233858C66 for ; Thu, 11 Jan 2024 05:53:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E62233858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E62233858C66 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704952392; cv=none; b=tJsOSHk7M8ZMDp+gAqSQ0KxnxOEc1qjn6S8Nodyy4XF+xwi1shbTlo+Ht59oavlcHMlk3LdKp8rV+XT5dF8DOBPyhaQFqvIiAa9blbF0HtzlVxhzC52sK89gA16ZrHXYjEXWDCmH8McTzY/CUQYyNrCNWz/WPX0Ohx7rPkiJc9A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704952392; c=relaxed/simple; bh=6sdOO1K5q0bk/gjPZqceQGBZBNt6uGL4wGRV55xKW/M=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=oL4jzicegaRKMoZj7V6wvxd8XmQJl0s9N0YGXDc02eQdWMhYEuD1VxvDiFA2Ei9fzJDfE5mb8wSTSwDMLZ0bwKLuN2ksqORRu2UAfP7fFXv15UWEFQ1bD2W9QafI2O+xcEgHNK+tYOt6CUIoRF/A0BW/QAbvyoEpCI57PnM1tcE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 828B8343222; Thu, 11 Jan 2024 05:53:10 +0000 (UTC) Date: Thu, 11 Jan 2024 00:53:09 -0500 From: Mike Frysinger To: vladimir.mezentsev@oracle.com Cc: binutils@sourceware.org Subject: Re: [PATCH] gprofng: 30889 can't compile without large file support Message-ID: References: <20240111040236.1482061-1-vladimir.mezentsev@oracle.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NHvYpsu5z6+4VGsE" Content-Disposition: inline In-Reply-To: <20240111040236.1482061-1-vladimir.mezentsev@oracle.com> X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --NHvYpsu5z6+4VGsE Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 10 Jan 2024 20:02, vladimir.mezentsev@oracle.com wrote: > gprofng/ChangeLog > 2024-01-10 Vladimir Mezentsev >=20 > PR 30889 > * src/DbeJarFile.cc (O_LARGEFILE): Define to 0, if not defined. > * src/Module.cc (O_LARGEFILE): Likewise. > * src/gp-display-src.cc (O_LARGEFILE): Likewise. can't you put this in a single header file (gprof.h?) instead of duplicating the boilerplate in a bunch of files ? -mike --NHvYpsu5z6+4VGsE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmWfgkUACgkQQWM7n+g3 9YH4qRAAjTneO84KYkmg1t7G4a5NAe8KmjLjMxyjJAA0+Z25+Qq6j/t4nAYUI37W lHvelBPk8Wu3hLZGVWxbrmc6xf+C/zA1PtpM5IpvPuXaMVCIl+39YnBZPaGUc+22 PVkk+isG3axpYVX0kpdLyx+BIaYIKzuLS74aY3dUtV3fr6yHQv1Qd0uud6NLzTFP OuOZkE791uvQPb+O2a38OrnCj9ms/2YXwKNPvPP11Yb9Tjmc0jbJw+sFDqnqEynk 4nnIeNT3cAvPvm6mwIbTtSQa02D3sIH/8dQ+1Nqv8dwreht5G9zDLxxizEShPaey CtQC5EIVsG6OmcdsNrI7hPy/cEIhQytz5b7hb7yE6IJec/6+IWA/fkiVmmfo32pt u0sE1hFuM7nxIWs7ywtCVOf7JpnTWdeZXQcVgWkFDopQV6CUODDCoL3vFUGpe6Q9 uPmUvc2UQfhLH7j9bRzrP3RX11NSKMzGdIlqmcAbgtArLOIsuJMWljMOlrvQmGtj sBhT8Uny/pTJfTS57qDKtKdn2F5s72Vct/6Guy55eHjbCWbgFEGDKRW1+cGiuI+u J5YC2ipSc/OZ+kVepsRoQxvyoPprsa8KFvbvVw4BKa8EnmOaPRLFgalEpG+mIUyi HZpDvaIqyZdoeTsE5YkUAJKfJGUU71eSjDCpnsG+hdkmjvVwLkg= =alkM -----END PGP SIGNATURE----- --NHvYpsu5z6+4VGsE--