From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id E37963861855 for ; Thu, 15 Feb 2024 08:44:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E37963861855 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E37963861855 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707986701; cv=none; b=DThdoMFKCLLo9ueTIDpICgzRiUkC0h/nUZGLX15ExJLaYWkL1jqyl+Rhl5Ns2LWYDI5+p/7nbZqyGoMuFt+FHHR4OC3EPCt+fmB8QW75e6Yukt6wTaM4LP6u8CKg85Y30F42rS+SmnRLKCItU+PEKAOegCkagZpH7WLpDqP3iDs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707986701; c=relaxed/simple; bh=hs42ckbSD7sn4RRiGuqu6rY71UoCIehPVcgTS2FcedI=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=EyMC3yUef0kUYDL2Y5XP/P7pUJxbyOZfIlXCpzouOqSzDaRc4mqTrLOmcYIECF6qxllh2emrs1Cw0bcCkPTFB7lbnS1jKeFYtSNGv8T7o8bppd1YYgihKbwwRJgqIs+LhMXwaolsc83OyJ+gCqGst3sq6LicdV8D86giWy3fLdE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1d746ce7d13so5824285ad.0 for ; Thu, 15 Feb 2024 00:44:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707986697; x=1708591497; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=/4bSaCXhjqHjVNOUsGK+Zu5S9i6NnY6fYkTRusqdZ5A=; b=ad9qHZjbTovNG39CDdxXHigH9pLgyxpcZ0O/zbkRlaqN5kVZESk7YODdzGGQYBicra gGP3NC92q+Px6SuwCbm9Z63bmu6DAJiE2HaVC4ZzU1wGf0wd3AC9qC5IL1Gm+VKQ8laq YLH1jXf5G+uXCii5XFExYKIVDE5eq41dOhdA+tq+may7Lgodw0Sw2H8Pu2DKI80G2Aef UyiO9l8jO359uc7ZyNtzedodd0cz1QBON5feTk5fegVjrtjSKoT8sV472GtOjZ/6bM45 GZcLyMpPB3p/BzDCbbBYnp9G4uiW5Jbs9VOXwRDFWuLomVHKL3kZltkZqn32pyuaBPy0 Z/YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707986697; x=1708591497; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/4bSaCXhjqHjVNOUsGK+Zu5S9i6NnY6fYkTRusqdZ5A=; b=qELmNOx737tEUCXQPDDATXgJGkhRfqBqoh7S4X3/U7csAb0C09yfJfzYZ5DVJmeG6W PtDhsePoGTwypl8jOBQCMpI2f5virDQb76KYG8uKniM9phGniUcKtiPGp4bJP9UKQPFg N/9lWyJLPNzleYqGNORsyaTPjuUHT0JIzxmtIXvFrQB54eZmFRXPUm6lxEjDwTLUi2Xx hadrsV4MWC41su7UaeIfA96NcndSDg9ro9RJeKElGhrYqlhXObFytZuV/NK+LsO2twsp O1EI5AsTp9a8ARlq90snAzcwHDcsJYk3XXTXWGpMAaLKIihINAMuAoeK/eKnloO8QxEA Kzcg== X-Gm-Message-State: AOJu0YxQITqM61Yy9Jc+nOC2Yco1vxZR+jZ9GWnO8z/ymyNWwqxKJPj/ b056lX8tq2zQAnhwF58mFJs8jZrAZxQlyKwEIm6WA2lILduyHfc+77wTK6Yi X-Google-Smtp-Source: AGHT+IEyanDrHLPHxubins4McpS0zj3cO8fOgitpoVZU9Q5C3z0iZ0K1Id7UUKWJh6Es1eOnCE26pg== X-Received: by 2002:a17:903:2291:b0:1db:4f20:3ada with SMTP id b17-20020a170903229100b001db4f203adamr1510690plh.49.1707986696942; Thu, 15 Feb 2024 00:44:56 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:dec2:7d97:e7f:4c60]) by smtp.gmail.com with ESMTPSA id q16-20020a170902b11000b001da27cbcf5dsm747213plr.228.2024.02.15.00.44.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 00:44:56 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 0F74B11423AD; Thu, 15 Feb 2024 19:14:54 +1030 (ACDT) Date: Thu, 15 Feb 2024 19:14:54 +1030 From: Alan Modra To: binutils@sourceware.org Subject: PR28448, Memory leak in function add_symbols(plugin.c) Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3033.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: PR 28448 * plugin.c (add_symbols): bfd_alloc memory for symptrs. Check bfd_make_empty_symbol return. diff --git a/ld/plugin.c b/ld/plugin.c index e982869072b..f81ab02b3a6 100644 --- a/ld/plugin.c +++ b/ld/plugin.c @@ -506,7 +506,9 @@ add_symbols (void *handle, int nsyms, const struct ld_plugin_symbol *syms) int n; ASSERT (called_plugin); - symptrs = xmalloc (nsyms * sizeof *symptrs); + symptrs = bfd_alloc (abfd, nsyms * sizeof *symptrs); + if (symptrs == NULL) + return LDPS_ERR; for (n = 0; n < nsyms; n++) { enum ld_plugin_status rv; @@ -514,6 +516,8 @@ add_symbols (void *handle, int nsyms, const struct ld_plugin_symbol *syms) bfdsym = bfd_make_empty_symbol (abfd); symptrs[n] = bfdsym; + if (bfdsym == NULL) + return LDPS_ERR; rv = asymbol_from_plugin_symbol (abfd, bfdsym, syms + n); if (rv != LDPS_OK) return rv; -- Alan Modra Australia Development Lab, IBM