From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Subject: memory leak in objdump disassemble_section
Date: Wed, 7 Feb 2024 22:44:09 +1030 [thread overview]
Message-ID: <ZcN0EXQQ9Ie5YyAh@squeak.grove.modra.org> (raw)
* objdump.c (disassemble_section): Free rel_ppstart on error path.
diff --git a/binutils/objdump.c b/binutils/objdump.c
index 49e944b1dfd..7beb221cb2f 100644
--- a/binutils/objdump.c
+++ b/binutils/objdump.c
@@ -3795,6 +3795,7 @@ disassemble_section (bfd *abfd, asection *section, void *inf)
{
non_fatal (_("Reading section %s failed because: %s"),
section->name, bfd_errmsg (bfd_get_error ()));
+ free (rel_ppstart);
return;
}
@@ -4075,9 +4076,7 @@ disassemble_section (bfd *abfd, asection *section, void *inf)
}
free (data);
-
- if (rel_ppstart != NULL)
- free (rel_ppstart);
+ free (rel_ppstart);
}
/* Disassemble the contents of an object file. */
--
Alan Modra
Australia Development Lab, IBM
reply other threads:[~2024-02-07 12:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcN0EXQQ9Ie5YyAh@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).