From: Alan Modra <amodra@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH v3 0/6] elf: Use mmap to map in section contents
Date: Thu, 7 Mar 2024 09:30:12 +1030 [thread overview]
Message-ID: <Zej1fM0pT9g+S3id@squeak.grove.modra.org> (raw)
In-Reply-To: <20240306204731.1098405-1-hjl.tools@gmail.com>
On Wed, Mar 06, 2024 at 12:47:25PM -0800, H.J. Lu wrote:
> Changes in v3:
I ran my target tests against this version and found two regressions.
mipsisa32r2el-elf +FAIL: MIPS eh-frame 3
mipstx39-elf +FAIL: MIPS eh-frame 3
The keep_memory change causes this code in
bfd/elfxx-mips.c:_bfd_mips_elf_eh_frame_address_size to fail:
if (sec->reloc_count > 0
&& elf_section_data (sec)->relocs != NULL
&& (ELF32_R_TYPE (elf_section_data (sec)->relocs[0].r_info)
== R_MIPS_64))
return 8;
Yes, the test also fails with --no-keep-memory so this is really a bug
in the mips backend, but we should try to not break this code.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2024-03-06 23:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 20:47 H.J. Lu
2024-03-06 20:47 ` [PATCH v3 1/6] bfd: Don't hard-code BFD_JUMP_TABLE_COPY H.J. Lu
2024-03-06 20:47 ` [PATCH v3 2/6] bfd: Change the --with-mmap default to true H.J. Lu
2024-03-06 20:47 ` [PATCH v3 3/6] elf: Use mmap to map in read-only sections H.J. Lu
2024-03-06 20:47 ` [PATCH v3 4/6] elf: Add _bfd_elf_mmap_section and _bfd_elf_munmap_section_contents H.J. Lu
2024-03-06 20:47 ` [PATCH v3 5/6] elf: Use mmap to map in symbol and relocation tables H.J. Lu
2024-03-06 20:47 ` [PATCH v3 6/6] elf: Don't cache symbol nor relocation tables with mmap H.J. Lu
2024-03-06 23:00 ` Alan Modra [this message]
2024-03-06 23:26 ` [PATCH v3 0/6] elf: Use mmap to map in section contents H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zej1fM0pT9g+S3id@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).