From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by sourceware.org (Postfix) with ESMTPS id B846A3858D35 for ; Fri, 8 Mar 2024 03:34:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B846A3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B846A3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::22d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709868843; cv=none; b=L/0kqw7nx7lGyJIHAKWbbDsE9YVga2xELcWEpwo/+GBdV9zL8vMW9msfU61tFic/4jVHHIciTxRI8BliR2VHgVAkZTx/15Mtaw386nSo5Nkh2T429WKT5NSZgPDM5EMPcrZhDHMIkt49wr4WPKk0aIc3P+4DUW47jeUOdMinDLg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709868843; c=relaxed/simple; bh=Ma+UuY2JFg4XnYpaoFxqK2ss0pUHNJeJnfu5XKW02CQ=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=GUw87t5yiMvCk+/8gbVOqij629K4us8Woq+TRsOrv1BQfekAF8qM57WT652NZgC8bGKENJ0QbPxq594uUh2DPk8GyRBg/7t6Ttd9x+hxzBi+Qjn/UU/Khh/1iyO/upC8Xzzto2QV2B6494vcq2OEaheHEZnDMUxRqe/QnarUvVQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-3c21ecc072cso679275b6e.2 for ; Thu, 07 Mar 2024 19:34:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709868841; x=1710473641; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ScjjLZTsuOO3Dx7wlJyikRmMVJwMytnvMt/S67HBpH4=; b=UthXM5eoA0UQGH7CtNzIWRJeatVn34b5YXksXemH4QRqqd5N8wqeCOFy4dWmiADs+8 2iBv3RjBwT62/zItEhSRiZ3ALPJAxfiBMRlIuH6ZH78ufrkvbplFI6+9ZIPsqmAA2MGs 9IJkfiWP/GemDK+6HQJkHEwG4s7MQrgKD9IC2C3YzR1ph+q04NssImez3vKBf5mGIB8B ZrdNVjfGA3avJ3UT7UBo+JK+z6X4CaGUZF7U7uaXRJWGfiKVeByCpfqJGlPTJdnof4dx lUOAaZlQ/ATQaOnOjkMj9hGwuzC6UrwZwsl45GaX8SzAOtyXJVE9WAx1N0n6ECVAkMVs XK4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709868841; x=1710473641; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ScjjLZTsuOO3Dx7wlJyikRmMVJwMytnvMt/S67HBpH4=; b=nnQHhbfiybPQcvmytg6wQUI+obS+nfDCsnd1DQz6aN58pflEW3KyXvklXjv59aux5N 7462Ijg+yqd7NuLnkKahTyHEIvzthe4nKjAg+HDcjbwUW75BpitPO8i/Rgxo1IzUkyDU QuLROIpFqXp7ZWwl6Ne+akYOm2JEUq3Ykld1UP5E97kfd6wO7/Xd/e1KhjqWCk5eOR3n GDsJFcVnmk3w44s+8kn45gM+Wx2sEBqheFsq85BDZyhiaML90F5sWFuASVwCLh6AxxMF KVWauf0WDZrzAeme5iclimFVYXdSMlRMzQremSnc2FI7ya3WRS/YAV742MuOkgD40v09 De2g== X-Forwarded-Encrypted: i=1; AJvYcCUNVAnvNobH39FBIQEclcYtEVGDecEFZ4Wkgfo7o3oDGoTOtWBusuLvHJvDDY3aGoyXlOqtMF3aFmSIvqcmVfUOaXe/Oj5W6g== X-Gm-Message-State: AOJu0YxnN1bM9pG2HBfUpkAa5BfDPi9u6QqA03ZCzSUypLsok6rjg59L eqO/0M58M7YyatpxxRvhYlb+TRsoG2ZnZN5/JFPvxcGbODbLG3ms X-Google-Smtp-Source: AGHT+IFF3b5grAz7nIyAtOi55PNEJjVC6tyZuwoWZMni9tsRhp4UEhWPrr52GDIeWqpUGdtSBTQXBg== X-Received: by 2002:a05:6808:1408:b0:3c2:1191:763d with SMTP id w8-20020a056808140800b003c21191763dmr10625929oiv.27.1709868840874; Thu, 07 Mar 2024 19:34:00 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id p28-20020aa79e9c000000b006e65d676d3dsm1949216pfq.18.2024.03.07.19.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 19:34:00 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 9E38F1140119; Fri, 8 Mar 2024 14:03:57 +1030 (ACDT) Date: Fri, 8 Mar 2024 14:03:57 +1030 From: Alan Modra To: Sam James Cc: "H.J. Lu" , binutils@sourceware.org, goldstein.w.n@gmail.com Subject: Re: [PATCH v4 4/6] elf: Add _bfd_elf_mmap_section and _bfd_elf_munmap_section_contents Message-ID: References: <20240306232401.1408530-1-hjl.tools@gmail.com> <20240306232401.1408530-5-hjl.tools@gmail.com> <87a5n9y2aj.fsf@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a5n9y2aj.fsf@gentoo.org> X-Spam-Status: No, score=-3027.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Mar 08, 2024 at 12:50:44AM +0000, Sam James wrote: > "H.J. Lu" writes: > > --- a/bfd/elfxx-x86.h > > +++ b/bfd/elfxx-x86.h > > @@ -960,6 +960,7 @@ extern void _bfd_x86_elf_link_report_relative_reloc > > _bfd_elf_x86_size_relative_relocs > > #define elf_backend_finish_relative_relocs \ > > _bfd_elf_x86_finish_relative_relocs > > +#define elf_backend_use_mmap true > > I'm a bit worried that yet-another-param is going to lead to it being > forgotten about for most backends. Well, yes, but I found two backends with bugs tickled by the mmap patchset, and that was just with the binutils testsuite. See pr31458 and pr31461. Very likely there are other problems lurking. For now I think it is reasonable to leave the mmap change as opt-in. At some point we should change to opt-out. > Maybe send out a request for testing once merged, asking people to test > and enable it in their respective backends? It's very easy to miss > otherwise. Someone who builds lots of packages for a distro would be ideal for that testing. ;-) -- Alan Modra Australia Development Lab, IBM