From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id AFA6F3858D20 for ; Tue, 16 Apr 2024 23:57:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AFA6F3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AFA6F3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713311848; cv=none; b=iGCT3p25a1YN8PExEaS9+/zwPhzB9e+8wgQHNDt8ZpTIIIp4L2aMTpQTqYT1trumN54ER/ET7WqZ3HqgBzU+OXkKQHsGSRF3q2hw94Z1EmfDAfeygVTqguDlEJq9kwkNUrel2Y+vHGYmUTJu+w2xkcm/dPis1+zqZVMYHR1fcgk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713311848; c=relaxed/simple; bh=JM62oaDqh+36H4k5UYEINu6AdSbB+/FqImhrlRr+k2E=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=iUX5NW6YHX0d62lWFylPLRuCPTw8U910qVDXP9oQ4yxRMBSjS08uiwS3Wp3OP4StmNpNCJfnGcZdmBBjzZAHI1wRzEVhZPTOehOaiNG73Xm05ss+XR6JFDoYOcoXTSXFIz0+FmWaBO4Xz4eynqFHpyXxMsfnztSG6xu+NI00nzY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-6f043f9e6d7so908324b3a.3 for ; Tue, 16 Apr 2024 16:57:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713311845; x=1713916645; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=rTrMymFwjNb4mdqWQZW1RjezXQ7nc348hwMAetnpz5U=; b=ccNkapQvTTx9149VR1VKMmAbzPmWw9Ytr7GKDqIGik4WXpf4Ez6mcNN2XhZORqA4NE mznK2IlBep/q/Rmttf9LmCJR4BklNNFlKBNoo5zEmvgjdA7D/FCkjcASQidU1C4BVIHJ utXmqRcbugnrCBGSa5qG7eNwBSO/lFjy8K//RZBWPHbayJp14x6k6pnrtztyfU76Ko5W 5WfzfDwlZ+tZIOqhP2u1m65COzSNa4J1hbY+awo6ae0m0OW/z7ees3nxr6bxt0/DoC2a 3LwPNWUbtc5vcMCEDEM7j2w9XD22qFyUXxTKu/KCPk0oK9AB8310hepp7PrXf2B+C8kp nFLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713311845; x=1713916645; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rTrMymFwjNb4mdqWQZW1RjezXQ7nc348hwMAetnpz5U=; b=a4Jw8G2osFy/K8Sypi04MgCgku8YJwreMsXqTxdADRQ0SA8SEjRly187loKNIp6/L8 3wOlQc0+HkXBY9Eofb33dNYwl1TJPf2yV2L0hh5FpK9h9QdAv0JdU7iIWflgp+WpSQNi asLctQ09YW6Oo0SmY73lIt3YB+YknE/PUQf7aRR7r9zlibC5Bwm/0uLb++1gn/6/JTzu I8U3TNCT3xsFPWotgl0+a5tkjEmra+zDAti0batfaXX8bu/iMUvW2ApaYsFYQdha4g6G YGV9bIe/JK6mYSm14ri4/dAweb1OQofTmbuUNnNDB6wa30ilbRW7Uoe/HKYqOT6XHV8O RRLg== X-Gm-Message-State: AOJu0YwYjdVIt3mkKbrWc19HaqcXOon6VRv7r5dUthC3AaM47cTmPA41 EsW4MQZdq8RTuaR7+8gY+3agWo/dfuXuFeXnAjvlba66zN4NI88XTgXE3A== X-Google-Smtp-Source: AGHT+IEEaC3S3tIZ5IF+r52ou1mZch058MNjUfmKRByt8Wsgr5xBRj/z7po0r/ISf534DWNLLH9xLw== X-Received: by 2002:a05:6a00:1886:b0:6ea:f369:f20f with SMTP id x6-20020a056a00188600b006eaf369f20fmr17119352pfh.1.1713311845385; Tue, 16 Apr 2024 16:57:25 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id ld16-20020a056a004f9000b006ecf72e481esm9600970pfb.26.2024.04.16.16.57.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 16:57:25 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 9D20911421AD; Wed, 17 Apr 2024 09:27:22 +0930 (ACST) Date: Wed, 17 Apr 2024 09:27:22 +0930 From: Alan Modra To: binutils@sourceware.org Subject: ARC e_flags vs. objcopy Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3033.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: While the patch that Nick reverted in commit 3f6a060c7543 was in the source, "FAIL: objcopy executable (pr25662)" was seen on ARC. The failure was triggered by the .ARC.attributes section being removed by the linker script. When a file lacking this section is copied by objcopy, e_flags from the input is copied to the output (in this case the value 0x406), but arc_elf_final_write_processing then logical-ors in 0x300 when Tag_ARC_ABI_osver is not found. * elf32-arc.c (arc_elf_final_write_processing): Don't ignore existing e_flags for objcopy. diff --git a/bfd/elf32-arc.c b/bfd/elf32-arc.c index 7e94373773b..bd182996654 100644 --- a/bfd/elf32-arc.c +++ b/bfd/elf32-arc.c @@ -1045,9 +1045,6 @@ static bool arc_elf_final_write_processing (bfd *abfd) { unsigned long emf; - int osver = bfd_elf_get_obj_attr_int (abfd, OBJ_ATTR_PROC, - Tag_ARC_ABI_osver); - flagword e_flags = elf_elfheader (abfd)->e_flags & ~EF_ARC_OSABI_MSK; switch (bfd_get_mach (abfd)) { @@ -1062,12 +1059,15 @@ arc_elf_final_write_processing (bfd *abfd) elf_elfheader (abfd)->e_machine = emf; /* Record whatever is the current syscall ABI version. */ + int osver = bfd_elf_get_obj_attr_int (abfd, OBJ_ATTR_PROC, + Tag_ARC_ABI_osver); + flagword e_flags = elf_elfheader (abfd)->e_flags; if (osver) - e_flags |= ((osver & 0x0f) << 8); - else + e_flags = (e_flags & ~EF_ARC_OSABI_MSK) | ((osver & 0x0f) << 8); + else if ((e_flags & EF_ARC_OSABI_MSK) == 0) e_flags |= E_ARC_OSABI_V3; - elf_elfheader (abfd)->e_flags |= e_flags; + elf_elfheader (abfd)->e_flags = e_flags; return _bfd_elf_final_write_processing (abfd); } -- Alan Modra Australia Development Lab, IBM