From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id A885D3858D1E for ; Fri, 5 Apr 2024 23:53:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A885D3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A885D3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::433 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712361227; cv=none; b=O94ZyWpsNT3Eb0/iTsDv5OVde50EnximGLPmqETJEX7vs3oVWMBBS7OmzYtNOaQ6IKN5u+MWc9XmVcrXfJAcJwVCxfg0XyQT3UtWHvDBs8PmlT+0QotQVrwPxlImQp0YMLQKfl3gvwmM99HjKHDPHLTVRld2ioXc6CBFQNaypwE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712361227; c=relaxed/simple; bh=oHC1Bwb0zoUun9XQWyamk1FQgHBWxbPOkxEAwEdOqks=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=EUBaz60LrkRHpv5FERU65y904Dnp66KUNzL/AbH+Wob61I0G/FmP70JhTtBuXadMS/gm/m+P77e7lfjAClPlIsmKs/4NoDto+plQJq9z/lVYwuh3SQ9mwqp/LcWt31Oi4HNKOLNlNpZdGIG/Kvv2zbxrnjnkI5dkcD00kxfjA/g= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6ecea46e1bfso2471536b3a.3 for ; Fri, 05 Apr 2024 16:53:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712361225; x=1712966025; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zYA166r/WQp6YFoAL9+gGyCBjxTFiJd0MjTPi84aib8=; b=KtfcGas1iQ0Hi7zvwtswPoBvefYMqVjqoGuhNyXayCB5aes3dCdP4akHQSV4nZXI8T mb+yewlpuwVoJHN2q6FxHLk6VMhg1Vp3VuQ8HDCNEZEU6BwWKe0/MEqIG4zvedggcQMC gFFIBYhwygepoYFuYw3/fHMZDoBxa8yvEiQcKgDc4IAzlzXDEbLlqvE4AM6aj+hDw/M1 lF9N0yWL6xnyQmJyyeVq8dM62LqYz1bL/qdrYYR9gizELTbX0OHCAi47ZfHq5X9q3o7H qHdTqTFjrElXKSD6QtY0TzlN1CxInH4Nh72o085RJIc2YTFBHALJfNG6k/xqKm4EDLUs /V5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712361225; x=1712966025; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zYA166r/WQp6YFoAL9+gGyCBjxTFiJd0MjTPi84aib8=; b=GnWNXOvnfrxTEVqSWTxmth1YGJckAL34yYZ2MlZOf1bpHQpB9c/TInCGVULfEEY50w 58pQQ7pFkRigk6+uT5SKDWycX8cN3YTBeSBwc6BtBZhcj9J+nW2v7Tg17jTuA18/ECdW zScpBKmTvtRWY5KLxxonj52TLHAlqaqNgAN2dyjLfUuR4aH1e+GaKz3JcP7AM6FX43p6 jHB8ZcGYrwDsMjPDqSGruKfu9cgFsKV/NOUqSGb129rJTUyRRJHsRT7rSB+rwBUs2S1B ixzUmNEIV8KdlQh62sM+9gnP94E41cM6eY9d9g901FQGKvVmbFAQ818ccDGyPw1fmnRr 0kgQ== X-Gm-Message-State: AOJu0YxNleRV8Fe7ndsRE5QXRtRyiZAv7gB7QBZ4FcmPz3FmKr8rayYT N4mHgZYgCbZxO9Nh5hXCZB5AveJY/Kk0K3DjtvvL//1jr5v/0mPy X-Google-Smtp-Source: AGHT+IGVLrHkQ6BMQGy2/8Fga0EmYY1crHLeujQ55f9Bf5lQyF43z1KQIlSkVzYgQkgM1wMySft9kw== X-Received: by 2002:a05:6a00:23d2:b0:6ec:f566:6eb0 with SMTP id g18-20020a056a0023d200b006ecf5666eb0mr3224188pfc.17.1712361224564; Fri, 05 Apr 2024 16:53:44 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:619:cdbb:6b8:965c]) by smtp.gmail.com with ESMTPSA id it10-20020a056a00458a00b006ece7862035sm2077454pfb.128.2024.04.05.16.53.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 16:53:44 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 01741114031D; Sat, 6 Apr 2024 10:23:41 +1030 (ACDT) Date: Sat, 6 Apr 2024 10:23:41 +1030 From: Alan Modra To: "H.J. Lu" Cc: binutils@sourceware.org Subject: Re: [PATCH] elf: Use elf_link_first_hash_entry for first_hash Message-ID: References: <20240405233758.2040146-1-hjl.tools@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240405233758.2040146-1-hjl.tools@gmail.com> X-Spam-Status: No, score=-3025.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Apr 05, 2024 at 04:37:58PM -0700, H.J. Lu wrote: > @@ -4341,11 +4377,11 @@ elf_link_add_object_symbols (bfd *abfd, struct bfd_link_info *info) > && htab->first_hash == NULL) > { > /* Initialize first_hash for an IR input. */ > - htab->first_hash = (struct bfd_link_hash_table *) > - xmalloc (sizeof (struct bfd_link_hash_table)); > - if (!bfd_hash_table_init (&htab->first_hash->table, > - _bfd_link_hash_newfunc, > - sizeof (struct bfd_link_hash_entry))) > + htab->first_hash = (struct bfd_hash_table *) > + xmalloc (sizeof (struct bfd_hash_table)); > + if (!bfd_hash_table_init > + (htab->first_hash, elf_link_first_hash_newfunc, > + sizeof (struct elf_link_first_hash_entry))) > info->callbacks->einfo > (_("%F%P: first_hash failed to initialize: %E\n")); > } I didn't notice this before, but you shouldn't really be using xmalloc in libbfd. Yes, as a practical matter it isn't so relevant for linker-only bfd functions, but it's probably worth fixing here. -- Alan Modra Australia Development Lab, IBM